Revert revert moving tasks to admins room for "Manage my team expenses" intent by c3024 · Pull Request #53661 · Expensify/App

c3024 · 2024-12-05T21:47:59Z

Explanation of Change

Reverts #53598. Onboarding tasks are shown in the DM of the guide assigned and this is not expected. This needs a backend fix. So, while backend changes are being done, #52314 was reverted with #53598. This revert of the revert PR will be merged after the backend changes are deployed.

Fixed Issues

$ #51443
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Test 1:

Logon to ND with a new email without a '+' in it.
Click on "Manage my team's expenses" intent on the onboarding flow and complete the onboarding.
Verify that the onboarding tasks show up in the #admins room.

Test 2:

Logon to ND with a new email with a '+' in it.
Click on "Manage my team's expenses" intent on the onboarding flow and complete the onboarding.
Verify that the onboarding tasks show up in the Concierge chat.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-12-05T21:52:58Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jjcoffee · 2024-12-06T09:27:07Z

@c3024 I think I'm missing some context here 😅 Should I just blind approve or does this need testing?

c3024 · 2024-12-06T11:45:11Z

@jjcoffee

Sorry! Updated the context in the "Explanation of Change" in the PR template. This needs to be tested once the backend changes are deployed. This thread has more info.

jjcoffee · 2024-12-06T13:34:58Z

@c3024 No worries, thanks for the info! I'll wait until the BE changes are deployed then. I don't think I have access to that thread, what room is it in?

c3024 · 2024-12-06T13:37:50Z

It is in #convert room.

yuwenmemon · 2024-12-10T23:47:03Z

Server-side code was deployed so merging this!

yuwenmemon · 2024-12-10T23:47:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

OSBotify · 2024-12-10T23:57:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-12-12T01:59:11Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.75-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

izarutskaya · 2024-12-12T09:15:24Z

@c3024 PR is failing with #53987, #53999

https://platform.applause.com/services/links/v1/external/0f8560ee979c900eecb177ddad544634393d08e5f87501d5431546d6319efe06

github-actions · 2024-12-13T15:41:16Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.75-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

DylanDylann · 2025-02-12T04:10:45Z

src/components/LHNOptionsList/OptionRowLHN.tsx

+
+    // Guides are assigned for the MANAGE_TEAM onboarding action, except for emails that have a '+'.
+    const isOnboardingGuideAssigned = introSelected?.choice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM && !session?.email?.includes('+');
+    const shouldShowToooltipOnThisReport = isOnboardingGuideAssigned ? ReportUtils.isAdminRoom(report) : ReportUtils.isConciergeChatReport(report);


We only should show tooltips in the onboarding admin room

ref: #55483

revert revert move tasks to admins room

824b4b3

c3024 marked this pull request as ready for review December 5, 2024 21:52

c3024 requested a review from a team as a code owner December 5, 2024 21:52

melvin-bot bot requested a review from jjcoffee December 5, 2024 21:52

melvin-bot bot removed the request for review from a team December 5, 2024 21:52

c3024 mentioned this pull request Dec 5, 2024

[HOLD for payment 2024-12-20] [HOLD for payment 2024-12-11] [$250] Move onboarding tasks into the #admins room for admins #51443

Closed

6 tasks

yuwenmemon self-requested a review December 5, 2024 22:44

yuwenmemon assigned c3024 Dec 5, 2024

c3024 mentioned this pull request Dec 9, 2024

[HOLD for payment 2025-01-28] [$250] Onboarding - "Start a free trial" banner and button appear in Concierge then disappear #53526

Closed

8 tasks

yuwenmemon approved these changes Dec 10, 2024

View reviewed changes

yuwenmemon merged commit bebf6d8 into Expensify:main Dec 10, 2024

github-actions bot mentioned this pull request Dec 12, 2024

Deploy Checklist: New Expensify 2024-12-12 #53978

Closed

55 tasks

c3024 mentioned this pull request Dec 12, 2024

[$250] Login - Onboarding flow is dismissed before selecting accounting software. #53999

Closed

8 tasks

DylanDylann reviewed Feb 12, 2025

View reviewed changes

DylanDylann mentioned this pull request Feb 12, 2025

[Due for payment 2025-02-13] [$250] Get started tooltip shown on multiple #admins room. #55483

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert revert moving tasks to admins room for "Manage my team expenses" intent#53661

Revert revert moving tasks to admins room for "Manage my team expenses" intent#53661
yuwenmemon merged 1 commit intoExpensify:mainfrom
c3024:revert-revert-move-tasks-to-admins-room

c3024 commented Dec 5, 2024 •

edited

Loading

Uh oh!

melvin-bot bot commented Dec 5, 2024

Uh oh!

jjcoffee commented Dec 6, 2024

Uh oh!

c3024 commented Dec 6, 2024

Uh oh!

jjcoffee commented Dec 6, 2024

Uh oh!

c3024 commented Dec 6, 2024

Uh oh!

yuwenmemon commented Dec 10, 2024

Uh oh!

yuwenmemon commented Dec 10, 2024 •

edited

Loading

Uh oh!

OSBotify commented Dec 10, 2024

Uh oh!

github-actions bot commented Dec 12, 2024

Uh oh!

izarutskaya commented Dec 12, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Dec 13, 2024

Uh oh!

DylanDylann Feb 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

c3024 commented Dec 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 5, 2024

Uh oh!

jjcoffee commented Dec 6, 2024

Uh oh!

c3024 commented Dec 6, 2024

Uh oh!

jjcoffee commented Dec 6, 2024

Uh oh!

c3024 commented Dec 6, 2024

Uh oh!

yuwenmemon commented Dec 10, 2024

Uh oh!

yuwenmemon commented Dec 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

OSBotify commented Dec 10, 2024

Uh oh!

github-actions bot commented Dec 12, 2024

Uh oh!

izarutskaya commented Dec 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 13, 2024

Uh oh!

DylanDylann Feb 12, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

c3024 commented Dec 5, 2024 •

edited

Loading

yuwenmemon commented Dec 10, 2024 •

edited

Loading

izarutskaya commented Dec 12, 2024 •

edited

Loading