[CP Staging] Fix - `A Follow up on` [CRITICAL] Multiple workspaces get created when someone either refreshes the page, or drops off and returns later. by FitseTLT · Pull Request #53093 · Expensify/App

FitseTLT · 2024-11-25T22:19:52Z

Details

Fixed Issues

$ #52894
PROPOSAL: #52894 (comment)

Tests

Sign-up on expensify.com
Choose the “1-9” option on the home page (signUpQualifier: vsb)
Get redirected to new.expensify.com
Observe a workspace is created
Don’t complete the onboarding modal steps (hasCompletedGuidedSetupFlow: false)
Refresh the page on web or close and re-open app on native
Verify that another workspace is not created

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

a.mp4

Android: mWeb Chrome

aw.mp4

iOS: Native

i.mp4

iOS: mWeb Safari

iw.mp4

MacOS: Chrome / Safari

w.mp4

MacOS: Desktop

2024-11-26.01-31-44.mp4

…time

melvin-bot · 2024-11-25T22:19:57Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

FitseTLT · 2024-11-25T22:22:11Z

@jayeshmangwani To reproduce on native I had to remove isVsb check here

App/src/pages/OnboardingAccounting/BaseOnboardingAccounting.tsx

Line 63 in 62ebd13

    
           if (!isVsb || !!onboardingPolicyID || isLoadingOnyxValue(onboardingPolicyIDResult) || isOnboardingPolicyIDCleared.current) {

and started the sign up flow in ND selecting Manage teams > 1 - 10 employees > and then closing and reopening the app
Hope it will be helpful 👍

FitseTLT · 2024-11-26T14:26:05Z

@mountiny You can consider reviewing this if it is too critical to wait for @jayeshmangwani's review 👍

github-actions · 2024-11-26T17:18:30Z

🚧 @mountiny has triggered a test build. You can view the workflow run here.

ishpaul777 · 2024-11-26T17:22:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android.mov

Android: mWeb Chrome

Android-chrome.mov

iOS: Native

Screen.Recording.2024-11-27.at.7.00.22.PM-1.mov

iOS: mWeb Safari

safari.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-27.at.5.53.32.PM.mov

MacOS: Desktop

Screen.Recording.2024-11-27.at.6.46.54.PM.mov

github-actions · 2024-11-26T17:47:08Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/53093/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/53093/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/53093/NewExpensify.dmg	https://53093.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

ishpaul777 · 2024-11-26T18:40:00Z

Still not fixed on Desktop

1st it creates a workspace on web ND on which it is landed from OD, then when redirected of Desktop app it creates a workspace again

Screen.Recording.2024-11-27.at.12.07.18.AM.mov

@FitseTLT

FitseTLT · 2024-11-26T18:44:28Z

Still not fixed on Desktop

1st it creates a workspace on web ND on which it is landed from OD, then when redirected of Desktop app it creates a workspace again

Screen.Recording.2024-11-27.at.12.07.18.AM.mov
@FitseTLT

Yeah @ishpaul777 unfortunately we are currently saving the onboardingPolicy in onyx only, so there is no way for the Desktop to know about the onboardingPolicy that was created in web.
@mountiny Do you think we should avoid creating onboarding policies if a user has a workspace already created ?? In that case we can avoid this bug without a need of BE changes.

ishpaul777 · 2024-11-26T18:54:53Z

i believe this is the case what are failing in QA test here otherwise i could not recreate issue even without these changes. 🤔

FitseTLT · 2024-11-26T19:06:29Z

i believe this is the case what are failing in QA test here otherwise i could not recreate issue even without these changes. 🤔

But I did recreate it on IOS before the fix as it was also mentioned in #52899 (comment)

mountiny · 2024-11-26T21:17:32Z

Do you think we should avoid creating onboarding policies if a user has a workspace already created ?? In that case we can avoid this bug without a need of BE changes.

Yes I think that we should not create a new policy if they already have one

ishpaul777 · 2024-11-26T22:29:27Z

But I did recreate it on IOS before the fix as it was also mentioned in #52899 (comment)

@ jayeshmangwani To reproduce on native I had to remove isVsb check

When qa reproduced this they did not have the abilty make any changes in the code, right? so this should be reproducable as is no?

we should avoid creating onboarding policies if a user has a workspace already created

Regardless, i think this should be enough and we did not need the current changes anymore after adding this check

FitseTLT · 2024-11-26T23:04:48Z

@ishpaul777 Fixed! U can proceed.

src/pages/OnboardingAccounting/BaseOnboardingAccounting.tsx

ishpaul777 · 2024-11-27T00:10:12Z

I have finished up for today, will test changes tmrw when i start

ishpaul777 · 2024-11-27T13:39:13Z

LGTM 🚀

mountiny · 2024-11-28T12:32:08Z

src/pages/OnboardingAccounting/BaseOnboardingAccounting.tsx

    // So we need to create the new workspace in the accounting step
    useEffect(() => {
-        if (!isVsb || !!onboardingPolicyID || isLoadingOnyxValue(onboardingPolicyIDResult)) {
+        const filteredPolicies = Object.values(allPolicies ?? {}).filter(PolicyUtils.isPaidGroupPolicy);


Lets change this to some, we just need to know they have one paid policy we dont have to iterate over the entire list

Should I raise another PR? because pushing the changes is not working because the pr is merged.

@mountiny but it might not be much of a concern as the onboarding flow is displayed when the user has one or none workspaces WDYT

You can just add it in some future pr

I can raise a quick one now and you can merge it. WDYT??

…n-bug [CP Staging] Fix - `A Follow up on` [CRITICAL] Multiple workspaces get created when someone either refreshes the page, or drops off and returns later. (cherry picked from commit 3b832f8) (CP triggered by mountiny)

OSBotify · 2024-11-28T12:38:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-28T13:15:12Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.67-9 🚀

platform	result
🤖 android 🤖	false ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2024-11-28T14:23:15Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.67-9 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

avoided running the onboarding policy creation effect for the second …

62ebd13

…time

FitseTLT requested a review from a team as a code owner November 25, 2024 22:19

melvin-bot bot requested a review from jayeshmangwani November 25, 2024 22:19

melvin-bot bot removed the request for review from a team November 25, 2024 22:19

mountiny assigned FitseTLT Nov 26, 2024

mountiny requested a review from ishpaul777 November 26, 2024 17:17

mountiny added the Ready To Build label Nov 26, 2024

FitseTLT added 3 commits November 27, 2024 01:46

avoid creating onboarding policy when a workspace exists

b519967

remove unnecessary import

c781e69

remove onboardingPolicyID from the condition

06a7c9d

ishpaul777 reviewed Nov 27, 2024

View reviewed changes

src/pages/OnboardingAccounting/BaseOnboardingAccounting.tsx Outdated Show resolved Hide resolved

FitseTLT added 2 commits November 27, 2024 15:32

filtered out personal policies

39d000d

Merge branch 'main' into fix-onboarding-policy-creation-bug

8fd2c45

FitseTLT requested a review from ishpaul777 November 27, 2024 12:44

ishpaul777 approved these changes Nov 27, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny November 27, 2024 13:39

trjExpensify mentioned this pull request Nov 28, 2024

[CRITICAL] New sign-ups redirected from OldDot have two workspaces created on completion of the onboarding modal. #53236

Closed

8 tasks

mountiny approved these changes Nov 28, 2024

View reviewed changes

mountiny merged commit 3b832f8 into Expensify:main Nov 28, 2024

mountiny reviewed Nov 28, 2024

View reviewed changes

github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Nov 28, 2024

github-actions bot mentioned this pull request Nov 28, 2024

Deploy Checklist: New Expensify 2024-11-26 #53142

Closed

75 tasks

melvin-bot bot mentioned this pull request Nov 28, 2024

[HOLD for payment 2024-12-07] [HOLD for payment 2024-12-05] [HOLD for payment 2024-12-03] [$250] [CRITICAL] Multiple workspaces get created when someone either refreshes the page, or drops off and returns later. #52894

Closed

8 tasks

Conversation

FitseTLT commented Nov 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Nov 25, 2024

Uh oh!

FitseTLT commented Nov 25, 2024

Uh oh!

FitseTLT commented Nov 26, 2024

Uh oh!

github-actions bot commented Nov 26, 2024

Uh oh!

ishpaul777 commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Nov 26, 2024

Uh oh!

ishpaul777 commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FitseTLT commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ishpaul777 commented Nov 26, 2024

Uh oh!

FitseTLT commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mountiny commented Nov 26, 2024

Uh oh!

ishpaul777 commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FitseTLT commented Nov 26, 2024

Uh oh!

Uh oh!

ishpaul777 commented Nov 27, 2024

Uh oh!

ishpaul777 commented Nov 27, 2024

Uh oh!

mountiny Nov 28, 2024

Choose a reason for hiding this comment

Uh oh!

FitseTLT Nov 28, 2024

Choose a reason for hiding this comment

Uh oh!

FitseTLT Nov 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mountiny Nov 28, 2024

Choose a reason for hiding this comment

Uh oh!

FitseTLT Nov 28, 2024

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Nov 28, 2024

Uh oh!

github-actions bot commented Nov 28, 2024

Uh oh!

github-actions bot commented Nov 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

FitseTLT commented Nov 25, 2024 •

edited

Loading

ishpaul777 commented Nov 26, 2024 •

edited

Loading

ishpaul777 commented Nov 26, 2024 •

edited

Loading

FitseTLT commented Nov 26, 2024 •

edited

Loading

FitseTLT commented Nov 26, 2024 •

edited

Loading

ishpaul777 commented Nov 26, 2024 •

edited

Loading

FitseTLT Nov 28, 2024 •

edited

Loading