Skip to content

Conversation

@robertjchen
Copy link
Contributor

Let's mirror Slack's behavior! Command + w will minimize the chat window instead of closing it, Command + q will quit the Expensify Chat app entirely 👍

Fixes https://github.com/Expensify/Expensify/issues/141666

@robertjchen robertjchen requested a review from a team September 24, 2020 07:38
@robertjchen robertjchen self-assigned this Sep 24, 2020
@botify botify requested review from pecanoro and removed request for a team September 24, 2020 07:38
@robertjchen robertjchen removed the request for review from pecanoro September 24, 2020 07:59
@robertjchen
Copy link
Contributor Author

My bad, accidentally tagged PullerBear- this is ready for review, thanks!

Copy link
Contributor

@tgolen tgolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool!

@tgolen tgolen merged commit 3178664 into master Sep 24, 2020
@tgolen tgolen deleted the robert-minQuit branch September 24, 2020 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants