Skip to content

Expensify Chat: Minimize window via command + w and close via command + q #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tgolen merged 2 commits into from
Sep 24, 2020
Merged

Expensify Chat: Minimize window via command + w and close via command + q #537

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79d6b46
Minimize window via command + w and close via command + q
robertjchen Sep 24, 2020
2a59322
Use single quote
robertjchen Sep 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,20 @@ const mainWindow = (() => {
return shell.openExternal(url);
});

// Flag to determine is user is trying to quit the whole application altogether
let quitting = false;

// Closing the chat window should just hide it (vs. fully quitting the application)
browserWindow.on('close', (evt) => {
if (!quitting) {
evt.preventDefault();
browserWindow.minimize();
}
});

app.on('before-quit', () => quitting = true);
app.on('activate', () => browserWindow.show());

ipcMain.on('request-visibility', (event) => {
// This is how synchronous messages work in Electron
// eslint-disable-next-line no-param-reassign
Expand Down