migrate pendingChatMembers to reportMetadata by TMisiukiewicz · Pull Request #54247 · Expensify/App

TMisiukiewicz · 2024-12-17T12:28:46Z

Explanation of Change

Follow up PR moving another key from report collections to reportMetadata

Fixed Issues

$ #51867
PROPOSAL:

Tests

Create chatroom with two other users
Go offline
Add another member to created chat
Verify it is visible on the members list and it's greyed out

Verify that no errors appear in the JS console

Offline tests

Create chatroom with two other users
Go offline
Add another member to created chat
Verify it is visible on the members list and it's greyed out

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Create chatroom with two other users
Go offline
Add another member to created chat
Verify it is visible on the members list and it's greyed out

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

…ngChatMembers

melvin-bot · 2024-12-17T12:28:51Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…ngChatMembers

TMisiukiewicz · 2024-12-18T11:46:36Z

blocked by #54288

…ngChatMembers

shubham1206agra · 2024-12-20T08:10:49Z

src/libs/ReportUtils.ts

+        Object.entries(value).forEach(([reportID, reportMetadata]) => {
+            if (!reportMetadata) {
+                return;
+            }
+
+            const [, id] = reportID.split('_');
+            allReportMetadataKeyValue[id] = reportMetadata;
+        });


@TMisiukiewicz Is this really needed? I am not sure about this.

@shubham1206agra I decided to normalize the state here to make faster and easier calls to reportMetadata based on reportID. I was doing performance measurements and it this solution does not affect performance when making thousands of calls to reportMetadata when e.g. calculating option list

shubham1206agra · 2024-12-20T08:16:56Z

The user gets greyed out when I got online and offline again.

shubham1206agra · 2024-12-20T08:20:00Z

src/libs/actions/Policy/Member.ts

+        );
        successData.push({
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.REPORT}${report?.reportID}`,


@TMisiukiewicz You might want to update logic here. But why linter is not complaining here since this property no longer exists?

Thanks for spotting this, yeah I had this problem before and it's weird that TS is not throwing an error here. Looks like i can assign any value here, I assume the problem is somewhere else

shubham1206agra · 2024-12-20T08:27:24Z

The user gets greyed out when I got online and offline again.

@TMisiukiewicz nvm. The bug should be repro on main too. Lets fix it later.

Steps:

Create chatroom with other users
Go offline
Add another member to created chat
Delete an existing member added in step 1.
Go online and let request complete.
Go offline.

…ChatMembers

shubham1206agra · 2024-12-20T08:43:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-12-20.at.2.10.43.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-12-20.at.2.02.27.PM.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2024-12-20.at.1.58.51.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-12-20.at.1.44.59.PM.mov

MacOS: Desktop

Screen.Recording.2024-12-20.at.2.04.02.PM.mov

shubham1206agra

Please fix lint. Otherwise, good to go

TMisiukiewicz · 2024-12-20T09:32:03Z

done ✅

…ngChatMembers

puneetlath · 2024-12-23T15:48:20Z

@TMisiukiewicz you have conflicts now after I merged the other one.

…ngChatMembers

TMisiukiewicz · 2024-12-24T07:44:47Z

should be good now 👍

OSBotify · 2024-12-24T22:33:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-12-26T20:54:55Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.79-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

Beamanator · 2024-12-30T11:37:54Z

src/pages/ReportDetailsPage.tsx

-    /* eslint-disable @typescript-eslint/prefer-nullish-coalescing */
-    const [parentReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${report.parentReportID || '-1'}`);
-    const [reportNameValuePairs] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${report?.reportID || '-1'}`);
-    const [parentReportNameValuePairs] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${report?.parentReportID || '-1'}`);
-    const {reportActions} = usePaginatedReportActions(report.reportID || '-1');
-    /* eslint-enable @typescript-eslint/prefer-nullish-coalescing */
+    const [parentReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${report.parentReportID}`);
+    const [reportNameValuePairs] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${report?.reportID}`);
+    const [parentReportNameValuePairs] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${report?.parentReportID}`);
+    const {reportActions} = usePaginatedReportActions(report.reportID);


Looks like we shouldn't have removed the defaults here - Being fixed in https://github.com/Expensify/App/pull/54652/files

github-actions · 2024-12-31T21:52:14Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.79-5 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

allgandalf · 2025-02-19T06:21:58Z

src/pages/ReportDetailsPage.tsx

        if (isTrackExpenseReport && !isDeletedParentAction) {
-            const actionReportID = ReportUtils.getOriginalReportID(report.reportID, parentReportAction) ?? '0';
-            const whisperAction = ReportActionsUtils.getTrackExpenseActionableWhisper(iouTransactionID, moneyRequestReport?.reportID ?? '0');
-            const actionableWhisperReportActionID = whisperAction?.reportActionID ?? '0';


this removal of fallback caused issue

[Due for payment 2025-02-13] [$250] Track - Nothing happens when clicking on tracking options on unreported expense created on OD #54726

A detailed RCA can be found here

[Due for payment 2025-02-13] [$250] Track - Nothing happens when clicking on tracking options on unreported expense created on OD #54726 (comment)

TMisiukiewicz added 6 commits December 16, 2024 08:16

Merge branch 'main' into chore/migrate-pendingChatMembers

741fdd2

move pendingChatMembers to metadata

7a94a23

save report metadata as key value pairs

b11c74a

Merge remote-tracking branch 'upstream/main' into chore/migrate-pendi…

d0497c8

…ngChatMembers

add migration for pending members

b53c8b1

fix creating pending members in metadata

2f34725

TMisiukiewicz requested a review from a team as a code owner December 17, 2024 12:28

melvin-bot bot requested review from shubham1206agra and removed request for a team December 17, 2024 12:28

TMisiukiewicz mentioned this pull request Dec 17, 2024

[HOLD for payment 2025-01-07] [HOLD for payment 2025-01-02][LHN Mismatch] Move client-only keys from report_ to reportMetadata_ #51867

Closed

TMisiukiewicz added 10 commits December 17, 2024 14:48

Merge branch 'main' into chore/migrate-pendingChatMembers

f3d686b

Merge remote-tracking branch 'upstream/main' into chore/migrate-pendi…

0420fce

…ngChatMembers

fix lint changed

778451e

fix lint changed part 2

54b28dd

fix lint changed errors part 3

6378f73

fix typecheck

bccb31b

fix tests part 1

446c9ec

fix PolicyUtils tests

348d10d

ignore checking ReportScreen

c6c4009

fix ts

b62eb17

TMisiukiewicz added 2 commits December 19, 2024 14:45

Merge remote-tracking branch 'upstream/main' into chore/migrate-pendi…

e272a3c

…ngChatMembers

update report utils

d87bd22

shubham1206agra reviewed Dec 20, 2024

View reviewed changes

TMisiukiewicz added 2 commits December 20, 2024 09:38

Merge remote-tracking branch 'origin/main' into chore/migrate-pending…

ff39076

…ChatMembers

update pendingChatMembers in policy members

b032b30

shubham1206agra approved these changes Dec 20, 2024

View reviewed changes

melvin-bot bot requested a review from puneetlath December 20, 2024 08:44

fix linter

1adec5a

Merge remote-tracking branch 'upstream/main' into chore/migrate-pendi…

8058099

…ngChatMembers

Merge remote-tracking branch 'upstream/main' into chore/migrate-pendi…

be6c47b

…ngChatMembers

puneetlath approved these changes Dec 24, 2024

View reviewed changes

puneetlath merged commit ad99c20 into Expensify:main Dec 24, 2024

This was referenced Dec 24, 2024

Investigate workflow job failing on main: test / test (job 3) #54547

Closed

Investigate workflow job failing on main: confirmPassingBuild #54548

Closed

github-actions bot mentioned this pull request Dec 26, 2024

Deploy Checklist: New Expensify 2024-12-26 #54591

Closed

42 tasks

thelullabyy mentioned this pull request Dec 27, 2024

[HOLD for payment 2025-01-13] [HOLD for payment 2025-01-07] Chat - App crashes when creating group chat offline and returning online on report details RHP #54595

Closed

8 tasks

Beamanator reviewed Dec 30, 2024

View reviewed changes

nkdengineer mentioned this pull request Jan 9, 2025

[Due for payment 2025-02-13] [$250] Track - Nothing happens when clicking on tracking options on unreported expense created on OD #54726

Closed

8 tasks

allgandalf reviewed Feb 19, 2025

View reviewed changes

Conversation

TMisiukiewicz commented Dec 17, 2024

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 17, 2024

Uh oh!

TMisiukiewicz commented Dec 18, 2024

Uh oh!

shubham1206agra Dec 20, 2024

Choose a reason for hiding this comment

Uh oh!

TMisiukiewicz Dec 20, 2024

Choose a reason for hiding this comment

Uh oh!

shubham1206agra commented Dec 20, 2024

Uh oh!

shubham1206agra Dec 20, 2024

Choose a reason for hiding this comment

Uh oh!

TMisiukiewicz Dec 20, 2024

Choose a reason for hiding this comment

Uh oh!

shubham1206agra commented Dec 20, 2024

Uh oh!

shubham1206agra commented Dec 20, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

shubham1206agra left a comment

Choose a reason for hiding this comment

Uh oh!

TMisiukiewicz commented Dec 20, 2024

Uh oh!

puneetlath commented Dec 23, 2024

Uh oh!

TMisiukiewicz commented Dec 24, 2024

Uh oh!

OSBotify commented Dec 24, 2024

Uh oh!

github-actions bot commented Dec 26, 2024

Uh oh!

Beamanator Dec 30, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 31, 2024

Uh oh!

allgandalf Feb 19, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants