[No QA] Add violations to inline submit by luacmartins · Pull Request #54898 · Expensify/App

luacmartins · 2025-01-07T18:53:31Z

Explanation of Change

Adds the missing violation logic to IOU.canSubmitReport and extracts that into a reusable function. I also tried to handle as many of the Do not default string IDs to any value. ESLint errors, but some got quite convoluted and I didn't want to distract too much from the main change, so I left them for a follow up PR.

Fixed Issues

$ #54910

Tests

Create a new workspace and enable Delayed submission
Submit an expense to the workspace
Navigate to the Search page and verify that you see Submit as the action button
Get the hash from the snapshot_ key and the transactionID from Onyx
Manually update update onyx data to add brokenCardConnection violation to transaction violations. Example:

Onyx.merge('snapshot_<hash>', {
  data: {
    transactionViolations_<id>: [{
      type: 'warning',
      name: 'rter',
      data: {rterType: 'brokenCardConnection'},
    }]
  }
});

Verify the action changed to View
Refresh the page
Verify that the Submit action is shown again (since the refresh wiped the manual data we inserted)
Manually update onyx data to add an rter violation

Onyx.merge('snapshot_<has>', {
  data: {
    'transactionViolations_<id>': [{
      type: 'warning',
      name: 'rter',
      data: {rterType: 'sevenDayHold', pendingPattern: true},
    }]
  }
});

Verify that you see the View action

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Regular TCs for Submit functionality

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Screen.Recording.2025-01-07.at.3.24.32.PM.mov

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-01-09T18:23:25Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins · 2025-01-09T18:25:11Z

@hungvu193 this PR is on hold for merge because it's based on the holding PRs branch, but we can start reviewing/testing.

hungvu193 · 2025-01-10T08:03:04Z

Taking a look 👀

hungvu193 · 2025-01-12T05:17:38Z

It's working well. It looks like we have a lot of linings for the default id, are we gonna fix it?

Screen.Recording.2025-01-10.at.16.32.51.mov

Screen.Recording.2025-01-10.at.17.31.47.mov

tests/unit/Search/SearchUIUtilsTest.ts

luacmartins · 2025-01-13T20:15:57Z

It's working well. It looks like we have a lot of linings for the default id, are we gonna fix it?

No, I wasn't planning to fix that as part of this PR since some of them are quite complex and it'd distract from the main point of the PR.

luacmartins · 2025-01-14T16:59:13Z

@hungvu193 updated! I also fixed the ESLint errors. Hopefully I didn't break anything along the way

src/components/ReportActionItem/ReportPreview.tsx

src/components/MoneyReportHeader.tsx

hungvu193 · 2025-01-15T06:47:28Z

Hey @luacmartins What's the best way to make a violation report? 😄

luacmartins · 2025-01-15T14:13:52Z

Hey @luacmartins What's the best way to make a violation report?

You could:

Create a new workspace
Submit an expense without a category selected
In Workspace settings, turn on Require category
The report should now have a Missing category violation on it

hungvu193 · 2025-01-16T02:12:34Z

Nice. I'll take a look today

hungvu193 · 2025-01-16T08:51:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-16.at.16.01.33.mov

Android: mWeb Chrome

Screen.Recording.2025-01-16.at.17.56.46.mov

iOS: Native

Screen.Recording.2025-01-16.at.17.24.03.mov

iOS: mWeb Safari

Screen.Recording.2025-01-16.at.17.54.34.mov

MacOS: Chrome / Safari

Screen.Recording.2025-01-16.at.15.25.46.mov

MacOS: Desktop

Screen.Recording.2025-01-16.at.15.35.26.mov

hungvu193

LGTM

melvin-bot · 2025-01-16T10:58:22Z

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

lakchote

LGTM. Reviewing since I have context on Search, and because Carlos had a lot of conflicts on that one.

OSBotify · 2025-01-16T16:51:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-17T13:54:56Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.0.87-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-01-21T08:08:00Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.87-3 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

shubham1206agra · 2025-01-22T11:28:38Z

src/components/ReportActionItem/ReportPreview.tsx

-        !showRTERViolationMessage &&
-        !shouldShowBrokenConnectionViolation &&
-        (iouReport?.ownerAccountID === currentUserAccountID || isAdmin || iouReport?.managerID === currentUserAccountID);
+    const shouldShowSubmitButton = canSubmitReport(iouReport, policy, transactionIDList, transactionViolations);


@luacmartins Can you help me understand the logic behind using only 1st transaction to check for violations here? Since this will create weird submit behaviour on report preview and report header.

Oh nice catch! This was a bad refactor for the lint rules. We should be using all report transactions. Is it being fixed somewhere else already?

Cool, thanks for handling it!

dry code into canSubmitReport

0231a56

luacmartins self-assigned this Jan 7, 2025

luacmartins added 6 commits January 7, 2025 12:09

update allHavePendingRTERViolation

04f7e09

use new function

f8824eb

add missing param

6e3b3c6

fix lint

a1ddb4e

fix more lint

e4d0f9f

fix ts

16b9706

luacmartins changed the title ~~Add violations to inline submit~~ [HOLD Auth 13663] Add violations to inline submit Jan 7, 2025

luacmartins added 6 commits January 7, 2025 13:01

fix eslint

5adb96f

Merge branch 'main' into cmartins-addInlineSubmit

c57e93a

revent submodule change

3454253

fix ts errors

33d8d7e

Merge branch 'cmartins-showReview' into cmartins-addInlineSubmit

77107ff

use allViolations

8e69675

luacmartins changed the title ~~[HOLD Auth 13663] Add violations to inline submit~~ [HOLD Auth 13663] [No QA] Add violations to inline submit Jan 7, 2025

fix bug

96157cb

luacmartins changed the title ~~[HOLD Auth 13663] [No QA] Add violations to inline submit~~ [HOLD App 54847] [No QA] Add violations to inline submit Jan 9, 2025

luacmartins marked this pull request as ready for review January 9, 2025 18:23

luacmartins requested a review from a team as a code owner January 9, 2025 18:23

melvin-bot bot requested a review from hungvu193 January 9, 2025 18:23

melvin-bot bot removed the request for review from a team January 9, 2025 18:23

hungvu193 reviewed Jan 12, 2025

View reviewed changes

tests/unit/Search/SearchUIUtilsTest.ts Outdated Show resolved Hide resolved

resolve conflicts

2a095f8

fix test

ae0763c

fix lint

1c85d08

luacmartins changed the title ~~[HOLD App 54847] [No QA] Add violations to inline submit~~ [No QA] Add violations to inline submit Jan 14, 2025

luacmartins added 3 commits January 14, 2025 10:47

fix more eslint

90052ba

fix esline in transaction.tsx;

f163a13

fix report header lint

efbb319

luacmartins requested a review from hungvu193 January 14, 2025 16:59

hungvu193 suggested changes Jan 15, 2025

View reviewed changes

src/components/ReportActionItem/ReportPreview.tsx Show resolved Hide resolved

src/components/MoneyReportHeader.tsx Show resolved Hide resolved

luacmartins added 2 commits January 15, 2025 09:10

Merge branch 'main' into cmartins-addInlineSubmit

a999937

add is archived condition

a6cad39

luacmartins requested a review from hungvu193 January 15, 2025 14:16

luacmartins added 2 commits January 15, 2025 15:46

resolve conflicts

0a51fe0

rm new line

ae56589

hungvu193 approved these changes Jan 16, 2025

View reviewed changes

melvin-bot bot requested a review from cristipaval January 16, 2025 10:58

lakchote approved these changes Jan 16, 2025

View reviewed changes

lakchote merged commit a2e0558 into main Jan 16, 2025

lakchote deleted the cmartins-addInlineSubmit branch January 16, 2025 16:43

github-actions bot mentioned this pull request Jan 17, 2025

Deploy Checklist: New Expensify 2025-01-17 #55396

Closed

60 tasks

melvin-bot bot mentioned this pull request Jan 21, 2025

[HOLD for payment 2025-01-28] [Search v1.2] Add violations to inline submit actions #54910

Closed

shubham1206agra reviewed Jan 22, 2025

View reviewed changes

DylanDylann mentioned this pull request Mar 20, 2025

[Due for payment 2025-04-16] Fix submit logic with broken connection violation #57248

Closed

Conversation

luacmartins commented Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 9, 2025

Uh oh!

luacmartins commented Jan 9, 2025

Uh oh!

hungvu193 commented Jan 10, 2025

Uh oh!

hungvu193 commented Jan 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

luacmartins commented Jan 13, 2025

Uh oh!

luacmartins commented Jan 14, 2025

Uh oh!

Uh oh!

Uh oh!

hungvu193 commented Jan 15, 2025

Uh oh!

luacmartins commented Jan 15, 2025

Uh oh!

hungvu193 commented Jan 16, 2025

Uh oh!

hungvu193 commented Jan 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hungvu193 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Jan 16, 2025

Uh oh!

lakchote left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jan 16, 2025

Uh oh!

github-actions bot commented Jan 17, 2025

Uh oh!

github-actions bot commented Jan 21, 2025

Uh oh!

shubham1206agra Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

luacmartins Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

shubham1206agra Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

luacmartins Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

luacmartins commented Jan 7, 2025 •

edited

Loading

hungvu193 commented Jan 12, 2025 •

edited

Loading

hungvu193 commented Jan 16, 2025 •

edited

Loading