fix: $0 doesn't save in the Receipt by nkdengineer · Pull Request #54949 · Expensify/App

nkdengineer · 2025-01-08T10:07:11Z

Explanation of Change

Fixed Issues

$ #54290
PROPOSAL: #54290 (comment)

Tests

Enable Rules under more features in a controlled workspace
Navigate to Rules in LHN
Click Receipt required amount field and enter $0 as amount
Click Save
Verify that: User able to save the amount.

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-mweb.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-mweb.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2025-01-08T15:50:53Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allgandalf · 2025-01-09T05:23:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-09.at.10.59.28.AM.mov

Android: mWeb Chrome

Screen.Recording.2025-01-09.at.10.55.30.AM.mov

iOS: Native

Screen.Recording.2025-01-09.at.11.00.45.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-01-09.at.11.01.18.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-01-09.at.10.53.21.AM.mov

MacOS: Desktop

Screen.Recording.2025-01-09.at.10.56.10.AM.mov

allgandalf · 2025-01-09T05:34:51Z

src/pages/workspace/rules/IndividualExpenseRulesSection.tsx


 function IndividualExpenseRulesSectionSubtitle({policy, translate, styles}: IndividualExpenseRulesSectionSubtitleProps) {
-    const policyID = policy?.id ?? '-1';
+    const policyID = `${policy?.id ?? CONST.DEFAULT_NUMBER_ID}`;


why can't you just do:

Suggested change

const policyID = `${policy?.id ?? CONST.DEFAULT_NUMBER_ID}`;

const policyID = policy?.id;

Am i missing something ? this looks a bit hacky and doesn't explain the requirement

bump @nkdengineer

@allgandalf policyID here is used to pass as a params to the getRoute functions below. We have a similar example here

@nkdengineer can you raise a discussion in open source channel, this is highly disregarded approach i guess

bump @nkdengineer

take a look here once

it contains the same question and the link to the discussion, are we aligned with it in this PR?

thanks @allgandalf, i updated

@allgandalf friendly bump here

missed this comment, sorry

allgandalf · 2025-01-28T08:56:53Z

@nkdengineer this has conflicts

allgandalf · 2025-01-29T07:00:00Z

bump @nkdengineer

nkdengineer · 2025-01-29T15:50:18Z

@allgandalf i fixed

OSBotify · 2025-02-03T23:25:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-02-04T00:57:35Z

🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.0.94-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-02-06T21:56:18Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.94-25 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

github-actions · 2025-02-06T22:38:09Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.94-25 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

nkdengineer added 2 commits January 8, 2025 17:06

fix: /bin/zsh doesn't save in the Receipt

1d1275b

fix lint

be23aa7

nkdengineer marked this pull request as ready for review January 8, 2025 15:50

nkdengineer requested a review from a team as a code owner January 8, 2025 15:50

melvin-bot bot requested review from allgandalf and removed request for a team January 8, 2025 15:50

allgandalf reviewed Jan 9, 2025

View reviewed changes

nkdengineer added 4 commits January 13, 2025 10:21

Merge branch 'main' into fix/54290

115bf02

fix lint

12285a7

Merge branch 'main' into fix/54290

ab59d0d

fix lint

81896db

fix conflict

bd77cb7

allgandalf approved these changes Feb 3, 2025

View reviewed changes

melvin-bot bot requested a review from danieldoglas February 3, 2025 05:41

danieldoglas approved these changes Feb 3, 2025

View reviewed changes

danieldoglas merged commit 21a97d8 into Expensify:main Feb 3, 2025
15 checks passed

github-actions bot mentioned this pull request Feb 4, 2025

Deploy Checklist: New Expensify 2025-02-03 #56280

Closed

95 tasks

melvin-bot bot mentioned this pull request Feb 6, 2025

[Due for payment 2025-02-13] [$250] $0 doesn't save in the Receipt required amount field in Workspaces #54290

Closed

8 tasks

	const policyID = `${policy?.id ?? CONST.DEFAULT_NUMBER_ID}`;
	const policyID = policy?.id;

Conversation

nkdengineer commented Jan 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 8, 2025

Uh oh!

allgandalf commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

allgandalf commented Jan 28, 2025

Uh oh!

allgandalf commented Jan 29, 2025

Uh oh!

nkdengineer commented Jan 29, 2025

Uh oh!

Uh oh!

OSBotify commented Feb 3, 2025

Uh oh!

github-actions bot commented Feb 4, 2025

Uh oh!

github-actions bot commented Feb 6, 2025

Uh oh!

github-actions bot commented Feb 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nkdengineer commented Jan 8, 2025 •

edited

Loading

allgandalf commented Jan 9, 2025 •

edited

Loading