Redesign search to always show search input(mobile + desktop).

[SzymczakJ]

Explanation of Change

This PR is mainly about redesigning Search Page but I also made a pretty big refactor and improved performance of Search Page mobile header animation.
These are the design changes:

1. on SearchPage full screen, the SearchRouterInput is always visible, previously the SearchRouterInput was hidden when we were in "canned search" state.

2. on mobile SearchPage, we remove the button that navigates to SearchRouter
3. instead of that we put SearchRouterInput in place where SearchTypeMenuNarrow was, focusing this input is making SearchRouterList visible.

4. on mobile SearchPage user can still open type menu modal by pressing the button next to SearchRouterInput

These are refactor changes:

1. Refactor of SearchPageBottomTab.tsx so that it has one render for narrow screen and one render for full screen, for better readability.
2. Delete SearchTypeMenuNarrow.tsx and decuple it's logic from SearchTypeMenu.tsx, now this logic lives in SearchTypeMenuPopover.tsx with the common parts of SearchTypeMenuPopover and SearchTypeMenu put into SearchUIUtils.
3. Delete SearchSelectionModeHeader.tsx as it added unnecessary layer that was confusing.

Fixed Issues

$ #52317
$ #55828
PROPOSAL:

Tests

1. On full screen SearchPage make sure that SearchRouterInput displays in every case.
2. Test if clicking on canned searches and saved searches works as expected.
3. Test if writing into SearchRouterInput works as expected.
4. On mobile, test scrolling SearchPage list and SearchRouterList(after focusing SearchRouterInput).
5. Test SearchRouterList, if it works as expected(if clicking on recent searches items works as expected etc.).
6. Test if advanced filters button works as expected.
7. Test if type menu button(next to SearchRouterInput) works as expected and it's possible to go to canned item or saved item.

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[Kicu]

Looks promising 👍 left a bunch of polishing comments

[Kicu]

Suggested change

	}
	}

[melvin-bot]

@rayane-djouah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[SzymczakJ]

Ready for review @rayane-djouah
I would also like to hear opinion from design team and @luacmartins 😄

ios.mov

[shawnborton]

I'll spin up a test build!

[luacmartins]

Removing this fixes the issue because we also render it in line 80 above

Suggested change

shouldRenderTooltip: index === 0 && shouldShowProductTrainingTooltip,

[shawnborton]

Ah yeah, the scroll bar stuff already exists on production, so I'll go ahead and report it in #expense for now.

[SzymczakJ]

Yeah the scroll bug seems strange, I though I fixed it, because it stopped to reproduce on my end.
Great catch @luacmartins! I've applied your fix to the tooltip bug.

[ikevin127]

LGTM - Solid work! 🚀

@luacmartins The PR Reviewer checklist fails because this one still exists - once that's deleted, my completed checklist will pass the checklist test.

[melvin-bot]

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

[luacmartins]

LGTM! Thanks for the hard work here

[luacmartins]

Verify Android HybridApp builds on main is failing because of Error: Input required and not supplied: token which is unrelated to this PR.

[melvin-bot]

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

[luacmartins]

See above comment

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.92-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

[mountiny]

Sorry, noting here too just to make sure - this was reverted as noticeable delay to switch to the Reports page was noticed #56032

[github-actions]

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.92-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅