perf: create report -> transactions map to optimize performance by TMisiukiewicz · Pull Request #55297 · Expensify/App

TMisiukiewicz · 2025-01-15T17:35:52Z

Explanation of Change

This change reduces the getOrderedReportIDs execution time on accounts with a lot of reports and transactions by creating a map of reports and their corresponding transactions instead of filtering transactions on each report. It speeds up the TTI of the app and fixes the issue linked below.

Fixed Issues

$ #54802
PROPOSAL: #54802 (comment)

Tests

Open the app with account with lots of reports and transactions
Open the Workspace list
Verify the workspace list was opened smoothly

Verify that no errors appear in the JS console

Offline tests

n/a

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Open the app with account with lots of reports and transactions
Open the Workspace list
Verify the workspace list was opened smoothly

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2025-01-16T18:47:31Z

@rayane-djouah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

TMisiukiewicz · 2025-01-16T18:48:46Z

@adhorodyski

adhorodyski · 2025-01-16T18:54:57Z

@rayane-djouah this one's ready!

rayane-d · 2025-01-16T20:19:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-22.at.8.48.29.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-01-22.at.8.49.50.PM.mov

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-22.at.20.46.03.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-22.at.20.43.02.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-01-22.at.8.11.42.PM.mov

Screen.Recording.2025-01-22.at.7.51.47.PM.mov

MacOS: Desktop

Screen.Recording.2025-01-22.at.7.29.29.PM.mov

rayane-d · 2025-01-16T20:19:19Z

src/libs/TransactionUtils/index.ts

+    if (transactions) {
+        return Object.values(transactions).filter((transaction): transaction is Transaction => !!transaction && transaction.reportID === reportID);
+    }


Can we optimize this for components when transactions are provided also? can we consider using useOnyx with a selector in components to fetch only the relevant transactions for a specific reportID?

App/src/components/ReportActionItem/ReportPreview.tsx

Line 146 in 5d25d69

const [transactions] = useOnyx(ONYXKEYS.COLLECTION.TRANSACTION);

App/src/components/ReportActionItem/ReportPreview.tsx

Line 160 in 5d25d69

const allTransactions = useMemo(() => getAllReportTransactions(iouReportID, transactions), [iouReportID, transactions]);

App/src/components/MoneyReportHeader.tsx

Line 118 in 5d25d69

const [transactions] = useOnyx(ONYXKEYS.COLLECTION.TRANSACTION);

App/src/pages/ReportDetailsPage.tsx

Line 111 in 5d25d69

const [transactions] = useOnyx(ONYXKEYS.COLLECTION.TRANSACTION);

This will reduce computations when transactions change in Onyx.

Pseudocode:

function transactionsByReportIDSelector(transactions: OnyxCollection<Transaction>, reportID: string): Transaction[] { return Object.values(transactions).filter((transaction): transaction is Transaction => !!transaction && transaction.reportID === reportID); } const [reportTransactions, reportTransactionsMetadata] = useOnyx({ key: ONYXKEYS.COLLECTION.TRANSACTION, selector: (transactions) => transactionsByReportIDSelector(transactions, reportID), });

Thanks @rayane-djouah for bringing this, I think we can do even better 😀 Looks like all this work is redundant because in each scenario we pass in the whole initial list of transactions. This means we're not filtering any subset (2nd parameter), but essentially re-do the same work multiple time.

I've also stumbled upon this PR which introduced the same improvement (but based on Array, not Set). I think we can unify all usages of getAllReportTransactions to just getReportTransactions that is there in ReportUtils (instead of TransactionUtils). Implementation with the 2nd parameter is not being used anywhere correctly.

You're also right about moving to useOnyx wherever possible! I'll update the PR today and test this on my end.

…eport utils

adhorodyski · 2025-01-17T16:50:27Z

src/components/MoneyReportHeader.tsx

-    const hasOnlyPendingTransactions = allTransactions.length > 0 && allTransactions.every((t) => TransactionUtils.isExpensifyCardTransaction(t) && TransactionUtils.isPending(t));
-    const transactionIDs = allTransactions.map((t) => t.transactionID);
+    const hasOnlyPendingTransactions =
+        transactions?.some((t) => {


@rayane-djouah we have to triple check if this is logically the same as before - should now bail out earlier though because of the some() loop whenever possible.

adhorodyski · 2025-01-17T16:53:39Z

I have refactored this one to rely on an existing map in ReportUtils - I'll need to run additional tests to make sure it's no slower than the one constructed initially with a new Set() by @TMisiukiewicz. We can make this implementation faster at any time.

adhorodyski · 2025-01-17T17:03:29Z

@rayane-djouah we'll get conflicts resolved on Monday morning & ensure it still works as good as initially (given the amount of updates I had to push). I'll let you know once it's done!

…nsactions

TMisiukiewicz · 2025-01-20T09:08:16Z

resolved conficts ✅

TMisiukiewicz · 2025-01-20T11:59:58Z

also fixed the lint-changed failing job

rayane-d · 2025-01-21T01:57:32Z

src/components/MoneyReportHeader.tsx

+    const hasOnlyPendingTransactions = useMemo(() => {
+        return !transactions?.some((t) => {
+            const isTransactionPending = isExpensifyCardTransaction(t) && isPending(t);
+            return !isTransactionPending;
+        });
+    }, [transactions]);


Both .some() and .every() short-circuit: .some() stops at the first truthy value, and .every() stops at the first falsy value. There's no performance difference between them, as both will exit after checking the same number of elements for the same dataset.

Let's use .every() for better readability:

Suggested change

const hasOnlyPendingTransactions = useMemo(() => {

return !transactions?.some((t) => {

const isTransactionPending = isExpensifyCardTransaction(t) && isPending(t);

return !isTransactionPending;

});

}, [transactions]);

const hasOnlyPendingTransactions = useMemo(() => {

return transactions?.every((t) => isExpensifyCardTransaction(t) && isPending(t));

}, [transactions]);

ah you're right @rayane-djouah, totally forgot about that! Thanks for catching it.

…nsactions

rayane-d · 2025-01-22T15:03:59Z

src/components/MoneyReportHeader.tsx

-    const hasOnlyPendingTransactions = allTransactions.length > 0 && allTransactions.every((t) => isExpensifyCardTransaction(t) && isPending(t));
-    const transactionIDs = allTransactions.map((t) => t.transactionID) ?? [];
+    const hasOnlyPendingTransactions = useMemo(() => {
+        return transactions?.every((t) => isExpensifyCardTransaction(t) && isPending(t));


Suggested change

return transactions?.every((t) => isExpensifyCardTransaction(t) && isPending(t));

return transactions?.every((t) => isExpensifyCardTransaction(t) && isPending(t)) ?? false;

rayane-d · 2025-01-22T15:05:41Z

src/components/MoneyReportHeader.tsx

    const isAnyTransactionOnHold = hasHeldExpensesReportUtils(moneyRequestReport?.reportID);
    const displayedAmount = isAnyTransactionOnHold && canAllowSettlement && hasValidNonHeldAmount ? nonHeldAmount : formattedAmount;
-    const isMoreContentShown = shouldShowNextStep || shouldShowStatusBar || (shouldShowAnyButton && shouldUseNarrowLayout);
+    const isMoreContentShown = shouldShowNextStep ?? shouldShowStatusBar ?? (shouldShowAnyButton && shouldUseNarrowLayout);


Suggested change

const isMoreContentShown = shouldShowNextStep ?? shouldShowStatusBar ?? (shouldShowAnyButton && shouldUseNarrowLayout);

const isMoreContentShown = shouldShowNextStep || shouldShowStatusBar || (shouldShowAnyButton && shouldUseNarrowLayout);

rayane-d · 2025-01-22T15:38:47Z

src/components/MoneyReportHeader.tsx

-    const hasOnlyPendingTransactions = allTransactions.length > 0 && allTransactions.every((t) => isExpensifyCardTransaction(t) && isPending(t));
-    const transactionIDs = allTransactions.map((t) => t.transactionID) ?? [];
+    const hasOnlyPendingTransactions = useMemo(() => {
+        return transactions?.every((t) => isExpensifyCardTransaction(t) && isPending(t)) ?? false;


.every return true for empty array, we need to check the length before

Suggested change

return transactions?.every((t) => isExpensifyCardTransaction(t) && isPending(t)) ?? false;

return !!transactions && transactions.length > 0 && transactions.every((t) => isExpensifyCardTransaction(t) && isPending(t));

rayane-d

LGTM and tests well

rayane-d · 2025-01-22T19:52:39Z

@carlosmiceli all yours!

OSBotify · 2025-01-22T23:18:13Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-23T18:28:14Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.0.89-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

…-map-transactions" This reverts commit 523edfe, reversing changes made to 4a0d4e6.

github-actions · 2025-01-28T01:51:39Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.89-8 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

create report-transactions map to improve performance

cc54548

TMisiukiewicz mentioned this pull request Jan 15, 2025

[HOLD for payment 2025-02-04] Frequent Client Hanging and Loss of Workspace List #54802

Closed

8 tasks

TMisiukiewicz marked this pull request as ready for review January 16, 2025 18:47

TMisiukiewicz requested a review from a team as a code owner January 16, 2025 18:47

melvin-bot bot requested review from rayane-d and removed request for a team January 16, 2025 18:47

tgolen mentioned this pull request Jan 16, 2025

Remove the getTripTransactions method #55264

Merged

48 tasks

rayane-d suggested changes Jan 16, 2025

View reviewed changes

chore: refactor to rely on existing map of report transactions from r…

cf9b7e4

…eport utils

adhorodyski reviewed Jan 17, 2025

View reviewed changes

chore: wrap hasOnlyPendingTransactions in a useMemo

a861593

fix: money report header errors

3097d47

Merge remote-tracking branch 'upstream/main' into perf/create-map-tra…

cc5e0f0

…nsactions

TMisiukiewicz requested a review from rayane-d January 20, 2025 09:08

TMisiukiewicz added 3 commits January 20, 2025 12:33

fix lint-changed

54077fe

fix typecheck

2c82b01

fix tests

784e0e9

fix lint changed

9effd36

rayane-d suggested changes Jan 21, 2025

View reviewed changes

TMisiukiewicz added 2 commits January 21, 2025 08:49

Merge remote-tracking branch 'upstream/main' into perf/create-map-tra…

9f7ca1d

…nsactions

use every instead of some

ae77d7e

TMisiukiewicz requested a review from rayane-d January 21, 2025 07:53

fix linter

8fc0d31

TMisiukiewicz mentioned this pull request Jan 21, 2025

[HOLD for payment 2025-02-04] Extreme slowdowns on staging desktop Chrome and multi-second delay when switching chats #55173

Closed

8 tasks

rayane-d suggested changes Jan 22, 2025

View reviewed changes

TMisiukiewicz added 2 commits January 22, 2025 16:09

merge main

54dab76

code review updates

1c30c60

TMisiukiewicz requested a review from rayane-d January 22, 2025 15:11

rayane-d suggested changes Jan 22, 2025

View reviewed changes

check transactions length

596e731

TMisiukiewicz requested a review from rayane-d January 22, 2025 15:43

rayane-d approved these changes Jan 22, 2025

View reviewed changes

melvin-bot bot requested a review from carlosmiceli January 22, 2025 19:50

carlosmiceli approved these changes Jan 22, 2025

View reviewed changes

carlosmiceli merged commit 523edfe into Expensify:main Jan 22, 2025

adhorodyski deleted the perf/create-map-transactions branch January 23, 2025 11:23

github-actions bot mentioned this pull request Jan 23, 2025

Deploy Checklist: New Expensify 2025-01-23 #55657

Closed

neil-marcellini mentioned this pull request Jan 23, 2025

[HOLD for payment 2025-02-05] [HOLD for payment 2025-02-04] [$250] Report - Chat is partially scrolled down when returning from expense thread #55660

Closed

8 tasks

neil-marcellini added a commit that referenced this pull request Jan 23, 2025

Revert "Merge pull request #55297 from callstack-internal/perf/create…

25d1c95

…-map-transactions" This reverts commit 523edfe, reversing changes made to 4a0d4e6.

neil-marcellini mentioned this pull request Jan 23, 2025

Revert perf: create report -> transactions map to optimize performance #55669

Closed

50 tasks

TMisiukiewicz mentioned this pull request Mar 19, 2025

[$250][HIGH] Android - workspace-On tapping "Go to workspace" a delayed response is shown #55565

Closed

8 tasks

	return transactions?.every((t) => isExpensifyCardTransaction(t) && isPending(t));
	return transactions?.every((t) => isExpensifyCardTransaction(t) && isPending(t)) ?? false;

	const isMoreContentShown = shouldShowNextStep ?? shouldShowStatusBar ?? (shouldShowAnyButton && shouldUseNarrowLayout);
	const isMoreContentShown = shouldShowNextStep \|\| shouldShowStatusBar \|\| (shouldShowAnyButton && shouldUseNarrowLayout);

	return transactions?.every((t) => isExpensifyCardTransaction(t) && isPending(t)) ?? false;
	return !!transactions && transactions.length > 0 && transactions.every((t) => isExpensifyCardTransaction(t) && isPending(t));

Conversation

TMisiukiewicz commented Jan 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 16, 2025

Uh oh!

TMisiukiewicz commented Jan 16, 2025

Uh oh!

adhorodyski commented Jan 16, 2025

Uh oh!

rayane-d commented Jan 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

rayane-d Jan 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adhorodyski Jan 17, 2025

Choose a reason for hiding this comment

Uh oh!

adhorodyski Jan 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adhorodyski commented Jan 17, 2025

Uh oh!

adhorodyski commented Jan 17, 2025

Uh oh!

TMisiukiewicz commented Jan 20, 2025

Uh oh!

TMisiukiewicz commented Jan 20, 2025

Uh oh!

rayane-d Jan 21, 2025

Choose a reason for hiding this comment

Uh oh!

TMisiukiewicz Jan 21, 2025

Choose a reason for hiding this comment

Uh oh!

adhorodyski Jan 21, 2025

Choose a reason for hiding this comment

Uh oh!

rayane-d Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

rayane-d Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

rayane-d Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

rayane-d left a comment

Choose a reason for hiding this comment

Uh oh!

rayane-d commented Jan 22, 2025

Uh oh!

OSBotify commented Jan 22, 2025

Uh oh!

github-actions bot commented Jan 23, 2025

Uh oh!

github-actions bot commented Jan 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

TMisiukiewicz commented Jan 15, 2025 •

edited

Loading

rayane-d commented Jan 16, 2025 •

edited

Loading

rayane-d Jan 16, 2025 •

edited

Loading

adhorodyski Jan 17, 2025 •

edited

Loading