Fix wrong default number id usages by VickyStash · Pull Request #55535 · Expensify/App

VickyStash · 2025-01-21T15:04:32Z

Explanation of Change

Remove wrongly used defaulting value CONST.DEFAULT_NUMBER_ID in cases, when it was used inside a string.

Fixed Issues

$ #50360
$ #55814
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Part 1: Expenses related

Open the app.
Click FAB -> go through the Create Expense flow.
Open 1-1 chat -> go through the Create Expense flow.
Open SelfDM chat -> go through the Create Expense flow.
Open workspace chat -> go through the Create Expense flow.
Click FAB -> go through the Quick Action flow.

Part 2: Chats related

Go offline.
Open FAB > Start chat.
Create a group chat with any user.
Click on the group chat header.
Go online.
Open FAB > Start chat.
Select Room tab.
Fill the necessary data and then press Create room below.

Offline tests

Same, as in the Tests section.

QA Steps

Verify that no errors appear in the JS console

Same, as in the Tests section.

PR Author Checklist

Screenshots/Videos

Android: Native

android1.mp4

Android: mWeb Chrome

android_web1.mp4

iOS: Native

ios1.mp4

iOS: mWeb Safari

ios_web1.mp4

MacOS: Chrome / Safari

web1.mp4

MacOS: Desktop

desktop1.mp4

…efault-number-id-usage # Conflicts: # src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx # src/pages/iou/request/step/IOURequestStepParticipants.tsx

VickyStash · 2025-01-27T13:23:55Z

src/pages/ReportDetailsPage.tsx

    const styles = useThemeStyles();
    const backTo = route.params.backTo;

-    // The app would crash due to subscribing to the entire report collection if parentReportID is an empty string. So we should have a fallback ID here.


Not crashing anymore after removing default '' parentReportID value during optimistic chat creation

…efault-number-id-usage # Conflicts: # src/components/ReportActionItem/MoneyRequestAction.tsx # src/libs/actions/Report.ts # src/pages/home/report/ReportActionItemContentCreated.tsx # src/pages/workspace/AccessOrNotFoundWrapper.tsx

melvin-bot · 2025-01-28T12:22:41Z

@paultsimura Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…efault-number-id-usage

VickyStash · 2025-01-29T08:38:28Z

The Verify HybridApp build checks are failing with Error: Input required and not supplied: token.
So it looks like the token is missed, I don't think it's related to current PR.
@AndrewGable do you have any thoughts? Since you were working on implementation of these checks.

fabioh8010 · 2025-01-29T10:51:09Z

src/pages/workspace/WorkspaceNewRoomPage.tsx

-        const participants = [session?.accountID ?? -1];
-        const parsedDescription = ReportUtils.getParsedComment(values.reportDescription ?? '', {policyID});
-        const policyReport = ReportUtils.buildOptimisticChatReport(
+        const participants = session?.accountID ? [session.accountID] : [];


Suggested change

const participants = session?.accountID ? [session.accountID] : [];

const participants = [session?.accountID ?? CONST.DEFAULT_NUMBER_ID];

NAB: we are allowed to default to number id here, but I think your way makes more sense

AndrewGable · 2025-01-29T19:27:12Z

Thanks for the ping, looking into the failures now. No need to block on it passing.

paultsimura · 2025-01-29T22:03:22Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-01-29.at.23.00.34.mov

MacOS: Desktop

paultsimura

LGTM ✔️

thienlnam

Time to get rid of the default IDs 🚀

melvin-bot · 2025-01-30T19:47:24Z

@thienlnam looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

thienlnam · 2025-01-30T19:47:37Z

#55535 (comment)

VickyStash added 3 commits January 21, 2025 14:34

Remove wrong default number id usage pt1

66bd902

Remove wrong default number id usage pt2

e06ad3f

Fix lint errors

9452d40

VickyStash added 5 commits January 27, 2025 09:24

Merge branch 'refs/heads/main' into VickyStash/refactor/50360-wrong-d…

8f0985f

…efault-number-id-usage # Conflicts: # src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx # src/pages/iou/request/step/IOURequestStepParticipants.tsx

Remove wrong default number id usage pt3

2e0c7aa

Remove wrong default number id usage pt4

7683dfe

Remove wrong default number id usage pt5

f2e7385

Lint fixes

0e1727e

VickyStash commented Jan 27, 2025

View reviewed changes

VickyStash added 2 commits January 27, 2025 15:28

Minor improvement

3d06687

Fix group chat creation

b014cfb

fabioh8010 mentioned this pull request Jan 28, 2025

Add CONST.DEFAULT_NUMBER_ID case to no-default-id-values ESLint rule #55814

Closed

VickyStash added 3 commits January 28, 2025 11:41

Remove wrong default ids in SplitBillDetailsPage

7d50b32

Minor code improvement

17eee00

VickyStash changed the title ~~[WIP] Fix wrong default number id usages~~ Fix wrong default number id usages Jan 28, 2025

VickyStash marked this pull request as ready for review January 28, 2025 12:22

VickyStash requested a review from a team as a code owner January 28, 2025 12:22

melvin-bot bot requested review from paultsimura and removed request for a team January 28, 2025 12:22

VickyStash added 2 commits January 29, 2025 09:02

Bump eslint-config-expensify version to 2.0.76

5a9964a

Merge branch 'refs/heads/main' into VickyStash/refactor/50360-wrong-d…

fa465a4

…efault-number-id-usage

fabioh8010 approved these changes Jan 29, 2025

View reviewed changes

neil-marcellini mentioned this pull request Jan 29, 2025

Bump Onyx to 2.0.91 / Enable skippable collection member IDs in Onyx #54163

Merged

50 tasks

This comment was marked as resolved.

Sign in to view

paultsimura approved these changes Jan 30, 2025

View reviewed changes

melvin-bot bot requested a review from thienlnam January 30, 2025 08:37

thienlnam approved these changes Jan 30, 2025

View reviewed changes

thienlnam merged commit 8e1aad2 into Expensify:main Jan 30, 2025
17 of 20 checks passed

melvin-bot bot added the Emergency label Jan 30, 2025

thienlnam removed the Emergency label Jan 30, 2025

This was referenced Jan 30, 2025

Investigate workflow job failing on main: test / test (job 3) #56111

Closed

Investigate workflow job failing on main: confirmPassingBuild #56112

Closed

neil-marcellini mentioned this pull request Feb 4, 2025

Bump Onyx to 2.0.92 #56166

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix wrong default number id usages#55535

Fix wrong default number id usages#55535
thienlnam merged 15 commits intoExpensify:mainfrom
callstack-internal:VickyStash/refactor/50360-wrong-default-number-id-usage

VickyStash commented Jan 21, 2025 •

edited by thienlnam

Loading

Uh oh!

VickyStash Jan 27, 2025 •

edited

Loading

Uh oh!

melvin-bot bot commented Jan 28, 2025

Uh oh!

VickyStash commented Jan 29, 2025

Uh oh!

fabioh8010 Jan 29, 2025

Uh oh!

AndrewGable commented Jan 29, 2025

Uh oh!

paultsimura commented Jan 29, 2025

Uh oh!

This comment was marked as resolved.

paultsimura left a comment

Uh oh!

thienlnam left a comment

Uh oh!

Uh oh!

melvin-bot bot commented Jan 30, 2025

Uh oh!

thienlnam commented Jan 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	const participants = session?.accountID ? [session.accountID] : [];
	const participants = [session?.accountID ?? CONST.DEFAULT_NUMBER_ID];

Conversation

VickyStash commented Jan 21, 2025 • edited by thienlnam Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

VickyStash Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Jan 28, 2025

Uh oh!

VickyStash commented Jan 29, 2025

Uh oh!

fabioh8010 Jan 29, 2025

Choose a reason for hiding this comment

Uh oh!

AndrewGable commented Jan 29, 2025

Uh oh!

paultsimura commented Jan 29, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

This comment was marked as resolved.

paultsimura left a comment

Choose a reason for hiding this comment

Uh oh!

thienlnam left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

melvin-bot bot commented Jan 30, 2025

Uh oh!

thienlnam commented Jan 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

VickyStash commented Jan 21, 2025 •

edited by thienlnam

Loading

VickyStash Jan 27, 2025 •

edited

Loading