Conversation
|
@paultsimura @neil-marcellini One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
This PR was previously reverted because of this flaky test (#56057), just FYI in case it happens again as it isn't related to my PR. |
|
@allgandalf for review again I guess? |
|
We can merge with those checks failing as noted on the previous PR. I think we can also skip the C+ testing because it was done on the last PR. |
|
@neil-marcellini looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.0.95-0 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.95-6 🚀
|
Explanation of Change
This PR bumps Onyx to 2.0.92, including all these changes (diff):
Expensify/react-native-onyx#612 and Expensify/react-native-onyx#613 are going to be used here. Expensify/react-native-onyx#604 is going to be used in this PR.
Fixed Issues
$ #50360
PROPOSAL:
Tests
General tests in E/App:
Offline tests
Same as Tests.
QA Steps
Same as Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android is working but I'm several local problems while trying to run the app again to record the videos.
Android: mWeb Chrome
Screen.Recording.2025-02-03.at.11.11.18-compressed.mov
iOS: Native
Screen.Recording.2025-02-03.at.13.04.45-compressed.mov
iOS: mWeb Safari
Screen.Recording.2025-02-03.at.13.11.04-compressed.mov
MacOS: Chrome / Safari
Screen.Recording.2025-02-03.at.13.50.16-compressed.mov
Screen.Recording.2025-02-03.at.13.51.39-compressed.mov
MacOS: Desktop
Screen.Recording.2025-02-03.at.13.56.28-compressed.mov