Skippable Collection Member IDs#604
Merged
marcochavezf merged 15 commits intoExpensify:mainfrom Jan 23, 2025
Merged
Conversation
…lection-member-ids
VickyStash
reviewed
Dec 17, 2024
Contributor
Author
|
Updates:
|
Contributor
Author
|
I've just profiled the Onyx changes -- no significant changes in performance ✅ Profilingmain Onyx branchStartup / Open Big Report
Switch to Big Report
Send Message
Create Expense Flow
skippable member IDs Onyx branchOpen Big Report
Switch to Big Report
Send Message
Create Expense Flow
Reassure
Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
Changes To CountThere are no entries Added ScenariosThere are no entries Removed ScenariosThere are no entries |
Contributor
Author
|
PR opened to review! |
VickyStash
reviewed
Jan 17, 2025
VickyStash
approved these changes
Jan 17, 2025
|
Testing in app |
Contributor
50 tasks
50 tasks
50 tasks
53 tasks
42 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR introduces a new configuration to
Onyx.init()– the option to specify skippable collection member IDs. It will be possible to pass an array of collection member IDs (strings) which updates will be ignored when using Onyx methods. Additionally, any subscribers from these keys to won't receive any data from Onyx.Example:
Related Issues
Expensify/App#50360
Automated Tests
Unit tests were created to cover the changes.
Manual Tests
General tests in E/App:
Author Checklist
### Related Issuessection aboveTestssectiontoggleReportand notonIconClick)myBool && <MyComponent />.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)Avataris modified, I verified thatAvataris working as expected in all cases)mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-01-16.at.17.44.45-compressed.mov
Android: mWeb Chrome
Screen.Recording.2025-01-16.at.17.49.30-compressed.mov
iOS: Native
Screen.Recording.2025-01-16.at.18.17.09-compressed.mov
iOS: mWeb Safari
Screen.Recording.2025-01-16.at.18.19.00-compressed.mov
MacOS: Chrome / Safari
Screen.Recording.2025-01-16.at.18.22.10-compressed.mov
Screen.Recording.2025-01-16.at.18.23.35-compressed.mov
MacOS: Desktop
Screen.Recording.2025-01-16.at.18.27.06-compressed.mov