feat: skip participant step in create flow by nkdengineer · Pull Request #56090 · Expensify/App

nkdengineer · 2025-01-30T16:27:50Z

Explanation of Change

feat: skip participant step in create flow

Fixed Issues

$ #55717
PROPOSAL: #55717 (comment)

Tests

Precondition: The account has the default workspace is a group workspace

From global FAB > Create expense
For each flow Manual/Scan/Distance
Verify that the default workspace is auto-assigned as participant after we pass the first step
Click on To section verify that we go to the participant page
From the workspace chat, click on Plus icon > Create expense
Enter the amount
In the confirmation step, click on To section
Verify that nothing happens because we cannot change the participant in this case

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Precondition: The account has the default workspace is a group workspace

From global FAB > Create expense
For each flow Manual/Scan/Distance
Verify that the default workspace is auto-assigned as participant after we pass the first step
Click on To section verify that we go to the participant page
From the workspace chat, click on Plus icon > Create expense
Enter the amount
In the confirmation step, click on To section
Verify that nothing happens because we cannot change the participant in this case

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-30.at.23.07.08.mov

Android: mWeb Chrome

Screen.Recording.2025-01-30.at.23.01.16.mov

iOS: Native

Screen.Recording.2025-01-30.at.23.20.26.mov

iOS: mWeb Safari

Screen.Recording.2025-01-30.at.23.03.06.mov

MacOS: Chrome / Safari

Screen.Recording.2025-01-30.at.22.59.37.mov

MacOS: Desktop

Screen.Recording.2025-01-30.at.23.23.07.mov

melvin-bot · 2025-01-30T16:45:05Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

trjExpensify · 2025-01-30T22:54:48Z

👋 @mollfpr are you going to be able to review this (your) today!?

github-actions · 2025-01-30T22:55:09Z

🚧 @trjExpensify has triggered a test build. You can view the workflow run here.

mollfpr · 2025-01-31T00:00:04Z

@trjExpensify Yup!

trjExpensify · 2025-01-31T00:58:51Z

@nkdengineer you're missing the right caret:

mollfpr

The test looks good, except the missing caret icon on the participant select. Also, I leave comments for clarification.

src/pages/iou/request/step/IOURequestStepAmount.tsx

src/pages/iou/request/step/IOURequestStepScan/index.tsx

nkdengineer · 2025-02-03T04:54:54Z

@mollfpr Updated with right icon. Please help to check again.

src/components/MoneyRequestConfirmationList.tsx

src/pages/iou/request/step/IOURequestStepScan/index.tsx

nkdengineer · 2025-02-06T09:51:14Z

@mollfpr I updated, please help to check again.

shawnborton · 2025-02-06T17:05:24Z

Will run a test build on this one too.

github-actions · 2025-02-06T17:05:42Z

🚧 @shawnborton has triggered a test build. You can view the workflow run here.

mollfpr

The changes look good! @nkdengineer Could you resolve the issue on lint and test unit? Thanks!

github-actions · 2025-02-06T19:37:15Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/56090/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/56090/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/56090/NewExpensify.dmg	https://56090.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

dubielzyk-expensify · 2025-02-06T23:13:12Z

Other than what Shawn is mentioning it's feeling pretty great to me too 👍

trjExpensify · 2025-02-07T01:16:38Z

I don't think we want this for Invoices, otherwise you kinda end up sending the Invoice to yourself right?

Agreed, this was only intended for the Create expense flow not the `Send invoice flow. 👍

nkdengineer · 2025-02-07T07:28:13Z

Agreed, this was only intended for the Create expense flow not the `Send invoice flow. 👍

I fixed this bug.

nkdengineer · 2025-02-07T07:29:02Z

The changes look good! @nkdengineer Could you resolve the issue on lint and test unit? Thanks!

@mollfpr Fixed.

mollfpr · 2025-02-10T16:45:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

56090.Android.mp4

Android: mWeb Chrome

56090.mWeb-Chrome.mp4

iOS: Native

56090.iOS.mov

iOS: mWeb Safari

56090.mWeb-Safari.mov

MacOS: Chrome / Safari

56090.Web.mp4

MacOS: Desktop

56090.Desktop.mp4

mollfpr

LGTM 👍

Suggestion for the test case, we should add a step where the participant can be click or not.

nkdengineer · 2025-02-10T17:58:09Z

Suggestion for the test case, we should add a step where the participant can be click or not.
Updated the test step.

yuwenmemon · 2025-02-10T20:12:06Z

LGTM! - Thanks for updating the test cases

OSBotify · 2025-02-10T20:21:51Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-02-11T02:38:38Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.96-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

izarutskaya · 2025-02-11T10:03:36Z

@nkdengineer PR is failing with #56630 on Android and iOS only

https://platform.applause.com/services/links/v1/external/08eec415b8ef9879f5cb6152b268c1cd32a8cd9c056f8b3593a4787b1971989b

nkdengineer · 2025-02-11T10:07:33Z

Created a follow up PR.

Julesssss · 2025-02-11T17:04:46Z

Hi @nkdengineer it looks like these changes caused multiple regressions blocking deploy, did you list these fixed issues yourself? I don't see any triage from the assigned engineers pointing to this PR, so wanted to check what happened here.

Julesssss · 2025-02-11T22:01:33Z

Follow-up PR was CP'd here and QA is underway on staging for the related issues.

github-actions · 2025-02-12T01:44:09Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.96-1 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

shubham1206agra · 2025-03-11T12:24:28Z

src/pages/iou/request/step/IOURequestStepAmount.tsx

        // If there was no reportID, then that means the user started this flow from the global + menu
        // and an optimistic reportID was generated. In that case, the next step is to select the participants for this expense.
-        navigateToParticipantPage();
+        if (iouType === CONST.IOU.TYPE.CREATE && isPaidGroupPolicy(activePolicy) && activePolicy?.isPolicyExpenseChatEnabled) {


You forgot to block users when they have expired WS. See #56829

rushatgabhane · 2025-03-26T12:19:35Z

This PR introduced a race condition that caused a critical bug

[Due for payment 2025-03-25] [Due for payment 2025-03-24] [$1000][CRITICAL] Unable to create an expense by receipt scanning #57554 (comment)

shubham1206agra · 2025-04-18T11:20:48Z

src/pages/iou/request/step/IOURequestStepScan/index.tsx

            // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
            if ((transaction?.isFromGlobalCreate && iouType !== CONST.IOU.TYPE.TRACK && !report?.reportID) || iouType === CONST.IOU.TYPE.CREATE) {
-                navigateToParticipantPage();
+                if (isPaidGroupPolicy(activePolicy)) {


You forgot to check for isPolicyExpenseChatEnabled here, which caused #57115

feat: skip participant step in the create flow

805d38c

nkdengineer force-pushed the fix/55717 branch from 6676596 to 805d38c Compare January 30, 2025 16:28

fix lint

4473b2d

nkdengineer marked this pull request as ready for review January 30, 2025 16:45

nkdengineer requested a review from a team as a code owner January 30, 2025 16:45

melvin-bot bot requested a review from mollfpr January 30, 2025 16:45

melvin-bot bot removed the request for review from a team January 30, 2025 16:45

trjExpensify added the Ready To Build label Jan 30, 2025

trjExpensify assigned nkdengineer Jan 30, 2025

This comment has been minimized.

Sign in to view

mollfpr reviewed Jan 31, 2025

View reviewed changes

src/pages/iou/request/step/IOURequestStepAmount.tsx Show resolved Hide resolved

src/pages/iou/request/step/IOURequestStepScan/index.tsx Show resolved Hide resolved

nkdengineer added 3 commits February 3, 2025 10:38

Merge branch 'main' into fix/55717

5d5779d

add right icon

9cefca8

remove unnecessary condition

e8362fe

mollfpr reviewed Feb 3, 2025

View reviewed changes

src/components/MoneyRequestConfirmationList.tsx Show resolved Hide resolved

src/pages/iou/request/step/IOURequestStepScan/index.tsx Show resolved Hide resolved

nkdengineer added 4 commits February 4, 2025 10:33

Merge branch 'main' into fix/55717

9e3a994

remove unchange

75a3fa5

Merge branch 'main' into fix/55717

95378a4

fix navigate logic of To section

d99cf55

mollfpr reviewed Feb 6, 2025

View reviewed changes

nkdengineer added 3 commits February 7, 2025 14:08

Merge branch 'main' into fix/55717

d11a361

remove setHover

52b5cdb

prevent auto assign for send invoice

43cab68

mollfpr approved these changes Feb 10, 2025

View reviewed changes

melvin-bot bot requested a review from yuwenmemon February 10, 2025 17:04

Merge branch 'main' into fix/55717

17be045

yuwenmemon approved these changes Feb 10, 2025

View reviewed changes

yuwenmemon merged commit 3ad9461 into Expensify:main Feb 10, 2025
18 checks passed

github-actions bot mentioned this pull request Feb 11, 2025

Deploy Checklist: New Expensify 2025-02-11 #56625

Closed

69 tasks

nkdengineer mentioned this pull request Feb 11, 2025

fix create expense flow regression #56638

Merged

50 tasks

melvin-bot bot mentioned this pull request Feb 12, 2025

[Due for payment 2025-02-19] [$250] Pre-select a participant in the Create expense flow #55717

Closed

8 tasks

shubham1206agra reviewed Mar 11, 2025

View reviewed changes

shubham1206agra mentioned this pull request Mar 12, 2025

[Due for payment 2025-03-25] [Due for payment 2025-03-24] [$1000][CRITICAL] Unable to create an expense by receipt scanning #57554

Closed

8 tasks

shubham1206agra mentioned this pull request Mar 25, 2025

Prevent going to confirmation page when active policy has no expense chat #58691

Merged

49 tasks

shubham1206agra reviewed Apr 18, 2025

View reviewed changes

Conversation

nkdengineer commented Jan 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 30, 2025

Uh oh!

trjExpensify commented Jan 30, 2025

Uh oh!

github-actions bot commented Jan 30, 2025

Uh oh!

This comment has been minimized.

mollfpr commented Jan 31, 2025

Uh oh!

trjExpensify commented Jan 31, 2025

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nkdengineer commented Feb 3, 2025

Uh oh!

Uh oh!

Uh oh!

nkdengineer commented Feb 6, 2025

Uh oh!

shawnborton commented Feb 6, 2025

Uh oh!

github-actions bot commented Feb 6, 2025

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 6, 2025

Uh oh!

dubielzyk-expensify commented Feb 6, 2025

Uh oh!

trjExpensify commented Feb 7, 2025

Uh oh!

nkdengineer commented Feb 7, 2025

Uh oh!

nkdengineer commented Feb 7, 2025

Uh oh!

mollfpr commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

nkdengineer commented Feb 10, 2025

Uh oh!

yuwenmemon commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

OSBotify commented Feb 10, 2025

Uh oh!

github-actions bot commented Feb 11, 2025

Uh oh!

izarutskaya commented Feb 11, 2025

Uh oh!

nkdengineer commented Feb 11, 2025

Uh oh!

Julesssss commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Julesssss commented Feb 11, 2025

Uh oh!

github-actions bot commented Feb 12, 2025

Uh oh!

shubham1206agra Mar 11, 2025

nkdengineer commented Jan 30, 2025 •

edited

Loading

mollfpr commented Feb 10, 2025 •

edited

Loading

yuwenmemon commented Feb 10, 2025 •

edited

Loading

Julesssss commented Feb 11, 2025 •

edited

Loading