fix create expense flow regression by nkdengineer · Pull Request #56638 · Expensify/App

nkdengineer · 2025-02-11T07:20:37Z

Explanation of Change

This PR fixes the related bug from this PR

Fixed Issues

$ #56630
#56631
#56633
#56634
#56640
#56662

PROPOSAL:

Tests

Precondition: The user has a group default workspace

[Due for payment 2025-02-19] [Due for payment 2025-02-19] [$250] Expense - Expense is submitted to the workspace chat when 1:1 DM is the destination #56630

Open FAB > Submit expense > Manual.
Enter amount > Next.
On confirmation page, click on the destination field.
Select a user (not workspace) with no chat history.
Submit the expense to the user.
Verify that the expense is submitted to the user instead of the workspace

Distance -Rate is not selected and error when submitting distance expense to default workspace #56631

Open FAB > Submit expense > Distance.
Enter waypoints > Next.
Click Rate field.
Note that the default rate is auto-selected.
Click RHP back button.
Click Create expense.
Verify that the expense is created without error

Split - Members on the confirmation page show hover effect but not clickable #56633

Open the workspace chat or group chat
Click + > Split expense > Manual
Enter any amount and go to the next step
On confirmation page, verify that the participant has no hover effect and can't be clickable

Per diem - User can select 1:1 DM or workspace with no per diem rate as destination #56634

Open FAB > Submit expense > Per diem.
Fill in the information and reach confirmation page.
Verify that the To field has no hover effect and can't be clickable

Verify that no errors appear in the JS console

Offline tests

Same

QA Steps

[Due for payment 2025-02-19] [Due for payment 2025-02-19] [$250] Expense - Expense is submitted to the workspace chat when 1:1 DM is the destination #56630

Open FAB > Submit expense > Manual.
Enter amount > Next.
On confirmation page, click on the destination field.
Select a user (not workspace) with no chat history.
Submit the expense to the user.
Verify that the expense is submitted to the user instead of the workspace

Distance -Rate is not selected and error when submitting distance expense to default workspace #56631

Open FAB > Submit expense > Distance.
Enter waypoints > Next.
Click Rate field.
Note that the default rate is auto-selected.
Click RHP back button.
Click Create expense.
Verify that the expense is created without error

Split - Members on the confirmation page show hover effect but not clickable #56633

Open the workspace chat or group chat
Click + > Split expense > Manual
Enter any amount and go to the next step
On confirmation page, verify that the participant has no hover effect and can't be clickable

Per diem - User can select 1:1 DM or workspace with no per diem rate as destination #56634

Open FAB > Submit expense > Per diem.
Fill in the information and reach confirmation page.
Verify that the To field has no hover effect and can't be clickable

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-02-11.at.14.30.46.mov

Android: mWeb Chrome

Screen.Recording.2025-02-11.at.14.28.03.mov

iOS: Native

Screen.Recording.2025-02-11.at.14.32.38.mov

iOS: mWeb Safari

Screen.Recording.2025-02-11.at.14.29.04.mov

MacOS: Chrome / Safari

Screen.Recording.2025-02-11.at.14.24.18.mov

Screen.Recording.2025-02-11.at.14.45.43.mp4

Screen.Recording.2025-02-11.at.14.25.36.mov

Screen.Recording.2025-02-11.at.14.26.57.mov

MacOS: Desktop

Screen.Recording.2025-02-11.at.14.34.47.mov

melvin-bot · 2025-02-11T07:48:43Z

@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Julesssss · 2025-02-11T17:01:05Z

Hi @alitoshmatov, the follow up PR is a priority. Please comment here if you want me to keep you assigned, else I would like to assign to someone else in the team

allgandalf · 2025-02-11T17:07:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-02-11.at.11.41.38.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-02-11.at.11.40.59.PM.mov

iOS: Native

Screen.Recording.2025-02-11.at.11.32.05.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-02-11.at.11.35.12.PM.mov

MacOS: Chrome / Safari

#56638 (comment)

MacOS: Desktop

Screen.Recording.2025-02-11.at.11.33.50.PM.mov

src/components/MoneyRequestConfirmationList.tsx

allgandalf · 2025-02-11T17:22:23Z

[Due for payment 2025-02-19] [Due for payment 2025-02-19] [$250] Expense - Expense is submitted to the workspace chat when 1:1 DM is the destination #56630
Status: Fixed 🟢

Screen.Recording.2025-02-11.at.10.44.32.PM.mov

Distance -Rate is not selected and error when submitting distance expense to default workspace #56631
Status: Fixed 🟢

Screen.Recording.2025-02-11.at.10.46.35.PM.mov

Split - Members on the confirmation page show hover effect but not clickable #56633
Status: ~~Not Fixed 🔴~~ NAB (This is a expected result, so marked as NAB)

Screen.Recording.2025-02-11.at.10.48.15.PM.mov

Per diem - User can select 1:1 DM or workspace with no per diem rate as destination #56634
Status: Fixed 🟢

Screen.Recording.2025-02-11.at.10.51.03.PM.mov

nkdengineer · 2025-02-11T17:28:37Z

#56633

@allgandalf For this one, you can we has no hover effect when hovering the participant. It's the expected instead of going to the detail page.

allgandalf

Considering the issue:

#56633

As NAB, as mentioned by @nkdengineer here

♻️ I can confirm that the related blockers have been fixed, all yours @Julesssss

OSBotify · 2025-02-11T19:31:14Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

fix create expense flow regression (cherry picked from commit 27d6da7) (CP triggered by Julesssss)

github-actions · 2025-02-11T21:49:30Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.96-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2025-02-12T01:45:33Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.96-1 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

ikevin127 · 2025-03-09T19:31:37Z

src/components/MoneyRequestConfirmationList.tsx

                isSelected: false,
-                isInteractive: transaction?.isFromGlobalCreate,
-                shouldShowRightIcon: transaction?.isFromGlobalCreate,
+                isInteractive: isCreateExpenseFlow,


Because part of the isCreateExpenseFlow condition variable (transaction?.isFromGlobalCreate) was evaluating as undefined, the condition variable itself evaluating as undefined and because isInteractive was expecting boolean, the following issue surfaced:

[Due for payment 2025-03-11] [$250] Track expense - To field is clickable and has hover effect when the field cannot be edited #57521

which we fixed by using double negation on the condition variable to enforce the boolean type.

fix create expense flow regression

9c409e0

nkdengineer marked this pull request as ready for review February 11, 2025 07:48

nkdengineer requested a review from a team as a code owner February 11, 2025 07:48

melvin-bot bot requested review from alitoshmatov and removed request for a team February 11, 2025 07:48

fix bug global create

3ab70e7

nkdengineer mentioned this pull request Feb 11, 2025

Expense - Workspace list disappears from recipient list after selecting self DM #56662

Closed

8 tasks

paultsimura mentioned this pull request Feb 11, 2025

Web - Distance - No option to select participant when create distance expense via FAB #56659

Closed

8 tasks

Expensify deleted a comment from mollfpr Feb 11, 2025

Julesssss requested review from allgandalf and removed request for alitoshmatov February 11, 2025 17:06

allgandalf reviewed Feb 11, 2025

View reviewed changes

src/components/MoneyRequestConfirmationList.tsx Show resolved Hide resolved

allgandalf reviewed Feb 11, 2025

View reviewed changes

src/components/MoneyRequestConfirmationList.tsx Show resolved Hide resolved

allgandalf approved these changes Feb 11, 2025

View reviewed changes

melvin-bot bot requested a review from techievivek February 11, 2025 18:14

This comment was marked as outdated.

Sign in to view

Julesssss added the CP Staging marks PRs that have been CP'd to staging label Feb 11, 2025

Julesssss approved these changes Feb 11, 2025

View reviewed changes

Julesssss merged commit 27d6da7 into Expensify:main Feb 11, 2025
20 of 24 checks passed

OSBotify pushed a commit that referenced this pull request Feb 11, 2025

Merge pull request #56638 from nkdengineer/fix/56630

744d8db

fix create expense flow regression (cherry picked from commit 27d6da7) (CP triggered by Julesssss)

Julesssss mentioned this pull request Feb 11, 2025

Deploy Checklist: New Expensify 2025-02-11 #56625

Closed

69 tasks

Julesssss mentioned this pull request Feb 11, 2025

feat: skip participant step in create flow #56090

Merged

50 tasks

ikevin127 reviewed Mar 9, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix create expense flow regression#56638

fix create expense flow regression#56638
Julesssss merged 2 commits intoExpensify:mainfrom
nkdengineer:fix/56630

nkdengineer commented Feb 11, 2025 •

edited by Julesssss

Loading

Uh oh!

melvin-bot bot commented Feb 11, 2025

Uh oh!

Julesssss commented Feb 11, 2025

Uh oh!

allgandalf commented Feb 11, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

allgandalf commented Feb 11, 2025 •

edited

Loading

Uh oh!

nkdengineer commented Feb 11, 2025

Uh oh!

allgandalf left a comment

Uh oh!

This comment was marked as outdated.

Uh oh!

OSBotify commented Feb 11, 2025

Uh oh!

github-actions bot commented Feb 11, 2025

Uh oh!

github-actions bot commented Feb 12, 2025

Uh oh!

ikevin127 Mar 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

nkdengineer commented Feb 11, 2025 • edited by Julesssss Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 11, 2025

Uh oh!

Julesssss commented Feb 11, 2025

Uh oh!

allgandalf commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

allgandalf commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nkdengineer commented Feb 11, 2025

Uh oh!

allgandalf left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

OSBotify commented Feb 11, 2025

Uh oh!

github-actions bot commented Feb 11, 2025

Uh oh!

github-actions bot commented Feb 12, 2025

Uh oh!

ikevin127 Mar 9, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nkdengineer commented Feb 11, 2025 •

edited by Julesssss

Loading

allgandalf commented Feb 11, 2025 •

edited

Loading

allgandalf commented Feb 11, 2025 •

edited

Loading