Initial implementation of the Side Pane#56490
Merged
francoisl merged 62 commits intoExpensify:mainfrom Mar 4, 2025
Merged
Conversation
8 tasks
This was referenced Mar 5, 2025
8 tasks
|
@blazejkustra Found issues #57805, #57798 |
This was referenced Mar 5, 2025
Closed
8 tasks
This was referenced Mar 6, 2025
Contributor
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.9-8 🚀
|
8 tasks
This was referenced Mar 11, 2025
Collaborator
|
As @blazejkustra is already aware, this PR caused #57807. Explanation in the PR description here. |
Contributor
8 tasks
hungvu193
reviewed
May 29, 2025
| shouldShowCloseButton={isExtraLargeScreenWidth} | ||
| shouldDisplayHelpButton={false} | ||
| /> | ||
| {getHelpContent(styles, route)} |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Design doc: https://docs.google.com/document/d/1prFcvgUlEGRuL3zE-JH-lhv_BWX2lL2YNw61w4YVnyY/edit?tab=t.0
This PR implements Stage 1 of the help pane project, which sets up the initial UI and basic functionality without actual help content. The key changes include:
Fixed Issues
$ #56988
PROPOSAL: N/A
Tests
Open the JS console and run:
Verify that Side Pane and HelpButton is not displayed
In the JS console again, run the following:
Verify that the Help Button becomes visible in the UI
Verify that you can access HelpPane by clicking the button for almost every page and it is visible:
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.webm
Android: mWeb Chrome
android-web.webm
iOS: Native
ios.mp4
iOS: mWeb Safari
ios-web.mp4
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov