fix: paused video auto start when enable fullscreen mode by linhvovan29546 · Pull Request #56496 · Expensify/App

linhvovan29546 · 2025-02-07T00:41:54Z

Explanation of Change

The onReadyForDisplay callback is triggered when fullscreen mode is enabled, causing playVideo to be called and the video to start playing unexpectedly. This PR move playVideo function to onLoad instead of onReadyForDisplay

Fixed Issues

$ #55965
PROPOSAL: #55965 (comment)

Tests

Open attachment
Pause the video
Go to full screen mode
Verify paused video must not start playing in full screen mode.

Verify that no errors appear in the JS console

Offline tests

Same test as above

QA Steps

Same test as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

media_20250207_083209_94865088662254370.mp4

Android: mWeb Chrome

media_20250207_083209_8618225195132120160.mp4

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-02-06.at.16.06.07.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-02-06.at.16.10.43.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-02-06.at.4.30.38.PM.mov

MacOS: Desktop

Screen.Recording.2025-02-06.at.4.19.35.PM.mov

melvin-bot · 2025-02-07T07:56:42Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

linhvovan29546 · 2025-02-07T08:06:57Z

@eVoloshchak I've tested and it works well on native. However, I see two console errors on both web and desktop. These errors already exist on staging, prod and will affect this PR, preventing the video from autoplaying. Should we fix them within this PR?

Both errors come from the playVideo function, with one occurring when called inside onReadyForDisplay or onLoad

Screen.Recording.2025-02-07.at.2.55.04.PM.mp4

linhvovan29546 · 2025-02-12T06:56:04Z

@eVoloshchak Could you review this when you have a chance? Thank you!

…rt-playing-when-enable-fullscreen

mountiny · 2025-02-17T17:50:43Z

@eVoloshchak bump

@linhvovan29546 can you please merge main?

eVoloshchak · 2025-02-17T17:59:25Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-03-10.at.08.14.51.mov

Android: mWeb Chrome

Screen.Recording.2025-03-10.at.08.18.39.mov

iOS: Native

Screen.Recording.2025-03-10.at.08.24.11.mov

iOS: mWeb Safari

Screen.Recording.2025-03-10.at.08.26.00.mov

MacOS: Chrome / Safari

Screen.Recording.2025-03-10.at.08.21.22.mov

MacOS: Desktop

Screen.Recording.2025-03-10.at.08.19.40.mov

eVoloshchak · 2025-02-17T18:36:28Z

@linhvovan29546, are you able to reproduce this bug on staging? I'm unable to reproduce it on both staging and web on all platforms. Could you double-check if this has been resolved for you please?

eVoloshchak · 2025-02-17T18:40:21Z

Launch app in Android

Let's remove the first step as this is tested on all platforms

Log in via Gmail account using track and budget expenses

Go to Reports - Chat - Attachment

Do you know if these steps are necessary to reproduce the bug? I'm able to reproduce it using any video in any chat, could you check, please? We could simplify the testing steps if the bug is present for any video

…rt-playing-when-enable-fullscreen

linhvovan29546 · 2025-02-17T20:14:20Z

Updated

linhvovan29546 · 2025-02-18T02:40:10Z

@linhvovan29546, are you able to reproduce this bug on staging? I'm unable to reproduce it on both staging and web on all platforms. Could you double-check if this has been resolved for you please?

@eVoloshchak I can reproduce that with a different attachment, the issue does not appear with the video from Concierge

…rt-playing-when-enable-fullscreen

eVoloshchak · 2025-03-02T12:08:16Z

@linhvovan29546, since we're waiting on #57374 to be merged, could you convert this to draft and add HOLD FOR #57374 to the title? Thanks!

linhvovan29546 · 2025-03-02T12:13:24Z

Updated

linhvovan29546 · 2025-03-08T08:54:09Z

@eVoloshchak The PR #57374 has been merged. What's the next step? Should we wait for it to be deployed to production?

mountiny · 2025-03-08T12:37:33Z

@linhvovan29546 @eVoloshchak nah lets merge main and start building on top of it

…-when-enable-fullscreen

linhvovan29546 · 2025-03-08T13:24:18Z

@eVoloshchak I merged main and tested locally, it works well.

mountiny · 2025-03-08T21:04:53Z

@eVoloshchak please continue with the review when you can, thanks!

eVoloshchak

Tests well!

mountiny

Thanks!

OSBotify · 2025-03-10T12:29:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-10T21:35:19Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.11-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-03-14T01:06:08Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.12-7 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

…965-android-paused-video-start-playing-when-enable-fullscreen" This reverts commit 3cc4afa, reversing changes made to 52666fb.

linhvovan29546 added 2 commits February 6, 2025 18:56

fix: paused video auto start when enable fullscreen mode

b0b9604

fix: eslint fail

6b4a2be

linhvovan29546 marked this pull request as ready for review February 7, 2025 07:56

linhvovan29546 requested a review from a team as a code owner February 7, 2025 07:56

melvin-bot bot requested review from eVoloshchak and removed request for a team February 7, 2025 07:56

linhvovan29546 changed the title ~~[WIP]fix: paused video auto start when enable fullscreen mode~~ fix: paused video auto start when enable fullscreen mode Feb 7, 2025

Merge branch 'Expensify:main' into fix/55965-android-paused-video-sta…

344cf59

…rt-playing-when-enable-fullscreen

mountiny assigned linhvovan29546 Feb 17, 2025

Merge branch 'Expensify:main' into fix/55965-android-paused-video-sta…

e8c53bf

…rt-playing-when-enable-fullscreen

eVoloshchak mentioned this pull request Feb 18, 2025

[EUGENE - WAITING ON CHECKLIST] Android - Chat - In android, paused video starts playing when full screen mode enabled #55965

Closed

8 tasks

linhvovan29546 added 2 commits February 20, 2025 19:51

Merge branch 'Expensify:main' into fix/55965-android-paused-video-sta…

e5718c5

…rt-playing-when-enable-fullscreen

Merge branch 'Expensify:main' into fix/55965-android-paused-video-sta…

43d897d

…rt-playing-when-enable-fullscreen

linhvovan29546 marked this pull request as draft March 2, 2025 12:12

linhvovan29546 changed the title ~~fix: paused video auto start when enable fullscreen mode~~ [HOLD FOR #57374] fix: paused video auto start when enable fullscreen mode Mar 2, 2025

Merge branch 'main' into fix/55965-android-paused-video-start-playing…

b1c0f23

…-when-enable-fullscreen

linhvovan29546 marked this pull request as ready for review March 8, 2025 13:22

linhvovan29546 changed the title ~~[HOLD FOR #57374] fix: paused video auto start when enable fullscreen mode~~ fix: paused video auto start when enable fullscreen mode Mar 8, 2025

eVoloshchak approved these changes Mar 10, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny March 10, 2025 07:29

mountiny approved these changes Mar 10, 2025

View reviewed changes

mountiny merged commit 3cc4afa into Expensify:main Mar 10, 2025
18 checks passed

github-actions bot mentioned this pull request Mar 10, 2025

Deploy Checklist: New Expensify 2025-03-10 #58124

Closed

linhvovan29546 deleted the fix/55965-android-paused-video-start-playing-when-enable-fullscreen branch March 18, 2025 12:12

Conversation

linhvovan29546 commented Feb 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 7, 2025

Uh oh!

linhvovan29546 commented Feb 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linhvovan29546 commented Feb 12, 2025

Uh oh!

mountiny commented Feb 17, 2025

Uh oh!

eVoloshchak commented Feb 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eVoloshchak commented Feb 17, 2025

Uh oh!

eVoloshchak commented Feb 17, 2025

Uh oh!

linhvovan29546 commented Feb 17, 2025

Uh oh!

linhvovan29546 commented Feb 18, 2025

Uh oh!

eVoloshchak commented Mar 2, 2025

Uh oh!

linhvovan29546 commented Mar 2, 2025

Uh oh!

linhvovan29546 commented Mar 8, 2025

Uh oh!

mountiny commented Mar 8, 2025

Uh oh!

linhvovan29546 commented Mar 8, 2025

Uh oh!

mountiny commented Mar 8, 2025

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Mar 10, 2025

Uh oh!

github-actions bot commented Mar 10, 2025

Uh oh!

github-actions bot commented Mar 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

linhvovan29546 commented Feb 7, 2025 •

edited

Loading

linhvovan29546 commented Feb 7, 2025 •

edited

Loading

eVoloshchak commented Feb 17, 2025 •

edited

Loading