fix error when reloading video attachment#57374
Conversation
melvin-bot
bot
requested review from
parasharrajat
and removed request for
a team
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| return; | ||
| } | ||
| shareVideoPlayerElements(videoPlayerRef.current, videoPlayerElementParentRef.current, videoPlayerElementRef.current, isUploading || isFullScreenRef.current); | ||
| // On mobile safari, we need to auto-play when sharing video element here |
There was a problem hiding this comment.
In mobile safari, the video isn't auto-play after our change, my safari development doesn't work when I try to see the log to have a deep RCA. Can you please help to log in when running the Safari mobile web on the logic here? Thanks.
App/src/components/VideoPlayer/BaseVideoPlayer.tsx
Lines 481 to 483 in 7d0bcb4
There was a problem hiding this comment.
What do you want me to log? I didn't understand.
There was a problem hiding this comment.
@parasharrajat I want to add a log like this. My safari develop console doesn't work when I run the mobile safari web.
if (isCurrentlyURLSet && !isUploading) {
console.log("runned play video");
playVideo();
}
There was a problem hiding this comment.
I see this log. Do you have any specific steps that I should perform? Anyways, Looks like when we reload the page, safari debugger disconnects.
There was a problem hiding this comment.
@parasharrajat The step is just simply clicking on a video thumbnail to play. If we only use isReadyForDisplayRef.current, the video isn't auto play.
|
@parasharrajat @mkzie2 what are the next steps here and how can get this unblocked and merged? |
|
@mkzie2 I got this error on the mweb safari. 04.03.2025_23.18.46_REC.mp4 |
|
@parasharrajat, is there any special configuration or device? I can't reproduce this Screen.Recording.2025-03-05.at.16.56.52.mov |
|
Nope, I just used a simulator. You can try with a new simulator. |
|
@parasharrajat, which device and IOS version did you use? I tried with some other devices but still can not reproduce this bug. |
|
BY default, safari prevents it so I am not sure how it is working for you. There is a setting I guess to enable this. I am using iPhone 16 iOS 18.2 |
@parasharrajat Here is my result in the same device. I checked a setting like Screen.Recording.2025-03-06.at.17.06.26.mov |
|
I think we are fine with this. As per my research, safari blocks this, so its fine. I will check on real device. |
Screenshots🔲 iOS / native06.03.2025_18.29.24_REC.mp4🔲 iOS / Safari06.03.2025_18.21.27_REC.mp4🔲 MacOS / Desktop06.03.2025_18.20.09_REC.mp4🔲 MacOS / Chrome06.03.2025_18.06.13_REC.mp4🔲 Android / Chrome06.03.2025_20.52.40_REC.mp4🔲 Android / native06.03.2025_20.47.19_REC.mp4 |
parasharrajat
left a comment
parasharrajat
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g.
myBool && <MyComponent />. - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the
Waiting for Copylabel for a copy review on the original GH to get the correct copy. - I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel so the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
🎀 👀 🎀 C+ reviewed
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/deetergp in version: 9.1.11-1 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.1.12-7 🚀
|
5 participants
Explanation of Change
fix error when reloading video attachment
Fixed Issues
$ #57055
PROPOSAL: #57055 (comment)
Tests
Offline tests
None
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-02-25.at.10.45.06.mov
Android: mWeb Chrome
Screen.Recording.2025-02-25.at.10.34.07.mov
iOS: Native
Screen.Recording.2025-02-25.at.10.57.32.mov
iOS: mWeb Safari
Screen.Recording.2025-02-25.at.11.37.29.mov
MacOS: Chrome / Safari
Screen.Recording.2025-02-25.at.10.33.02.mov
MacOS: Desktop
Screen.Recording.2025-02-25.at.10.48.59.mov