Add manager mctest tooltips to create expense flow by kubabutkiewicz · Pull Request #56759 · Expensify/App

kubabutkiewicz · 2025-02-12T15:01:21Z

Explanation of Change

Fixed Issues

Tests

Make sure you are added to beta for testing manager mctest
And you are on account that didn't send any expenses or dont have in Onyx scanTestTooltip value in NVP_DISMISSED_PRODUCT_TRAINING key

Open FAB
Select Create Expense
When on Scan tab verify that tooltip for trying out testing receipt is visible
Add some file and go to next step
Go to select participant page
Verify that Manager McTest is visible and tooltip for selecting it for testing is visible
Select Manager McTest
On confirmation page verify that the tooltip above confirm button is visible
Open FAB
Select Create Expense
Select Manual
Add some amount
Go to select participant page
Verify that Manager McTest is visible and tooltip for selecting it for testing is visible
Select Manager McTest
On confirmation page verify that the tooltip above confirm button is visible
Open FAB
Select Create Expense
Select Distance
Add some waypoints
Go to select participant page
Verify that Manager McTest is visible and tooltip for selecting it for testing is visible
Select Manager McTest
On confirmation page verify that the tooltip above confirm button is visible

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

iOS: Native

io1.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

…to add-manager-mctest-tooltips-to-create-expense-flow

JKobrynski

One minor comment, other than that, LGTM

src/components/MoneyRequestConfirmationList.tsx

…to add-manager-mctest-tooltips-to-create-expense-flow

melvin-bot · 2025-02-13T17:05:21Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…to add-manager-mctest-tooltips-to-create-expense-flow

fabioh8010 · 2025-02-14T10:52:30Z

src/libs/OptionsListUtils.ts

    return report.isUnread === true && notificationPreference !== CONST.REPORT.NOTIFICATION_PREFERENCE.MUTE && !isHiddenForCurrentUser(notificationPreference);
 }

+function isSelectedManagerMcTest(email: string | null | undefined): boolean {


Could you add description for function?

Also, why null? Is that really a possibility?

it comes from here

App/src/components/SelectionList/InviteMemberListItem.tsx

Line 28 in 9c91706

item,

tests/ui/components/TabSelectorItem.tsx

DylanDylann · 2025-02-17T08:55:27Z

src/pages/iou/request/step/IOURequestStepParticipants.tsx

                });
            } else {
-                Navigation.navigate(route);
+                Navigation.navigate(route, {forceReplace: true});


Why do you change this line?

There are some cases where the flow is: Entering amount > Selecting participant > Confirmation Page

This is added because after recent changes with navigation when we are coming back to page which we already displayed in the html there are 2 of those screens and becasuse of that tooltip is displayed twice

test.mp4

DylanDylann · 2025-02-17T09:04:12Z

src/components/MoneyRequestConfirmationList.tsx

                )}
-
-                {button}
+                <EducationalTooltip


NAB: But let's add a condition for more safe

shouldShowProductTrainingTooltip && (<EducationalTooltip....)

I am not sure if this is needed its already handled by shouldShowProductTrainingTooltip so if we add this condition we would basically made the same condition which we are passing to useProductTrainingContext

DylanDylann · 2025-02-17T09:11:50Z

src/components/SelectionList/InviteMemberListItem.tsx

-                                    item.alternateText ? styles.mb1 : null,
-                                ]}
-                            />
+                <EducationalTooltip


NAB: Becasue InviteMemberListItem is used in many places, for more safe, Let's add a condition to make sure that the education tooltips only display on create expense flow

…to add-manager-mctest-tooltips-to-create-expense-flow

DylanDylann · 2025-02-18T07:19:06Z

@kubabutkiewicz Conflict again

DylanDylann · 2025-02-18T07:19:25Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-02-18.at.14.50.45.mov

Android: mWeb Chrome

Screen.Recording.2025-02-18.at.14.52.55.mov

iOS: Native

Screen.Recording.2025-02-18.at.14.49.27.mov

iOS: mWeb Safari

Screen.Recording.2025-02-18.at.14.51.42.mov

MacOS: Chrome / Safari

Screen.Recording.2025-02-18.at.14.52.13.mov

MacOS: Desktop

Screen.Recording.2025-02-18.at.14.49.49.mov

DylanDylann

All good

DylanDylann · 2025-02-18T07:54:13Z

@kubabutkiewicz Please help to fix conflict

grgia · 2025-02-20T17:25:24Z

Should we have design do QA on this PR @kubabutkiewicz ? I think there's slightly too much space between the button and tooltip

grgia · 2025-02-20T17:28:49Z

Some minor design tweaks may need to be made to match the figma

DylanDylann · 2025-02-21T06:55:05Z

@grgia I see It already matched with the design on document

DylanDylann

Approved again to re-trigger GH actions

kubabutkiewicz · 2025-02-21T07:53:32Z

Hey, I will have soon PR with BE integration when I had to change a place in the code from where we are displaying this tooltip, so maybe we can do those adjustments there ? Here is a draft PR #57171

DylanDylann · 2025-02-24T09:36:05Z

@grgia Kindly bump

grgia

Nice work on this one 🙏

OSBotify · 2025-02-24T18:08:10Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

kavimuru · 2025-02-24T20:01:40Z

@chiragsalian @kubabutkiewicz @grgia

Make sure you are added to beta for testing manager mctest

Are the applause.expensifail.com domain account is added to beta to verify this PR?

github-actions · 2025-02-24T20:14:50Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.1.5-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

chiragsalian · 2025-02-24T22:07:56Z

Are the applause.expensifail.com domain account is added to beta to verify this PR?

Let's check, the beta name is newDotManagerMcTest.

Looks like the domain +@applause.expensifail.com has this beta added already for the domain.

yuwenmemon · 2025-02-25T04:31:39Z

FYI folks, it looks like this PR has caused a couple of blockers, #57351 being one of them. Unsure how we wanted to proceed as I believe this is under beta?

kubabutkiewicz · 2025-02-25T08:31:39Z

@yuwenmemon Yes its under the beta, and both of this issues says about not implemented things yet, so I think they can be closed.

izarutskaya · 2025-02-25T11:28:51Z

@kubabutkiewicz Failing with issue #57365

https://platform.applause.com/services/links/v1/external/c1c783e16f45185fb75ccf9aa16957ec795ac272510ac8159445903c3d608f93

kubabutkiewicz · 2025-02-25T12:25:23Z

@izarutskaya #56759 (comment)

chiragsalian · 2025-02-25T22:30:26Z

Heads up, i reverted this PR as it was a blocker for deploy from this issue - #57381

github-actions · 2025-02-26T00:03:57Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.5-5 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

DylanDylann · 2025-02-26T09:22:22Z

@kubabutkiewicz The PR was reverted

kubabutkiewicz · 2025-02-26T09:32:07Z

Yeah, I am working on it right now to bring it back @DylanDylann

kubabutkiewicz added 8 commits February 10, 2025 16:52

Add test recipt toolstips to IOU Scan start page

d00e200

add tooltip to manager mctest recipient

48e1b1b

Merge branch 'main' of github.com:callstack-internal/Expensify-App in…

542c3cb

…to add-manager-mctest-tooltips-to-create-expense-flow

added new tooltip for recipents view for trying manager mc test

70aa35a

removed log

f06c76c

fix styling

85cfe40

Merge branch 'main' of github.com:callstack-internal/Expensify-App in…

251ce24

…to add-manager-mctest-tooltips-to-create-expense-flow

add last tooltip for manager mctest

d406483

JKobrynski reviewed Feb 12, 2025

View reviewed changes

src/components/MoneyRequestConfirmationList.tsx Outdated Show resolved Hide resolved

kubabutkiewicz added 5 commits February 13, 2025 10:22

resolve comment

df45451

Merge branch 'main' of github.com:callstack-internal/Expensify-App in…

e3e53aa

…to add-manager-mctest-tooltips-to-create-expense-flow

fix navigation issues

ff9e9d9

Merge branch 'main' of github.com:callstack-internal/Expensify-App in…

3103933

…to add-manager-mctest-tooltips-to-create-expense-flow

fix test

b1a180e

kubabutkiewicz marked this pull request as ready for review February 13, 2025 17:05

kubabutkiewicz requested a review from a team as a code owner February 13, 2025 17:05

melvin-bot bot requested review from DylanDylann and removed request for a team February 13, 2025 17:05

Merge branch 'main' of github.com:callstack-internal/Expensify-App in…

d300a34

…to add-manager-mctest-tooltips-to-create-expense-flow

fabioh8010 reviewed Feb 14, 2025

View reviewed changes

resolve comments

e27157d

fabioh8010 approved these changes Feb 14, 2025

View reviewed changes

DylanDylann reviewed Feb 17, 2025

View reviewed changes

Merge branch 'main' of github.com:callstack-internal/Expensify-App in…

684569d

…to add-manager-mctest-tooltips-to-create-expense-flow

DylanDylann approved these changes Feb 18, 2025

View reviewed changes

melvin-bot bot requested a review from grgia February 18, 2025 07:53

DylanDylann approved these changes Feb 21, 2025

View reviewed changes

melvin-bot bot requested a review from grgia February 21, 2025 06:55

grgia approved these changes Feb 24, 2025

View reviewed changes

grgia merged commit 61ed8ca into Expensify:main Feb 24, 2025
17 of 18 checks passed

This was referenced Feb 24, 2025

Investigate workflow job failing on main: e2ePerformanceTests / Build apk from delta ref / Build Android app #57333

Closed

Deploy Checklist: New Expensify 2025-02-24 #57336

Closed

mitarachim mentioned this pull request Feb 25, 2025

Expense - Clicking on tooltip is not functional #57365

Closed

8 tasks

yuwenmemon mentioned this pull request Feb 25, 2025

Expense - "Try it out" button is not functional #57351

Closed

8 tasks

parasharrajat mentioned this pull request Feb 25, 2025

[Hold #54924] Show Product tooltip for Workspace participant on create expense #56041

Closed

50 tasks

nkdengineer mentioned this pull request Feb 25, 2025

[$250] Chat - Re-selection is required to change payment method from Pay elsewhere to Expensify #57381

Closed

8 tasks

chiragsalian mentioned this pull request Feb 25, 2025

Revert "Add manager mctest tooltips to create expense flow" #57433

Merged

48 tasks

Conversation

kubabutkiewicz commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

JKobrynski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

melvin-bot bot commented Feb 13, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kubabutkiewicz Feb 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Feb 18, 2025

Uh oh!

DylanDylann commented Feb 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann left a comment

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Feb 18, 2025

Uh oh!

grgia commented Feb 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

grgia commented Feb 20, 2025

Uh oh!

DylanDylann commented Feb 21, 2025

Uh oh!

DylanDylann left a comment

Choose a reason for hiding this comment

Uh oh!

kubabutkiewicz commented Feb 21, 2025

Uh oh!

DylanDylann commented Feb 24, 2025

Uh oh!

grgia left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Feb 24, 2025

Uh oh!

kavimuru commented Feb 24, 2025

Uh oh!

github-actions bot commented Feb 24, 2025

Uh oh!

chiragsalian commented Feb 24, 2025

Uh oh!

yuwenmemon commented Feb 25, 2025

Uh oh!

kubabutkiewicz commented Feb 25, 2025

kubabutkiewicz commented Feb 12, 2025 •

edited

Loading

kubabutkiewicz Feb 17, 2025 •

edited

Loading

DylanDylann commented Feb 18, 2025 •

edited

Loading

grgia commented Feb 20, 2025 •

edited

Loading

grgia left a comment •

edited

Loading