Integrate BE for Manager McTest feature by kubabutkiewicz · Pull Request #57171 · Expensify/App

kubabutkiewicz · 2025-02-20T09:30:18Z

Explanation of Change

Fixed Issues

$ #55069
$ #55070
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

iOS: Native

ios.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

…to integrate-be-manager-mctest

…thod to read local recipt

…to integrate-be-manager-mctest

…ted to marking transactions as paid elsewhere

…bile

…to integrate-be-manager-mctest

…x lint errors

…to integrate-be-manager-mctest

src/components/ProductTrainingContext/index.tsx

src/libs/ReportUtils.ts

fabioh8010 · 2025-02-25T10:36:45Z

src/pages/iou/request/step/IOURequestStepScan/index.native.tsx

+                                    height={32}
+                                    width={32}


Don't we have constants for this?

I am not sure I didn't add this 😅 I just moved this component

melvin-bot · 2025-02-25T12:16:25Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2025-02-25T14:24:40Z

The styles here look a bit off:

Just want to make sure you're using these values for the outer padding and spacing?

shawnborton · 2025-02-25T14:26:00Z

And I believe we have a margin of 28px around the whole thing, so it would be 28px away from the left and right edges of the RHP.

DylanDylann · 2025-02-27T07:01:25Z

src/components/TabSelector/TabSelectorItem.tsx

-    };
-
-    return shouldShowTestReceiptTooltip ? (
-        <EducationalTooltip


Why do you remove EducationalTooltip here?

this is moved to IOURequestStepScan screens, but lets wait until this #57480

src/libs/ReportUtils.ts

src/libs/actions/IOU.ts

DylanDylann · 2025-02-28T07:07:09Z

@kubabutkiewicz Could you help to merge the latest main because we merged #57480? Many thanks

DylanDylann · 2025-02-28T07:07:20Z

Start on reviewing again

grgia · 2025-03-13T16:04:58Z

We can ignore ios ^ its a cache issue

grgia · 2025-03-13T16:19:14Z

I can't get past this

Mar-13-2025.16-19-01.mp4

grgia · 2025-03-13T17:00:59Z

We are held on final QA -> #57554 (comment)

DylanDylann · 2025-03-14T03:50:35Z

@kubabutkiewicz The date looks wrong

Screen.Recording.2025-03-14.at.10.49.21.mov

DylanDylann · 2025-03-14T03:54:12Z

@kubabutkiewicz @grgia After receiving the BE response, the request currency changed to local currency. Should we need to adjust the currency on the optimistic data?

Offline

Online

…to integrate-be-manager-mctest

grgia · 2025-03-14T11:22:45Z

@DylanDylann if its only the report total, we can match the typical IOU flows for scan receipt currencies

grgia · 2025-03-14T11:32:00Z

@kubabutkiewicz could we fix the date?

kubabutkiewicz · 2025-03-14T11:47:32Z

@grgia @DylanDylann About date, I think this is what is happening for every scan receipt, so for optimistic date for scans its using current date, do we want to change it for scans to manager mc test? I posting screens for using my own receipt

grgia · 2025-03-14T12:08:55Z

@kubabutkiewicz let's leave as is in that case!

grgia · 2025-03-14T17:26:57Z

conflicts?

grgia · 2025-03-14T17:32:22Z

We CPd the scan fix btw

…to integrate-be-manager-mctest

kubabutkiewicz · 2025-03-14T21:06:06Z

@grgia conflicts resolved

DylanDylann · 2025-03-17T04:03:40Z

@grgia I think this PR is fine to merge

grgia

LEGGO!

OSBotify · 2025-03-17T09:32:28Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

izarutskaya · 2025-03-17T11:45:09Z

@kubabutkiewicz Any QA steps for this?

github-actions · 2025-03-17T12:01:18Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.1.14-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-03-18T21:28:22Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.14-5 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

shubham1206agra · 2025-05-15T15:28:15Z

src/pages/iou/request/step/IOURequestStepScan/index.tsx

+
+    const {shouldShowProductTrainingTooltip, renderProductTrainingTooltip} = useProductTrainingContext(
+        CONST.PRODUCT_TRAINING_TOOLTIP_NAMES.SCAN_TEST_TOOLTIP,
+        !getIsUserSubmittedExpenseOrScannedReceipt() && Permissions.canUseManagerMcTest(betas) && isTabActive,


You have not checked for screens where we don't want to show this tooltip, which caused #58959

Krishna2323 · 2026-01-06T10:10:45Z

src/libs/actions/IOU.ts

+                    total: isTestReceipt ? CONST.TEST_RECEIPT.AMOUNT : iou.report?.total,
+                    currency: isTestReceipt ? CONST.TEST_RECEIPT.CURRENCY : iou.report?.currency,
+                    lastActionType: CONST.REPORT.ACTIONS.TYPE.MARKED_REIMBURSED,
+                    statusNum: CONST.REPORT.STATUS_NUM.REIMBURSED,


We forgot to add the stateNum property, which caused the expense preview to not show the paid tag. More details can be found in the issue and the proposal.

kubabutkiewicz added 7 commits February 17, 2025 09:30

Merge branch 'main' of github.com:callstack-internal/Expensify-App in…

0aaf97e

…to integrate-be-manager-mctest

Merge branch 'main' of github.com:callstack-internal/Expensify-App in…

e385396

…to integrate-be-manager-mctest

add config to pass methods to confirm and dismiss tooltips

4e27760

add local image for a test receipt, remove unnecessary things, add me…

f9ef4d6

…thod to read local recipt

Merge branch 'main' of github.com:callstack-internal/Expensify-App in…

82e11a4

…to integrate-be-manager-mctest

add onDissmis method to product training context, teting changes rela…

964f7e4

…ted to marking transactions as paid elsewhere

fix lint problems, add creating money request with test receipt on mo…

3967917

…bile

kubabutkiewicz mentioned this pull request Feb 21, 2025

Add manager mctest tooltips to create expense flow #56759

Merged

50 tasks

kubabutkiewicz added 7 commits February 21, 2025 10:02

Merge branch 'main' of github.com:callstack-internal/Expensify-App in…

5be29c7

…to integrate-be-manager-mctest

fix displaying tooltips when chaning tabs

905216e

add marking optimistically manager mctest transactions as paid and fi…

6113a97

…x lint errors

Merge branch 'main' of github.com:callstack-internal/Expensify-App in…

273ccfd

…to integrate-be-manager-mctest

Merge branch 'main' of github.com:callstack-internal/Expensify-App in…

106c76a

…to integrate-be-manager-mctest

resolve issues after self review

a9982cf

removed unwanted change

bb037a4

fabioh8010 reviewed Feb 25, 2025

View reviewed changes

resolve comments

9673da4

kubabutkiewicz marked this pull request as ready for review February 25, 2025 12:16

kubabutkiewicz requested review from a team as code owners February 25, 2025 12:16

melvin-bot bot requested review from DylanDylann and removed request for a team February 25, 2025 12:16

kubabutkiewicz mentioned this pull request Feb 26, 2025

Add manager mctest tooltips to create expense flow #57480

Merged

50 tasks

DylanDylann reviewed Feb 27, 2025

View reviewed changes

fixes after review

f02c4bb

grgia mentioned this pull request Mar 13, 2025

[Due for payment 2025-03-25] [Due for payment 2025-03-24] [$1000][CRITICAL] Unable to create an expense by receipt scanning #57554

Closed

8 tasks

Merge branch 'main' of github.com:callstack-internal/Expensify-App in…

dfa22ed

…to integrate-be-manager-mctest

kubabutkiewicz added 2 commits March 14, 2025 21:58

Merge branch 'main' of github.com:callstack-internal/Expensify-App in…

51668fb

…to integrate-be-manager-mctest

Merge branch 'main' of github.com:callstack-internal/Expensify-App in…

1f86c13

…to integrate-be-manager-mctest

fix ts check

4398d93

grgia approved these changes Mar 17, 2025

View reviewed changes

grgia merged commit e45a68d into Expensify:main Mar 17, 2025
16 checks passed

github-actions bot mentioned this pull request Mar 17, 2025

Deploy Checklist: New Expensify 2025-03-17 #58550

Closed

72 tasks

linhvovan29546 mentioned this pull request Mar 17, 2025

[Due for payment 2025-05-08] [$250] mWeb - Receipt - Scan page bottom buttons misaligned and centre loading displayed #58556

Closed

8 tasks

shubham1206agra reviewed May 15, 2025

View reviewed changes

aldo-expensify mentioned this pull request May 23, 2025

fix: the tooltip button is not functional on android #62213

Merged

51 tasks

Krishna2323 reviewed Jan 6, 2026

View reviewed changes

Krishna2323 mentioned this pull request Jan 6, 2026

[Due for payment 2025-12-26] [$250] Expense - In offline, expense preview doesn't show paid tag and thread message is shown as msg #74040

Closed

8 tasks

Conversation

kubabutkiewicz commented Feb 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

fabioh8010 Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

kubabutkiewicz Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Feb 25, 2025

Uh oh!

shawnborton commented Feb 25, 2025

Uh oh!

shawnborton commented Feb 25, 2025

Uh oh!

DylanDylann Feb 27, 2025

Choose a reason for hiding this comment

Uh oh!

kubabutkiewicz Feb 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DylanDylann commented Feb 28, 2025

Uh oh!

DylanDylann commented Feb 28, 2025

Uh oh!

grgia commented Mar 13, 2025

Uh oh!

grgia commented Mar 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

grgia commented Mar 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DylanDylann commented Mar 14, 2025

Uh oh!

DylanDylann commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Offline

Online

Uh oh!

grgia commented Mar 14, 2025

Uh oh!

grgia commented Mar 14, 2025

Uh oh!

kubabutkiewicz commented Mar 14, 2025

Uh oh!

grgia commented Mar 14, 2025

Uh oh!

grgia commented Mar 14, 2025

Uh oh!

grgia commented Mar 14, 2025

Uh oh!

kubabutkiewicz commented Mar 14, 2025

Uh oh!

DylanDylann commented Mar 17, 2025

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Mar 17, 2025

Uh oh!

izarutskaya commented Mar 17, 2025

Uh oh!

github-actions bot commented Mar 17, 2025

Uh oh!

github-actions bot commented Mar 18, 2025

kubabutkiewicz commented Feb 20, 2025 •

edited

Loading

grgia commented Mar 13, 2025 •

edited

Loading

grgia commented Mar 13, 2025 •

edited

Loading

DylanDylann commented Mar 14, 2025 •

edited

Loading