fix: the tooltip button is not functional on android by linhvovan29546 · Pull Request #62213 · Expensify/App

linhvovan29546 · 2025-05-16T13:17:13Z

Explanation of Change

Fixed Issues

$ #60634
PROPOSAL: #60634 (comment)

Tests

Sign in to the hybrid app with a new account
Navigate to FAB > Create expense
As the create expense RHP opens, navigate to scan tab
Click on "Try it out" or "No thanks" button in tooltip
Verify that User is navigated to create expense with a test receipt or tooltip closed

Verify that no errors appear in the JS console

Offline tests

Same as test above

QA Steps

Same as test above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

MicrosoftTeams-video.mp4

Android: mWeb Chrome

Screen.Recording.2025-05-16.at.20.05.20.mov

iOS: Native

Screen.Recording.2025-05-16.at.19.52.59.mov

iOS: mWeb Safari

Screen.Recording.2025-05-16.at.19.54.10.mov

MacOS: Chrome / Safari

Screen.Recording.2025-05-16.at.20.00.15.mov

MacOS: Desktop

Screen.Recording.2025-05-16.at.20.02.23.mov

melvin-bot · 2025-05-16T13:36:24Z

@suneox Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

suneox · 2025-05-18T15:21:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-05-18.at.22.18.13.mov

Android: mWeb Chrome

Screen.Recording.2025-05-18.at.23.03.17.mov

iOS: HybridApp

Screen.Recording.2025-05-18.at.23.16.57.mov

iOS: mWeb Safari

Screen.Recording.2025-05-18.at.23.16.57.mov

MacOS: Chrome / Safari

Screen.Recording.2025-05-18.at.23.08.35.mov

MacOS: Desktop

Screen.Recording.2025-05-18.at.23.13.47.mov

github-actions · 2025-05-19T08:39:31Z

🚧 @MonilBhavsar has triggered a test app build. You can view the workflow run here.

github-actions · 2025-05-19T09:22:07Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/62213-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/62213-hybrid/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/62213/NewExpensify.dmg	https://62213.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

suneox · 2025-05-19T16:14:46Z

@jponikarchuk Could you please help verify the ad-hoc build on your device? The current changes still don't work with the hybrid app on my device (Sony Xperia 5 / Android 11), although it work fine in the standalone version

If the current work works on your tested device, we can proceed with this change.

standalone version

Screen.Recording.2025-05-18.at.22.18.13.mov

hibrid version

-928089560137296765screen-20250519-171324.MP4

linhvovan29546 · 2025-05-19T16:30:18Z

@suneox Looks like the 'No thanks' button is working now. Was there an issue with it before this change? If not, then I think the RCA might be incorrect. I’ll take a look tomorrow

suneox · 2025-05-19T16:54:03Z

@suneox Looks like the 'No thanks' button is working now. Was there an issue with it before this change?

@linhvovan29546 Before the change, both buttons didn't work. In the current ad-hoc build from this PR, only the “No thanks” button works, while the “Try it out” button still doesn’t function. Currently, both buttons share the same change set, but only one of them works. If this change set works on another device i think we can proceed with this one.

Before change

screen-20250519-234441_2.mp4

Ad-Hoc Build

screen-20250519-234256_2.mp4

linhvovan29546 · 2025-05-20T02:45:07Z

@suneox I just tested the ad-hoc build on my device(android 14), and the 'Try it out' button doesn't work, even though it works on my standalone app. I think the issue is that on hybrid Android builds, we can't download the test receipt

So we have two issues here:

The button was not triggering (now fixed)
The test receipt can't be downloaded(only hybrid app)

linhvovan29546 · 2025-05-20T03:28:17Z

Okay, I think I know the root cause. The issue might occur in release mode, which would affect both hybrid and standalone apps. ~~I need to test in release mode to confirm.~~

Update: Can reproduce on standalone app in release mode.

jponikarchuk · 2025-05-20T03:58:06Z

@suneox This issue is still reprodicible on ad-hoc build 9.1.43-7

video_2025-05-19_23-31-29.mp4

linhvovan29546 · 2025-05-20T07:12:13Z

The test receipt can't be downloaded

On Native, we use resolveAssetSource to get the receipt path. This only works in debug mode. In release mode, it doesn't return the correct uri because bundled assets return static name

App/src/pages/iou/request/step/IOURequestStepScan/index.native.tsx

Line 509 in a95171a

const source = Image.resolveAssetSource(TestReceipt).uri;

suneox · 2025-05-21T12:26:58Z

The test receipt can't be downloaded

On Native, we use resolveAssetSource to get the receipt path. This only works in debug mode. In release mode, it doesn't return the correct uri because bundled assets return static name

Do we have a next step for this? Could you please try bundling the release locally and continue investigating from there?

linhvovan29546 · 2025-05-21T15:44:50Z

Do we have a next step for this? Could you please try bundling the release locally and continue investigating from there?

I haven’t had a chance to look into this more deeply due to being busy. I’ll try tomorrow or on Saturday. I think we may need to find other way to download the test receipt on Android, maybe we could use react-native-fs to copy the asset to a new file instead of download them. That’s just my initial idea.

linhvovan29546 · 2025-05-23T09:46:35Z

@suneox I have a potential solution for this, though it may not be ideal. We can use expo-file-system and expo-asset to handle downloading the test receipt instead of using react-native-blob-util, which is currently being used.

App/src/pages/iou/request/step/IOURequestStepScan/index.native.tsx

Line 500 in 409e68e

const setTestReceiptAndNavigate = useCallback(() => {

expo-file-system is already listed in our dependencies, but we’ve excluded it from autolinking. So, to implement this solution, we would need to re-enable autolinking for expo-file-system and use it to download the receipt.

Here's a basic example of how that might work. I've tested it, and it works on both Android and iOS.

import * as FileSystem from 'expo-file-system';
import { Asset } from 'expo-asset';
....
const setTestReceiptAndNavigate = useCallback(async () => {
        try {
            const filename = `${CONST.TEST_RECEIPT.FILENAME}_${Date.now()}.png`;
            const path = `${ReactNativeBlobUtil.fs.dirs.CacheDir}/${filename}`;
            const [{localUri}] = await Asset.loadAsync(require('@assets/images/fake-receipt.png'));
            if(!localUri){
                console.error('Error downloading test receipt: localUri is null');
                return
            }

            FileSystem.copyAsync({
                from: localUri,
                to: `file://${path}`,
                }).then(async () => {
                    const file: FileObject = {
                        uri: `file://${path}`,
                        name: filename,
                        type: CONST.TEST_RECEIPT.FILE_TYPE,
                        size: 0,
                    };
                    if (!file.uri) {
                        return;
                    }

                    setMoneyRequestReceipt(initialTransactionID, file.uri, filename, !isEditing, file.type, true);
                    navigateToConfirmationStep([{file, source: file.uri, transactionID: initialTransactionID}], false, true);
                })
                .catch((error) => {
                    console.error('Error downloading test receipt:', {message: error});
                });
        } catch (error) {
            console.error('Error in setTestReceiptAndNavigate:', {message: error});
        }
    }, [initialTransactionID, isEditing, navigateToConfirmationStep]);

I’m not sure if this is the best approach, but it would increase the APK size only slightly from 290.7 MB to 290.8 MB, which I think is acceptable. For other iOS, I’m not exactly sure how much the size will increase. Alternatively, we could enable this only for Android.

cc @aldo-expensify for viz, you can check the comments above for more context.

aldo-expensify · 2025-05-23T17:11:49Z

I'm understanding that the last piece is trying to get the test-receipt file to work in Android. I wonder if this has been broken since the original implementation. cc @grgia

Is this the only file we get this way? aren't any other flow broken because of the same problem?
Answer: Yes, it is the only place in our code where I see Image.resolveAssetSource

About using expo-file-system and re-enabling autolinking it, I don't know if this is a problem or not, so I'll ask :)

aldo-expensify · 2025-05-23T17:19:08Z

@kubabutkiewicz do you have an opinion on the above? 🙇 Just asking you because you did the original implementation of this code here #57171

linhvovan29546 · 2025-05-27T00:16:33Z

I saw other issue with the same root cause: #62827. Maybe we can apply that solution here as well, if it's already resolved.

linhvovan29546 · 2025-05-27T06:36:53Z

Next step: I'll merge main after the referenced PR is merged.

…ork-on-android

linhvovan29546 · 2025-05-28T00:24:54Z

Next step: I'll merge main after the referenced PR is merged.

@suneox Let's retest it. I believe it's working fine now.

suneox

The issue related to loading the test recipe has been resolved in #62827, and the current change resolves the “unable to touch tooltip button” issue LGTM

OSBotify · 2025-05-29T22:26:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-06-02T19:55:52Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.1.55-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-06-03T12:50:40Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.1.56-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

github-actions · 2025-06-03T20:03:05Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.1.58-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-06-04T16:19:19Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.1.58-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: the tooltip button is not functional on android

a74ad25

linhvovan29546 marked this pull request as ready for review May 16, 2025 13:36

linhvovan29546 requested a review from a team as a code owner May 16, 2025 13:36

melvin-bot bot requested review from suneox and removed request for a team May 16, 2025 13:36

MonilBhavsar added the Ready To Build label May 19, 2025

linhvovan29546 mentioned this pull request May 27, 2025

[CP Staging] chore: attempt at fixing infinite loading on android #62827

Merged

49 tasks

linhvovan29546 mentioned this pull request May 27, 2025

[Due for payment 2025-06-05] Android - Onboarding - Start test drive button loads infinitely after submitting email #62688

Closed

8 tasks

Merge branch 'Expensify:main' into fix/60634-try-it-out-tooltip-not-w…

437566f

…ork-on-android

suneox approved these changes May 28, 2025

View reviewed changes

melvin-bot bot requested a review from aldo-expensify May 28, 2025 15:00

aldo-expensify approved these changes May 29, 2025

View reviewed changes

aldo-expensify merged commit d3cfd31 into Expensify:main May 29, 2025
17 checks passed

linhvovan29546 deleted the fix/60634-try-it-out-tooltip-not-work-on-android branch May 29, 2025 23:38

github-actions bot mentioned this pull request Jun 2, 2025

Deploy Checklist: New Expensify 2025-06-02 #63263

Closed

melvin-bot bot mentioned this pull request Jun 4, 2025

[Due for payment 2025-06-11] [$250][HIGH] Android - Try it out button is not functional in scan tab #60634

Closed

8 tasks

Conversation

linhvovan29546 commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented May 16, 2025

Uh oh!

suneox commented May 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented May 19, 2025

Uh oh!

github-actions bot commented May 19, 2025

Uh oh!

suneox commented May 19, 2025

Uh oh!

linhvovan29546 commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

suneox commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linhvovan29546 commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linhvovan29546 commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jponikarchuk commented May 20, 2025

Uh oh!

linhvovan29546 commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

suneox commented May 21, 2025

Uh oh!

linhvovan29546 commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linhvovan29546 commented May 23, 2025

Uh oh!

aldo-expensify commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aldo-expensify commented May 23, 2025

Uh oh!

linhvovan29546 commented May 27, 2025

Uh oh!

linhvovan29546 commented May 27, 2025

Uh oh!

linhvovan29546 commented May 28, 2025

Uh oh!

suneox left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented May 29, 2025

Uh oh!

github-actions bot commented Jun 2, 2025

Uh oh!

github-actions bot commented Jun 3, 2025

Uh oh!

github-actions bot commented Jun 3, 2025

Uh oh!

github-actions bot commented Jun 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

linhvovan29546 commented May 16, 2025 •

edited

Loading

suneox commented May 18, 2025 •

edited

Loading

linhvovan29546 commented May 19, 2025 •

edited

Loading

suneox commented May 19, 2025 •

edited

Loading

linhvovan29546 commented May 20, 2025 •

edited

Loading

linhvovan29546 commented May 20, 2025 •

edited

Loading

linhvovan29546 commented May 20, 2025 •

edited

Loading

linhvovan29546 commented May 21, 2025 •

edited

Loading

aldo-expensify commented May 23, 2025 •

edited

Loading