[CP Staging] fix: FAB is not responsive after exiting create expense flow by nkdengineer · Pull Request #56865 · Expensify/App

nkdengineer · 2025-02-14T00:57:33Z

Explanation of Change

fix: FAB is not responsive after exiting create expense flow

Fixed Issues

$ #56796
$ #56800
$ #56814
PROPOSAL:

Tests

[$250] [Due for payment 2025-02-25] [Navigation] iOS - FAB - FAB is not responsive after exiting create expense flow #56796
[Due for payment 2025-02-25] iOS - Tooltip - QAB tooltip appears in + button in 1:1 DM #56800

Login with a new account and create a new workspace
Go FAB > Create expense
Click the back button to go back to LHN
Click on FAB again
Verify that the popover appears
Click on Start Chat and open any DM chat
Click on plus icon
Verify that the quick action tooltip doesn't appear

[Due for payment 2025-02-25] [$125] iOS - Distance - FAB menu appears briefly when closing distance receipt view #56814

Go to FAB > Create expense > Distance.
Enter waypoints > Next.
Tap Destination field and select user or workspace with no unsettled expense (or directly select user or workspace with no unsettled expense).
Submit the distance expense.
In the main chat, tap on the expense preview.
Tap on the distance receipt.
Tap app back button.

Verify that no errors appear in the JS console

Offline tests

Same

QA Steps

Login with a new account and create a new workspace
Go FAB > Create expense
Click the back button to go back to LHN
Click on FAB again
Verify that the popover appears
Click on Start Chat and open any DM chat
Click on plus icon
Verify that the quick action tooltip doesn't appear

[Due for payment 2025-02-25] [$125] iOS - Distance - FAB menu appears briefly when closing distance receipt view #56814

Go to FAB > Create expense > Distance.
Enter waypoints > Next.
Tap Destination field and select user or workspace with no unsettled expense (or directly select user or workspace with no unsettled expense).
Submit the distance expense.
In the main chat, tap on the expense preview.
Tap on the distance receipt.
Tap app back button.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-02-14.at.07.45.27.mov

Android: mWeb Chrome

Screen.Recording.2025-02-14.at.07.49.21.mov

iOS: Native

Screen.Recording.2025-02-14.at.07.44.46.mov

Screen.Recording.2025-02-14.at.09.31.26.mov

iOS: mWeb Safari

Screen.Recording.2025-02-14.at.07.49.55.mov

MacOS: Chrome / Safari

Screen.Recording.2025-02-14.at.07.48.13.mov

MacOS: Desktop

Screen.Recording.2025-02-14.at.07.54.19.mov

src/libs/Navigation/navigateAfterInteraction/index.ios.ts

src/pages/home/sidebar/FloatingActionButtonAndPopover.tsx

Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>

github-actions · 2025-02-14T01:43:22Z

🚧 @mountiny has triggered a test hybrid app build. You can view the workflow run here.

melvin-bot · 2025-02-14T01:52:16Z

@s77rt @mountiny One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-02-14T02:14:33Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/56865/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/56865/index.html

Desktop 💻	Web 🕸️
N/A	N/A
N/A	N/A

👀 View the workflow run that generated this build 👀

dukenv0307 · 2025-02-14T02:22:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-02-14.at.09.14.43.mov

Android: mWeb Chrome

Screen.Recording.2025-02-14.at.09.14.43.mov

iOS: Native

Screen.Recording.2025-02-14.at.09.18.45.mov

iOS: mWeb Safari

Screen.Recording.2025-02-14.at.09.13.49.mov

MacOS: Chrome / Safari

Screen.Recording.2025-02-14.at.09.12.05.mov

MacOS: Desktop

Screen.Recording.2025-02-14.at.09.21.50.mov

mountiny · 2025-02-14T02:22:30Z

src/pages/home/sidebar/FloatingActionButtonAndPopover.tsx

+        {
+            icon: Expensicons.ChatBubble,
+            text: translate('sidebarScreen.fabNewChat'),
+            onSelected: () => interceptAnonymousUser(startNewChat),


Can you please retest the original issue that this interaction manager was added for is still fixed?

mountiny

changes look good to me, thank you!

OSBotify · 2025-02-14T02:36:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[CP Staging] fix: FAB is not responsive after exiting create expense flow (cherry picked from commit d2c9a35) (CP triggered by mountiny)

github-actions · 2025-02-14T03:43:35Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.98-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

parasharrajat · 2025-02-14T06:55:58Z

src/libs/Navigation/navigateAfterInteraction/index.ios.ts

+function navigateAfterInteraction(callback: () => void) {
+    InteractionManager.runAfterInteractions(() => {
+        Navigation.setNavigationActionToMicrotaskQueue(callback);
+    });
+}


This will create delay until animation is done. Is it a best solution here?

adamgrzybowski · 2025-02-14T08:07:41Z

I think that makes sense. Alternatively, we could disable the bottom sheet closing animation during navigation to remove the delay. We need to see if the delay will bother people.

mountiny · 2025-02-14T08:22:49Z

Yeah I worried about that, but at the same time, this is better right now to unblock deploy - I will keep the issue open to still investigate better solutions

github-actions · 2025-02-17T09:05:10Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.98-8 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

nkdengineer added 4 commits February 13, 2025 20:39

close modal before executing navigation

98010bc

Merge branch 'main' into fix/56796

0e6879b

fix lint

0f5bcb0

add comment

e8d09f3

mountiny reviewed Feb 14, 2025

View reviewed changes

src/libs/Navigation/navigateAfterInteraction/index.ios.ts Outdated Show resolved Hide resolved

src/pages/home/sidebar/FloatingActionButtonAndPopover.tsx Outdated Show resolved Hide resolved

mountiny assigned nkdengineer Feb 14, 2025

mountiny changed the title ~~fix: FAB is not responsive after exiting create expense flow~~ [CP Staging] fix: FAB is not responsive after exiting create expense flow Feb 14, 2025

nkdengineer and others added 2 commits February 14, 2025 08:39

Update src/libs/Navigation/navigateAfterInteraction/index.ios.ts

f345fc1

Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>

remove unchange

45c347a

mountiny requested a review from dukenv0307 February 14, 2025 01:42

mountiny added the Ready To Build label Feb 14, 2025

nkdengineer marked this pull request as ready for review February 14, 2025 01:52

nkdengineer requested a review from a team as a code owner February 14, 2025 01:52

melvin-bot bot requested review from mountiny and s77rt February 14, 2025 01:52

melvin-bot bot removed the request for review from a team February 14, 2025 01:52

mountiny removed the request for review from s77rt February 14, 2025 02:21

mountiny reviewed Feb 14, 2025

View reviewed changes

mountiny approved these changes Feb 14, 2025

View reviewed changes

mountiny merged commit d2c9a35 into Expensify:main Feb 14, 2025
17 checks passed

OSBotify pushed a commit that referenced this pull request Feb 14, 2025

Merge pull request #56865 from nkdengineer/fix/56796

1db9cf9

[CP Staging] fix: FAB is not responsive after exiting create expense flow (cherry picked from commit d2c9a35) (CP triggered by mountiny)

github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Feb 14, 2025

github-actions bot mentioned this pull request Feb 14, 2025

Deploy Checklist: New Expensify 2025-02-12 #56784

Closed

57 tasks

parasharrajat reviewed Feb 14, 2025

View reviewed changes

zirgulis mentioned this pull request Feb 14, 2025

[Due for payment 2025-02-25] [$125] iOS - Distance - FAB menu appears briefly when closing distance receipt view #56814

Closed

8 tasks

This was referenced Feb 18, 2025

[$250] [Due for payment 2025-02-25] [Navigation] iOS - FAB - FAB is not responsive after exiting create expense flow #56796

Closed

[Due for payment 2025-02-25] iOS - Tooltip - QAB tooltip appears in + button in 1:1 DM #56800

Closed

BartoszGrajdek mentioned this pull request Feb 27, 2025

Invisible view on FAB using refactored modal fix #57536

Merged

49 tasks

blazejkustra mentioned this pull request Feb 20, 2026

[BATCH 3] Migrate Navigation usage v2 #83064

Open

Conversation

nkdengineer commented Feb 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 14, 2025

Uh oh!

melvin-bot bot commented Feb 14, 2025

Uh oh!

github-actions bot commented Feb 14, 2025

Uh oh!

dukenv0307 commented Feb 14, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny Feb 14, 2025

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Feb 14, 2025

Uh oh!

github-actions bot commented Feb 14, 2025

Uh oh!

parasharrajat Feb 14, 2025

Choose a reason for hiding this comment

Uh oh!

adamgrzybowski commented Feb 14, 2025

Uh oh!

mountiny commented Feb 14, 2025

Uh oh!

github-actions bot commented Feb 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nkdengineer commented Feb 14, 2025 •

edited

Loading