Invisible view on FAB using refactored modal fix by BartoszGrajdek · Pull Request #57536 · Expensify/App

BartoszGrajdek · 2025-02-27T10:37:14Z

Explanation of Change

Recently we refactored modal code that was used everywhere across E/App here the goal was to implement it in all bottom docked modals, starting with FAB. After merging the PR we found an issue where if you went through a specific flow there would be an invisible view on top of FAB preventing user from being able to press it, this PR fixes that problem.

Fixed Issues

$ #49354

Tests

This PR affects just the FAB modal on native & mWeb platforms.

I think testing should go like this:

Open the modal.
Close it by clicking the backdrop.
Open the modal.
Close it through the "back" button if it exists on your device.
Open the modal.
Go through each button/option in that modal and verify that everything's functioning properly.

To test the issue I've described in Explanation of Change section follow these steps:

Launch ND or hybrid app.
Tap FAB > Create expense > Manual.
Enter amount > Next.
Tap app back button twice.
Tap FAB.
FAB should be responsive and open up the modal again after step 5.

Offline tests

N/A - nothing should change in this case

QA Steps

Same as in the Tests section

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android.mweb.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios.mweb.mov

MacOS: Chrome / Safari

MacOS: Desktop

…nvisible-view-fix

melvin-bot · 2025-02-27T10:37:19Z

@shawnborton @eh2077 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2025-02-27T10:43:34Z

I suppose this is my PR since this is a fix for this PR which I reviewed
More context here

ZhenjaHorbach · 2025-02-27T10:44:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

web.mov

ZhenjaHorbach · 2025-02-27T11:09:11Z

src/components/Modal/BottomDockedModal/index.tsx

    const [isTransitioning, setIsTransitioning] = useState(false);
    const [deviceWidth, setDeviceWidth] = useState(() => Dimensions.get('window').width);
    const [deviceHeight, setDeviceHeight] = useState(() => Dimensions.get('window').height);
+    const handleRef = useRef<number>();


Interesting fix
And sorry for the stupid question 😅
But could you explain in more detail where the invisible view came from
And how it fixed it?

Sure!

react-native-modal library which this code originates from was originally using InteractionManager, but during my refactor it caused some problems so I removed it, which didn't create any regressions.

The problem was that recently a change was made in E/App here that caused the FAB to rely specifically on the InteractionManager in our modals. Since we didn't have it anymore in the refactored version this caused the issue the QA team has found.

After adding the InteractionManager back I've tested if any of the problems I faced before also appeared, but it seems like they may have been happening due to some other bugs.

Oh
Now I get it
Thanks for the detailed explanation !

ZhenjaHorbach · 2025-02-27T13:11:55Z

LGTM !

mountiny

Thanks for the fix, lets try it out!

OSBotify · 2025-02-27T20:03:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-02-27T21:08:23Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.7-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-03-03T16:45:16Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.7-2 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

ahmedGaber93 · 2025-05-27T21:20:18Z

src/components/Modal/BottomDockedModal/index.tsx

        setIsTransitioning(false);
        setIsContainerOpen(false);
+        if (handleRef.current) {
+            InteractionManager.clearInteractionHandle(handleRef.current);


Coming from #61986, we have a case that clearInteractionHandle not work as expected, and we handled it here #62023

BartoszGrajdek added 2 commits February 27, 2025 11:27

fix: invisible view on FAB

2a35e10

Merge remote-tracking branch 'origin/main' into @BartoszGrajdek/FAB-i…

a9d5a33

…nvisible-view-fix

BartoszGrajdek requested a review from a team as a code owner February 27, 2025 10:37

melvin-bot bot requested review from eh2077 and shawnborton and removed request for a team February 27, 2025 10:37

BartoszGrajdek mentioned this pull request Feb 27, 2025

[UX Reliability] Improve the bottom modal animations quality and reliability on native and mWeb platforms #49354

Closed

ZhenjaHorbach reviewed Feb 27, 2025

View reviewed changes

ZhenjaHorbach approved these changes Feb 27, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny February 27, 2025 13:11

mountiny approved these changes Feb 27, 2025

View reviewed changes

mountiny merged commit f384933 into Expensify:main Feb 27, 2025
17 of 21 checks passed

github-actions bot mentioned this pull request Feb 27, 2025

Deploy Checklist: New Expensify 2025-02-27 #57563

Closed

40 tasks

ahmedGaber93 mentioned this pull request May 14, 2025

[Due for payment 2025-05-27] [$250] android-workflow-Unable to delete approval workflow #61986

Closed

8 tasks

ahmedGaber93 reviewed May 27, 2025

View reviewed changes

Conversation

BartoszGrajdek commented Feb 27, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 27, 2025

Uh oh!

ZhenjaHorbach commented Feb 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Feb 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach Feb 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BartoszGrajdek Feb 27, 2025

Choose a reason for hiding this comment

Uh oh!

BartoszGrajdek Feb 27, 2025

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach Feb 27, 2025

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Feb 27, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Feb 27, 2025

Uh oh!

github-actions bot commented Feb 27, 2025

Uh oh!

github-actions bot commented Mar 3, 2025

Uh oh!

ahmedGaber93 May 27, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ZhenjaHorbach commented Feb 27, 2025 •

edited

Loading

ZhenjaHorbach commented Feb 27, 2025 •

edited

Loading

ZhenjaHorbach Feb 27, 2025 •

edited

Loading