-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Allow users to export report as PDF #57323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
c1774d1
labels
Gonals 1cafa55
Add new params
Gonals 9b5cd8c
new types and whatnot
Gonals c3cce3b
Add button
Gonals 04807e6
typing changes
Gonals 2be5e3e
Add generating modal
Gonals 2ba5438
correctly display modal
Gonals aa05e50
Handle all three cases
Gonals 5ceccea
call export command
Gonals 8b0fda7
create download file
Gonals feafad9
Handle downloads
Gonals 73c1aa6
onyxdata added
Gonals 850cd1b
Correctly show popup
Gonals ac82821
strings
Gonals d56acb2
comments
Gonals b60173f
Add missing constant
Gonals aa83740
prettier
Gonals 9c79870
conflicts
Gonals 85982e1
Add beta
Gonals e0c51ed
hide behind beta
Gonals abb71bc
Merge branch 'main' into alberto-pdfExport
Gonals d637aad
prettier
Gonals 5b33a2f
dependency
Gonals e404c0f
conflicts
Gonals b006893
External download
Gonals 415d36c
prettier
Gonals 55b62d5
beta not needed
Gonals 5c1e043
prettier again
Gonals 89a400d
Add spinner during download
Gonals 1b5dd44
external for chrome too
Gonals 898552d
prettier
Gonals f7583dd
lint
Gonals 7364c43
import? maybe?
Gonals bfbc317
more import changes trying to get the linter happy
Gonals c118979
conflicts
Gonals ef526e3
readd beta just in case
Gonals 29239bf
dependency
Gonals 4b1326a
conflicts
Gonals 9c4a44f
remove external
Gonals 3055c4c
Merge branch 'main' into alberto-pdfExport
Gonals d9864eb
hardcode for testing
Gonals 2264206
try prod
Gonals b2650bb
test with token
Gonals e51b3c8
undo test changes
Gonals b17849c
remove setDownload
Gonals a467244
lint
Gonals 3365a19
test link
Gonals d73748f
undo last change
Gonals 5fe3192
Merge branch 'main' into alberto-pdfExport
Gonals File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| type ExportReportPDFParams = { | ||
| reportID: string; | ||
| }; | ||
|
|
||
| export default ExportReportPDFParams; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can explicitly pass
trueto the 3rd argument when calling this function to treat App downloads as an external link to avoid the CORS issue. More details here #61937 (comment)