Embed media files in New Expensify #admins room tasks

[ZhenjaHorbach]

Explanation of Change

Embed media files in New Expensify #admins room tasks

Fixed Issues

$ #57573
PROPOSAL:

Tests

Test 1

1. Sign up with new account and choose any other option than "Manage my team's expense" in onboarding flow user intent.
2. Create a new workspace
3. In your concierge chat open Invite your team, Add expense approvals, Set up categories or Set up tags task
4. Verify that these tasks contain a video

Test 2

1. Sign up with new account and choose "Manage my team's expense" then 1-10 employers and then Xero
2. In your concierge chat open Connect to Xero
3. Verify that this task contains a video

Test 3

1. Sign up with new account and choose "Manage my team's expense" then 1-10 employers and then QuickBooks Online
2. In your concierge chat open Connect to QuickBooks Online
3. Verify that this task contains a video

Test 4

1. Sign up with new account and choose "Manage my team's expense" then 1-10 employers and then NetSuite
2. In your concierge chat open Connect to NetSuite
3. Verify that this task contains a video

• Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

2025-03-04.09.21.38.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

[melvin-bot]

@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[ZhenjaHorbach]

@alitoshmatov
We have several gesture-handler and DOM attribute errors in console
But these errors are reproduced with any other video
So I'm not sure we should pay attention to this in this PR

[alitoshmatov]

Reviewing

[alitoshmatov]

We have several gesture-handler and DOM attribute errors in console
But these errors are reproduced with any other video

@ZhenjaHorbach Getting this error when scrubbing the video player. Does this also include this error? just making sure

Screen.Recording.2025-03-07.at.7.26.47.AM.mov

[ZhenjaHorbach]

@ZhenjaHorbach Getting this error when scrubbing the video player. Does this also include this error? just making sure

Interesting
I haven't seen this before
Let me check

[ZhenjaHorbach]

@alitoshmatov
Looks like this is a known issue which is difficult to reproduce
And I was able to reproduce it once before the fix
I hope everything is fine now after the fix

[alitoshmatov]

@ZhenjaHorbach I managed to reproduce this in production. I think best course of action is to create new issue for this as it is not related to current PR. I think you should also revert BasePlayerChanges since we don't want to introduce any regressions by trying to tackle this problem in this PR and the changes are not fully effective since it is still reproducible in android mweb.

What do you think?

Production

This is easy to reproduce in mweb (DEV). Also notice that it makes video player unresponsive after couple of errors

Screen.Recording.2025-03-07.at.7.18.55.PM.mov

[alitoshmatov]

Okay. I will try to complete the review in couple of hours

[ZhenjaHorbach]

Okay. I will try to complete the review in couple of hours

Thanks !

[alitoshmatov]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

video-mweb.mov

iOS: Native

video-ios.mp4

iOS: mWeb Safari

video-safari.mp4

MacOS: Chrome / Safari

video-web.mov

MacOS: Desktop

video-desktop.mov

[alitoshmatov]

Changes looks good!

Completed the checklist, android video is missing, having some problem with emulator.

We came across this bug. It is also reproducible in production so decided to treat it in separate issue. Please create a new issue if you agree.

[melvin-bot]

We did not find an internal engineer to review this PR, trying to assign a random engineer to #57573 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

[alitoshmatov]

@mountiny Mentioning you since you commented on corresponding issue but not assigned.

[github-actions]

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

[mountiny]

Changes look good to me, but creating builds and going to ask Design team to double check this

[mountiny]

@alitoshmatov @ZhenjaHorbach can you please raise the bug you found in the bugs channel?

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/57648/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/57648/index.html
Android Hybrid 🤖🔄	iOS Hybrid 🍎🔄
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Android Hybrid build failed	The QR code can't be generated, because the iOS Hybrid build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/57648/NewExpensify.dmg	https://57648.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[ZhenjaHorbach]

@alitoshmatov @ZhenjaHorbach can you please raise the bug you found in the bugs channel?

No problem
I can do it on the weekend or on Monday morning !

[mountiny]

@Expensify/design Can you please check these builds and verify it all looks as you would like to before merging? thank you!

[shawnborton]

The videos look great to me, nice job on these!

The only thing that stood out to me was that I was a little surprised that the negative space around the video used our cardBG color rather than just using our lightest background color:

I think I would expect the space around the video to just use our standard BG color. I recognize that it might already work this way and it might be separate from this PR, but figured I'd call it out. cc @Expensify/design for the gut check.

[ZhenjaHorbach]

I think I would expect the space around the video to just use our standard BG color. I recognize that it might already work this way and it might be separate from this PR, but figured I'd call it out. cc @Expensify/design for the gut check.

If needed, I can fix this in this PR 😀
But yes, I agree that it's better to fix it in a separate issue !

[mountiny]

Thanks for the review, I agree that would be a separate issue as its not tied to this PR. Going to move this ahead so we can test it in staging on couple of hours. Thanks!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[dannymcclain]

I think I would expect the space around the video to just use our standard BG color. I recognize that it might already work this way and it might be separate from this PR, but figured I'd call it out. cc @Expensify/design for the gut check.

Yeah I agree. Not a super big deal, but our regular attachment modal uses app-background (standard background color). I will note that I just tested a regular video in my selfDM and it matches what's shown above. So this is definitely not specific to this PR, just something we need to update with the video player implementation in general.

[shawnborton]

Cool, I'll file a separate bug for that - thanks for hearing me out!

[github-actions]

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.11-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

[github-actions]

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.12-7 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌