[CP STAGING] Add defensive check for signupQualifier in OnboardingFlow by Shahidullah-Muffakir · Pull Request #57794 · Expensify/App

Shahidullah-Muffakir · 2025-03-04T22:25:32Z

Explanation of Change

Fixed Issues

$#57786
PROPOSAL: #57786 (comment)

Tests

Sign up for a new account.
Reach the "What do you want to do today?" step.
Select each onboarding option one by one and complete the flow:
- Track and budget expenses
- Manage my team's expenses
- Get paid back by my employer
- Chat and split expenses with friends
- Something else
Ensure onboarding completes successfully for each selection.
Verify that the app does not crash or throw errors.

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as Tests Steps.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

ios.20native-5.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-03-04T22:25:37Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Shahidullah-Muffakir · 2025-03-04T23:03:23Z

The Type error will be fixed by this PR, not related to the changes of the current PR.

github-actions · 2025-03-05T01:03:20Z

🚧 @Julesssss has triggered a test hybrid app build. You can view the workflow run here.

Julesssss · 2025-03-05T01:11:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

trjExpensify · 2025-03-05T01:11:41Z

Ready to test the adhoc build.

github-actions · 2025-03-05T01:31:17Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/57794/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/57794/index.html

Android Hybrid 🤖🔄	iOS Hybrid 🍎🔄
N/A	N/A
N/A	N/A
Desktop 💻	Web 🕸️
N/A	N/A
N/A	N/A

👀 View the workflow run that generated this build 👀

trjExpensify · 2025-03-05T01:43:35Z

Confirmed in thread the crash is resolved on that Adhoc build.

Julesssss · 2025-03-05T02:27:59Z

Ignoring the UNRELATED file lint error

melvin-bot · 2025-03-05T02:28:10Z

@Julesssss looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

Julesssss · 2025-03-05T02:30:35Z

Requested CP here, build in progress

…ing-signupQualifier-null-check Add defensive check for signupQualifier in OnboardingFlow (cherry picked from commit cd7ac04) (CP triggered by Julesssss)

github-actions · 2025-03-05T03:08:55Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.1.9-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2025-03-06T22:56:48Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.9-8 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

Add defensive check for signupQualifier in OnboardingFlow

d7dca3d

Shahidullah-Muffakir requested a review from a team as a code owner March 4, 2025 22:25

melvin-bot bot requested review from Pujan92 and removed request for a team March 4, 2025 22:25

Julesssss added the Ready To Build label Mar 5, 2025

Julesssss approved these changes Mar 5, 2025

View reviewed changes

Julesssss removed the request for review from Pujan92 March 5, 2025 01:09

Julesssss merged commit cd7ac04 into Expensify:main Mar 5, 2025
15 of 18 checks passed

melvin-bot bot added the Emergency label Mar 5, 2025

Julesssss added CP Staging marks PRs that have been CP'd to staging and removed Emergency labels Mar 5, 2025

Julesssss changed the title ~~Add defensive check for signupQualifier in OnboardingFlow~~ [CP STAGING] Add defensive check for signupQualifier in OnboardingFlow Mar 5, 2025

github-actions bot mentioned this pull request Mar 5, 2025

Deploy Checklist: New Expensify 2025-03-04 #57792

Closed

77 tasks

melvin-bot bot mentioned this pull request Mar 6, 2025

[Due for payment 2025-03-17][$250] iOS - TypeError: TaskQueue: Error with task : Cannot read property 'signupQualifier' of undefined #57786

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP STAGING] Add defensive check for signupQualifier in OnboardingFlow#57794

[CP STAGING] Add defensive check for signupQualifier in OnboardingFlow#57794
Julesssss merged 1 commit intoExpensify:mainfrom
Shahidullah-Muffakir:fix/57786-onboarding-signupQualifier-null-check

Shahidullah-Muffakir commented Mar 4, 2025 •

edited

Loading

Uh oh!

melvin-bot bot commented Mar 4, 2025

Uh oh!

Shahidullah-Muffakir commented Mar 4, 2025

Uh oh!

github-actions bot commented Mar 5, 2025

Uh oh!

Julesssss commented Mar 5, 2025 •

edited

Loading

Uh oh!

trjExpensify commented Mar 5, 2025

Uh oh!

github-actions bot commented Mar 5, 2025

Uh oh!

trjExpensify commented Mar 5, 2025

Uh oh!

Julesssss commented Mar 5, 2025

Uh oh!

Uh oh!

melvin-bot bot commented Mar 5, 2025

Uh oh!

Julesssss commented Mar 5, 2025

Uh oh!

github-actions bot commented Mar 5, 2025

Uh oh!

github-actions bot commented Mar 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Shahidullah-Muffakir commented Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 4, 2025

Uh oh!

Shahidullah-Muffakir commented Mar 4, 2025

Uh oh!

github-actions bot commented Mar 5, 2025

Uh oh!

Julesssss commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

trjExpensify commented Mar 5, 2025

Uh oh!

github-actions bot commented Mar 5, 2025

Uh oh!

trjExpensify commented Mar 5, 2025

Uh oh!

Julesssss commented Mar 5, 2025

Uh oh!

Uh oh!

melvin-bot bot commented Mar 5, 2025

Uh oh!

Julesssss commented Mar 5, 2025

Uh oh!

github-actions bot commented Mar 5, 2025

Uh oh!

github-actions bot commented Mar 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Shahidullah-Muffakir commented Mar 4, 2025 •

edited

Loading

Julesssss commented Mar 5, 2025 •

edited

Loading