Feature: Add moveIOUReportToPolicy by waterim · Pull Request #58078 · Expensify/App

waterim · 2025-03-10T09:54:12Z

Details

Fixed Issues

$ #57470
PROPOSAL: N/A

Tests

Pre-requisite: a workspace with an admin and employee

[employee] Request money (IOU) from admin
[employee] Open the IOU report copy the URL, add /change-workspace to the end of it and send it as a message to the report
[employee] Click the URL to open the Change Workspace RHP
Move the IOU report to the workspace the employee is a member of
Verify that the IOU report was converted to an Expense report
Verify that the report preview was removed from the DM and added to the user's workspace chat

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

None

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

…OUReportToPolicy

melvin-bot · 2025-03-12T07:24:38Z

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/API/parameters/MoveIOUReportToPolicyParams.ts

src/libs/actions/Report.ts

ikevin127 · 2025-03-13T20:18:26Z

@luacmartins How do we go about testing this type of PRs of new functions that are not actually used in the app yet, how do we verify that they comply with the doc specs other than reading the code and assuming ?

luacmartins · 2025-03-13T20:21:38Z

Ideally, we wait for the backend PR to be available so we can test it end to end.

luacmartins · 2025-03-14T21:18:30Z

Waiting on @waterim to address comments

waterim · 2025-03-14T21:25:37Z

Will address asap!

luacmartins · 2025-03-17T20:14:23Z

Waiting on comments to be addressed!

waterim · 2025-03-17T20:37:42Z

@luacmartins updated!

waterim · 2025-03-17T20:38:05Z

fixing conflicts now

…OUReportToPolicy

waterim · 2025-03-17T20:51:09Z

@luacmartins Ready for a review!

luacmartins · 2025-03-19T21:51:22Z

@ikevin127 let's prioritize reviewing this one please when you're online please!

waterim · 2025-03-24T15:59:01Z

@luacmartins updated!

luacmartins

Left one comment. Additionally, I think we'll have to address the CHANGE_POLICY action in a follow up. Currently, the admin doesn't have access to the employee's personal policy, so the message returns the policyID instead of the policyName

src/pages/ReportChangeWorkspacePage.tsx

luacmartins · 2025-03-24T23:26:13Z

@ikevin127 let's review this one! Hopefully we can get it merged tomorrow.

…OUReportToPolicy

luacmartins

Left a few more comments. Additionally, I think we have a BE bug that's not correctly moving the report preview to the employee's workspace chat. I'll investigate

src/libs/actions/Report.ts

luacmartins · 2025-03-25T16:07:34Z

Additionally, I think we have a BE bug that's not correctly moving the report preview to the employee's workspace chat. I'll investigate

I found the bug and have a PR in review.

src/libs/actions/Report.ts

…OUReportToPolicy

ikevin127 · 2025-03-25T18:26:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web	Web w/ Cache reset
web.mov	web-cache-reset.mov

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

ikevin127

LGTM 🚀

I tested again and even cleared cache & reset (see videos), I think this is ready to merge!

OSBotify · 2025-03-25T21:25:44Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-26T06:13:21Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.1.19-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

izarutskaya · 2025-03-26T06:34:57Z

@waterim Do we need QA steps for this?

izarutskaya · 2025-03-27T09:14:38Z

@waterim Tester facing with issue #58431 on Web.

1743056722270.58078_-_web.mp4

izarutskaya · 2025-03-27T10:20:46Z

@waterim also QA team facing with issue #59210

github-actions · 2025-03-27T13:30:30Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.1.19-5 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

dukenv0307 · 2025-06-30T03:34:10Z

src/libs/actions/Report.ts

+    });
+
+    // We need to move the report preview action from the DM to the workspace chat.
+    const parentReportActions = allReportActions?.[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${iouReport.parentReportID}`];


Coming from: #64459. We shouldn't add the reportAction prefix when getting data from allReportActions

Pujan92 · 2025-07-31T12:49:47Z

src/libs/actions/Report.ts

+        return;
+    }
+    // We do not want to create negative amount expenses
+    if (ReportActionsUtils.hasRequestFromCurrentAccount(iouReport.reportID, iouReport.managerID ?? CONST.DEFAULT_NUMBER_ID)) {


We should filter out the deleted transactions to derive hasRequestFromCurrentAccount as it caused an issue #65323

rojiphil · 2025-11-17T05:18:08Z

src/libs/PolicyUtils.ts

 }

+function isPolicyMember(currentUserLogin: string | undefined, policyID: string | undefined): boolean {
+    return !!currentUserLogin && !!policyID && !!allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${policyID}`]?.employeeList?.[currentUserLogin];


NAB but we improved the function with additional check for policy owner to determine if the user is a policy member. This would help in cases where employeeList is not available as observed in #69320

waterim added 2 commits March 10, 2025 17:07

add new write param type

8fae633

create new moveIOUReportToPolicy function

bd88ffd

waterim changed the title ~~Feature/57470 move iou report to policy~~ Feature: Add moveIOUReportToPolicy Mar 10, 2025

waterim added 2 commits March 10, 2025 18:24

fix linter

b81a9f1

Merge remote-tracking branch 'upstream/main' into feature/57470-MoveI…

77ba24d

…OUReportToPolicy

luacmartins self-requested a review March 10, 2025 13:55

Merge remote-tracking branch 'upstream/main' into feature/57470-MoveI…

55bf9e5

…OUReportToPolicy

waterim marked this pull request as ready for review March 12, 2025 07:24

waterim requested a review from a team as a code owner March 12, 2025 07:24

melvin-bot bot requested a review from ikevin127 March 12, 2025 07:24

melvin-bot bot removed the request for review from a team March 12, 2025 07:24

luacmartins requested changes Mar 12, 2025

View reviewed changes

waterim added 3 commits March 17, 2025 21:36

add new buildOptimisticChangePolicyReportAction

88f1e1f

update types

b5af8b4

update function with a feedback

5b5e03f

waterim added 2 commits March 17, 2025 21:50

Merge remote-tracking branch 'upstream/main' into feature/57470-MoveI…

c937c07

…OUReportToPolicy

add autimatic action

bab22b7

waterim requested a review from luacmartins March 17, 2025 20:51

fix linter

f1cd698

ikevin127 mentioned this pull request Mar 18, 2025

[No QA] Implement MoveIOUReportToPolicyAndInviteSubmitter #58337

Merged

50 tasks

update to expense chat report id

2af66a9

luacmartins self-requested a review March 24, 2025 17:03

luacmartins requested changes Mar 24, 2025

View reviewed changes

src/pages/ReportChangeWorkspacePage.tsx Show resolved Hide resolved

waterim added 2 commits March 25, 2025 10:53

update condition on changeWorkspace

ae87c15

Merge remote-tracking branch 'upstream/main' into feature/57470-MoveI…

e9f1c2a

…OUReportToPolicy

luacmartins requested changes Mar 25, 2025

View reviewed changes

src/libs/actions/Report.ts Outdated Show resolved Hide resolved

src/libs/actions/Report.ts Outdated Show resolved Hide resolved

src/libs/actions/Report.ts Outdated Show resolved Hide resolved

src/libs/actions/Report.ts Outdated Show resolved Hide resolved

luacmartins assigned waterim Mar 25, 2025

luacmartins reviewed Mar 25, 2025

View reviewed changes

src/libs/actions/Report.ts Show resolved Hide resolved

waterim added 2 commits March 25, 2025 19:04

update names and add timestamp

fe04e0e

Merge remote-tracking branch 'upstream/main' into feature/57470-MoveI…

a6043e5

…OUReportToPolicy

clear iouReportID

dbf14a4

ikevin127 approved these changes Mar 25, 2025

View reviewed changes

melvin-bot bot requested a review from luacmartins March 25, 2025 20:01

luacmartins approved these changes Mar 25, 2025

View reviewed changes

luacmartins merged commit 60a5f3e into Expensify:main Mar 25, 2025
18 checks passed

github-actions bot mentioned this pull request Mar 26, 2025

Deploy Checklist: New Expensify 2025-03-26 #59127

Closed

50 tasks

izarutskaya mentioned this pull request Mar 27, 2025

[Due for payment 2025-04-17] IOU - After moving IOU the status in expense details is inconsistent on the Admin side #59210

Closed

8 tasks

dukenv0307 reviewed Jun 30, 2025

View reviewed changes

Pujan92 reviewed Jul 31, 2025

View reviewed changes

rojiphil reviewed Nov 17, 2025

View reviewed changes

Conversation

waterim commented Mar 10, 2025 • edited by luacmartins Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Uh oh!

melvin-bot bot commented Mar 12, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ikevin127 commented Mar 13, 2025

Uh oh!

luacmartins commented Mar 13, 2025

Uh oh!

luacmartins commented Mar 14, 2025

Uh oh!

waterim commented Mar 14, 2025

Uh oh!

luacmartins commented Mar 17, 2025

Uh oh!

waterim commented Mar 17, 2025

Uh oh!

waterim commented Mar 17, 2025

Uh oh!

waterim commented Mar 17, 2025

Uh oh!

luacmartins commented Mar 19, 2025

Uh oh!

waterim commented Mar 24, 2025

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

luacmartins commented Mar 24, 2025

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

luacmartins commented Mar 25, 2025

Uh oh!

Uh oh!

ikevin127 commented Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ikevin127 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Mar 25, 2025

Uh oh!

github-actions bot commented Mar 26, 2025

Uh oh!

izarutskaya commented Mar 26, 2025

Uh oh!

izarutskaya commented Mar 27, 2025

Uh oh!

izarutskaya commented Mar 27, 2025

Uh oh!

github-actions bot commented Mar 27, 2025

Uh oh!

dukenv0307 Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

Pujan92 Jul 31, 2025

waterim commented Mar 10, 2025 •

edited by luacmartins

Loading

ikevin127 commented Mar 25, 2025 •

edited

Loading