fix: title image rendering in task preview and task view. by Krishna2323 · Pull Request #58555 · Expensify/App

Krishna2323 · 2025-03-17T13:23:37Z

Explanation of Change

Fixed Issues

$ #58194
$ #58192
$ #58181
$ #58269
PROPOSAL: NA

Tests

Go to chat.
Click + > Assign task.
Click Title.
Enter the following inline image mark down:

[![300](https://picsum.photos/id/1067/200/300)](https://camo.githubusercontent.com/4848d0f965f332077b77a1a0488c3e66b4769032104f4de6890bae218b4add8d/68747470733a2f2f70696373756d2e70686f746f732f69642f313036372f3230302f333030)

Save the title > verify image is not shown on the confirmation page > create the task.
Verify image is not shown on the image in the task preview instead link is rendered.
Open the task view > Verify link is rendered instead of the image.

Test 2

Go to any chat.
Create a task with multiline title.
Open search router on the top right.
Verify the task report is displayed with single line title

Test 3

Go to staging.new.expensify.com
Go to chat.
Click + > Assign task.
Click Title.
Enter the following multiline content with markdown:

[long link name](https://github.com/Expensify/App/issues/google.com)
inline code

Save the title and create the task.
Click on the task preview.
Verify code block does not overlap link

Test 4

Select the following options during onboarding:
“Manage my team’s expenses”
“1-10 employees”
“None”
Complete the onboarding flow & validate the account (login again using magic code in mweb)
Login in with same account in android app
Open the Concierge chat
Tap on any task in the chat
Observe that the task name remains same while navigating

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests
Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_native.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

…ist. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

… report. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot · 2025-03-17T13:42:12Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2025-03-17T14:50:31Z

@Expensify/design, please confirm if this looks fine or not, specially the image rendering and the gap between link and code block.

Monosnap.screencast.2025-03-17.20-17-44.mp4

shawnborton · 2025-03-17T14:53:04Z

Hmm I feel like we don't want to support the image markdown anywhere - not in the title, not in the edit title screen, nor in the system message. It feels weird to show it in one place but not the other. Can we just remove it from all of those cases I just cited?

Unrelated, why does this report header have three lines?

dannymcclain · 2025-03-17T15:04:14Z

Hmm I feel like we don't want to support the image markdown anywhere - not in the title, not in the edit title screen, nor in the system message. It feels weird to show it in one place but not the other. Can we just remove it from all of those cases I just cited?

Totally agree.

Krishna2323 · 2025-03-17T15:28:27Z

@mananjadhav, do you know how to disable image rendering in Markdown input? I'm really struggling with that. 🥴

mananjadhav · 2025-03-17T17:07:27Z

@mananjadhav, do you know how to disable image rendering in Markdown input? I'm really struggling with that. 🥴

I'll also have to check it. I think the way it'll need to be done is override the parser property. Following is an untested code:

const filterImages = (input) => {
   "worklet";
   
   const ranges = parseExpensifyMark(input);
   return ranges.filter(range => range.type !== 'inline-image');
}

Can you try this and also may be post on expensify-open-source?

Meanwhile can we skip the image part in this PR and focus on the ones we can solve?

Krishna2323 · 2025-03-17T17:12:44Z

@mananjadhav thanks, I'll try that. We can leave image rendering issue on inputs. This PR covers the image rendering in task preview, task view title, task confirmation page and task title update system message.

focus on the ones we can solve?

Other linked issues in this PR are solved.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

mananjadhav · 2025-03-17T19:37:02Z

src/components/ReportActionItem/TaskView.tsx

        setTaskReport(report);
    }, [report]);
-    const taskTitle = `<task-title>${convertToLTR(report?.reportName ?? '')}</task-title>`;
+    const htmlWithoutImage = Parser.replace(Parser.htmlToMarkdown(report?.reportName ?? ''), {disabledRules: ['image']});


htmlWithoutImage is pretty generic name. Can we name it as titleWithoutImage?

mananjadhav · 2025-03-17T19:37:33Z

src/components/Search/SearchRouter/SearchRouter.tsx

                    data: [
                        {
-                            text: `${translate('search.searchIn')} ${reportForContextualSearch.text ?? reportForContextualSearch.alternateText}`,
+                            text: StringUtils.lineBreaksToSpaces(`${translate('search.searchIn')} ${reportForContextualSearch.text ?? reportForContextualSearch.alternateText}`),


Why is this needed?

To fix this issue where search router was displaying task reports with multiline title. Task - Task with multiline title is not displayed correctly in search list #58192

mananjadhav · 2025-03-17T19:38:02Z

src/libs/ReportUtils.ts

 * For longer comments, skip parsing, but still escape the text, and display plaintext for performance reasons. It takes over 40s to parse a 100k long string!!
 */
-function getParsedComment(text: string, parsingDetails?: ParsingDetails, mediaAttributes?: Record<string, string>): string {
+function getParsedComment(text: string, parsingDetails?: ParsingDetails, mediaAttributes?: Record<string, string>, isTaskAction?: boolean): string {


how about instead we pass disabledRules param?

mananjadhav · 2025-03-17T19:39:10Z

src/styles/utils/index.ts

    }
    if (isInsideTaskTitle) {
-        return 19;
+        return 18;


@Expensify/design can you confirm the value?

mananjadhav · 2025-03-17T19:39:23Z

src/styles/utils/textDecorationLine.ts

        textDecorationStyle: 'solid',
    },
+    underlineLine: {
+        textDecorationLine: 'underline',


What's this for?

removed, this will be needed in a different PR related to regressions.

mananjadhav

Some clarifications and refactor comments.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

mananjadhav · 2025-03-18T01:22:19Z

src/components/ReportActionItem/TaskPreview.tsx

    const [taskReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${taskReportID}`);
+    const taskTitle = taskReport?.reportName ?? action?.childReportName ?? '';
+
+    const taskTitleWithoutImage = Parser.replace(Parser.htmlToMarkdown(taskTitle), {disabledRules: ['image']});


Why not use the CONST here?

mananjadhav · 2025-03-18T01:22:37Z

src/components/ReportActionItem/TaskView.tsx

        setTaskReport(report);
    }, [report]);
-    const taskTitle = `<task-title>${convertToLTR(report?.reportName ?? '')}</task-title>`;
+    const titleWithoutImage = Parser.replace(Parser.htmlToMarkdown(report?.reportName ?? ''), {disabledRules: ['image']});


Same use the defined CONST?

mananjadhav · 2025-03-18T01:23:24Z

src/libs/ReportUtils.ts

 * For longer comments, skip parsing, but still escape the text, and display plaintext for performance reasons. It takes over 40s to parse a 100k long string!!
 */
-function getParsedComment(text: string, parsingDetails?: ParsingDetails, mediaAttributes?: Record<string, string>): string {
+function getParsedComment(text: string, parsingDetails?: ParsingDetails, mediaAttributes?: Record<string, string>, disabledRules?: string[]): string {


Can these by better typed? Say disabledRules?: MarkdownType[] ?

MarkdownType[] is has different properties, it does not have image.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2025-03-18T12:38:53Z

I removed the fix for [$50] Chat - Bold markdown is not applied for url #58349, will fix that in this PR.

Krishna2323 · 2025-03-19T11:27:50Z

@mananjadhav, could you please review this last time? I think we are almost ready to merge this one.

mananjadhav · 2025-03-19T12:00:35Z

I did the review. I need to test this. Will be doing that today.

mananjadhav · 2025-03-21T19:16:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-task-title-fixes-1.mov

android-task-title-fallback.mov

Android: mWeb Chrome

mweb-chrome-task-title-fixes-1.mov

iOS: Native

ios-task-title-fixes-1.mov

iOS: mWeb Safari

mweb-safari-task-title-fixes-1.mov

MacOS: Chrome / Safari

web-task-title-fixes-1.mov

MacOS: Desktop

desktop-task-title-fixes-1.mov

mananjadhav · 2025-03-23T17:37:05Z

@Expensify/design Any comments on these updates

dubielzyk-expensify · 2025-03-24T03:53:58Z

Hmm. I would expect us to not render the image or the markdown text. I'd expect us to only show the link and the linked text, but not the full url and markdown bit if that makes sense.

cc @Expensify/design for gut check here

dannymcclain · 2025-03-24T13:22:03Z

Hmm. I would expect us to not render the image or the markdown text. I'd expect us to only show the link and the linked text, but not the full url and markdown bit if that makes sense.

Can you explain a bit more? I'm not sure I'm following.

dubielzyk-expensify · 2025-03-24T23:58:11Z

I would expect the title of the task in the image, and everywhere, to say [Attachment] like it does in the header and only show the full markup syntax when you go in to edit the title.

mananjadhav · 2025-03-25T13:20:00Z

Team, while the image rendering is being discussed, I was wondering if we could merge this and images can be a follow up. I've got 2 other PRs blocked by this one that also needs to be merged. What does everyone think?

shawnborton · 2025-03-25T13:24:27Z

I'm cool with that personally.

dannymcclain · 2025-03-25T13:43:20Z

Same here - fine by me!

dubielzyk-expensify · 2025-03-26T02:38:37Z

As long as we do a follow-up that's fine with me as well 👍

OSBotify · 2025-03-26T10:03:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-27T14:07:23Z

🚀 Deployed to staging by https://github.com/nkuoch in version: 9.1.20-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-03-31T10:05:46Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.20-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

Krishna2323 added 4 commits March 17, 2025 18:48

fix: title image rendering in task preview and task view.

a688258

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

fix: Task with multiline title is not displayed correctly in search l…

30d2bbe

…ist. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

fix: Task - Hyperlink underline is blocked by inline code in the task…

69cde61

… report. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

fix: Chat - Bold markdown is not applied for url.

3c5588c

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 marked this pull request as ready for review March 17, 2025 13:42

Krishna2323 requested review from a team as code owners March 17, 2025 13:42

melvin-bot bot requested review from mananjadhav and removed request for a team March 17, 2025 13:42

Krishna2323 added 2 commits March 17, 2025 19:56

fix image rendering in task confirmation page.

d677123

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

minor udpate.

c57b5be

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

disable image rule for task title.

8f8ad34

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

mananjadhav reviewed Mar 17, 2025

View reviewed changes

src/styles/utils/index.ts

}

if (isInsideTaskTitle) {

return 19;

return 18;

Copy link

Collaborator

mananjadhav Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Expensify/design can you confirm the value?

mananjadhav reviewed Mar 17, 2025

View reviewed changes

Krishna2323 added 2 commits March 18, 2025 03:44

minor updates.

e48320e

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

pass disabled rules to getParsedComment.

f04b73d

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

mananjadhav reviewed Mar 18, 2025

View reviewed changes

remove bold link fix.

726c35b

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

mananjadhav approved these changes Mar 23, 2025

View reviewed changes

melvin-bot bot requested a review from nkuoch March 23, 2025 17:37

mananjadhav mentioned this pull request Mar 24, 2025

fix: Completed task does not show strikethrough style. #58629

Merged

49 tasks

nkuoch approved these changes Mar 26, 2025

View reviewed changes

nkuoch merged commit 469310e into Expensify:main Mar 26, 2025
18 checks passed

github-actions bot mentioned this pull request Mar 27, 2025

Deploy Checklist: New Expensify 2025-03-27 #59215

Closed

45 tasks

CortneyOfstad mentioned this pull request Mar 28, 2025

[Due for payment 2025-04-07] Task - Task with multiline title is not displayed correctly in search list #58192

Closed

8 tasks

alexpensify mentioned this pull request Mar 28, 2025

[Due for payment 2025-04-23] Onboarding - Completed task does not show strikethrough style #58265

Closed

8 tasks

ghost mentioned this pull request Mar 29, 2025

[$125] Android - Expense - Total amount is cut off in the expense report #58205

Closed

8 tasks

This was referenced Mar 31, 2025

[Due for payment 2025-04-07] Task - Not here page opens when inline image preview is opened in the task report #58194

Closed

[Due for payment 2025-04-07] Web - Task - Hyperlink underline is blocked by inline code in the task report #58181

Closed

melvin-bot bot mentioned this pull request Mar 31, 2025

[Due for payment 2025-04-07] Android - Onboarding - Task name briefly changes to "Chat Report" in Concierge chat #58269

Closed

8 tasks

mkzie2 mentioned this pull request Apr 1, 2025

mWeb - When entering multi-line url text with emoji the vertical space down the emoji is blank #59416

Closed

8 tasks

MobileMage mentioned this pull request Jul 2, 2025

[HOLD #62848][$250] Unnecessary word splitting and line breaks after links in chat #65143

Closed

16 tasks

Conversation

Krishna2323 commented Mar 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Test 2

Test 3

Test 4

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 17, 2025

Uh oh!

Krishna2323 commented Mar 17, 2025

Uh oh!

shawnborton commented Mar 17, 2025

Uh oh!

dannymcclain commented Mar 17, 2025

Uh oh!

Krishna2323 commented Mar 17, 2025

Uh oh!

mananjadhav commented Mar 17, 2025

Uh oh!

Krishna2323 commented Mar 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mananjadhav left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Krishna2323 commented Mar 18, 2025

Uh oh!

Krishna2323 commented Mar 19, 2025

Uh oh!

mananjadhav commented Mar 19, 2025

Uh oh!

mananjadhav commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mananjadhav commented Mar 23, 2025

Uh oh!

dubielzyk-expensify commented Mar 24, 2025

Uh oh!

dannymcclain commented Mar 24, 2025

Uh oh!

dubielzyk-expensify commented Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mananjadhav commented Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shawnborton commented Mar 25, 2025

Krishna2323 commented Mar 17, 2025 •

edited

Loading

Krishna2323 commented Mar 17, 2025 •

edited

Loading

mananjadhav commented Mar 21, 2025 •

edited

Loading

dubielzyk-expensify commented Mar 24, 2025 •

edited

Loading

mananjadhav commented Mar 25, 2025 •

edited

Loading