Skip to content

[CP Staging] Revert "fix: Tapping an item from recent list directs blank page in mWeb & LHN in Android briefly"#58754

Merged
luacmartins merged 1 commit intomainfrom
revert-58083-fix/57293
Mar 19, 2025
Merged

[CP Staging] Revert "fix: Tapping an item from recent list directs blank page in mWeb & LHN in Android briefly"#58754
luacmartins merged 1 commit intomainfrom
revert-58083-fix/57293

Conversation

@luacmartins
Copy link
Contributor

@luacmartins luacmartins commented Mar 19, 2025

Reverts #58083

Fixed issues

$ #58742
$ #58726

@luacmartins luacmartins self-assigned this Mar 19, 2025
@luacmartins luacmartins marked this pull request as ready for review March 19, 2025 17:59
@luacmartins luacmartins requested a review from a team as a code owner March 19, 2025 17:59
@melvin-bot melvin-bot bot removed the request for review from a team March 19, 2025 17:59
@melvin-bot
Copy link

melvin-bot bot commented Mar 19, 2025

@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@MarioExpensify
Copy link
Contributor

Merging (straight revert).

@luacmartins luacmartins merged commit b2deda0 into main Mar 19, 2025
14 of 16 checks passed
@luacmartins luacmartins deleted the revert-58083-fix/57293 branch March 19, 2025 18:03
@luacmartins
Copy link
Contributor Author

Straight revert

@melvin-bot melvin-bot bot added the Emergency label Mar 19, 2025
@melvin-bot
Copy link

melvin-bot bot commented Mar 19, 2025

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify pushed a commit that referenced this pull request Mar 19, 2025
Revert "fix: Tapping an item from recent list directs blank page in mWeb & LHN in Android briefly"

(cherry picked from commit b2deda0)

(CP triggered by luacmartins)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Mar 19, 2025
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.1.15-5 🚀

platform result
🤖 android 🤖 cancelled 🔪
🖥 desktop 🖥 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 cancelled 🔪
🍎🔄 iOS HybridApp 🍎🔄 cancelled 🔪

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@luacmartins luacmartins changed the title Revert "fix: Tapping an item from recent list directs blank page in mWeb & LHN in Android briefly" [CP Staging] Revert "fix: Tapping an item from recent list directs blank page in mWeb & LHN in Android briefly" Mar 19, 2025
@github-actions
Copy link
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.15-9 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants