fix: Tapping an item from recent list directs blank page in mWeb & LHN in Android briefly by daledah · Pull Request #58083 · Expensify/App

daledah · 2025-03-10T11:04:22Z

Explanation of Change

Fixed Issues

$ #57293
PROPOSAL: #57293 (comment)

Tests

Open search router
Press on a report
Verify that: Tapping a report will open that report with no blank page

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open search router
Press on a report
Verify that: Tapping a report will open that report with no blank page

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-03-10.at.20.42.50.mov

Android: mWeb Chrome

Screen.Recording.2025-03-11.at.14.37.50.mov

iOS: Native

Screen.Recording.2025-03-10.at.21.12.59.mov

iOS: mWeb Safari

Screen.Recording.2025-03-11.at.14.38.05.mov

MacOS: Chrome / Safari

Screen.Recording.2025-03-10.at.21.11.46.mov

MacOS: Desktop

Screen.Recording.2025-03-10.at.21.15.52.mov

…N in Android briefly

melvin-bot · 2025-03-11T08:35:17Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins

LGTM. Left one comment

luacmartins · 2025-03-11T19:04:16Z

src/components/Search/SearchRouter/SearchRouter.tsx

-                        navigateToAndOpenReport(item.login ? [item.login] : [], false);
-                    }
-                });
+                if (item?.reportID) {


@DylanDylann Let's retest this PR to make sure we don't cause a regression

@luacmartins I see that this PR just got C+ reviewed and it should fix all issues similar to what this PR fixed, so IMO we can wait until that PR is merged and retest.

@daledah Is there any problem if we keep KeyboardUtils.dismiss() function?

so IMO we can wait until that PR is merged and retest.

Sounds good

luacmartins · 2025-03-14T15:31:32Z

@DylanDylann holding PR is merged. Let's continue with the review.

DylanDylann · 2025-03-17T07:05:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-03-17.at.14.08.20.mov

Android: mWeb Chrome

Screen.Recording.2025-03-17.at.14.00.06.mov

iOS: Native

Screen.Recording.2025-03-17.at.14.05.52.mov

iOS: mWeb Safari

Screen.Recording.2025-03-17.at.14.00.32.mov

MacOS: Chrome / Safari

Screen.Recording.2025-03-17.at.14.01.19.mov

MacOS: Desktop

daledah · 2025-03-17T07:08:58Z

I tested and looks like the bug fixed in this PR is gone with current change.

Screen.Recording.2025-03-17.at.14.06.53.mov

DylanDylann

LGTM

luacmartins

LGTM

OSBotify · 2025-03-17T17:30:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-18T22:19:28Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.1.15-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

luacmartins · 2025-03-19T18:07:05Z

@daledah @DylanDylann we reverted this PR because it caused two blockers. @daledah please work on a new PR taking those into account:

[Due for payment 2025-04-14] Search - Unable to perform search via CMD+K #58726
[Due for payment 2025-04-14] [Due for payment 2025-03-27] [$250] mWeb - Search - User is navigated to a chat instead of Reports, when triggering a search #58742

daledah · 2025-03-19T18:08:10Z

@luacmartins It's late in my timezone already, so I'll investigate and open a new PR in the following day.

github-actions · 2025-03-20T15:17:17Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.15-9 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

daledah added 4 commits March 10, 2025 18:01

fix: Tapping an item from recent list directs blank page in mWeb & LH…

142d522

…N in Android briefly

fix: change delay logics

713491f

fix: keyboard not dismissed in mweb

5c3ebfe

fix: lint

5ff31c8

daledah marked this pull request as ready for review March 11, 2025 08:35

daledah requested a review from a team as a code owner March 11, 2025 08:35

melvin-bot bot requested a review from DylanDylann March 11, 2025 08:35

melvin-bot bot removed the request for review from a team March 11, 2025 08:35

daledah mentioned this pull request Mar 11, 2025

[Due for payment 2025-04-14] [$250] Search - Tapping an item from recent list directs blank page in mWeb & LHN in Android briefly #57293

Closed

8 tasks

luacmartins self-requested a review March 11, 2025 14:53

luacmartins approved these changes Mar 11, 2025

View reviewed changes

luacmartins changed the title ~~fix: Tapping an item from recent list directs blank page in mWeb & LHN in Android briefly~~ [HOLD 57580] fix: Tapping an item from recent list directs blank page in mWeb & LHN in Android briefly Mar 14, 2025

luacmartins mentioned this pull request Mar 14, 2025

Bump react-native-keyboard-controller to 1.16.7 #57580

Merged

50 tasks

luacmartins changed the title ~~[HOLD 57580] fix: Tapping an item from recent list directs blank page in mWeb & LHN in Android briefly~~ fix: Tapping an item from recent list directs blank page in mWeb & LHN in Android briefly Mar 14, 2025

Merge branch 'main' into fix/57293

dd52072

DylanDylann approved these changes Mar 17, 2025

View reviewed changes

melvin-bot bot requested a review from luacmartins March 17, 2025 07:22

luacmartins approved these changes Mar 17, 2025

View reviewed changes

luacmartins merged commit 2647d03 into Expensify:main Mar 17, 2025
17 checks passed

github-actions bot added the DeployBlockerCash This issue or pull request should block deployment label Mar 17, 2025

github-actions bot mentioned this pull request Mar 17, 2025

Investigate workflow job failing on main: e2ePerformanceTests / Run E2E tests in AWS device farm #58585

Closed

luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Mar 17, 2025

github-actions bot mentioned this pull request Mar 18, 2025

Deploy Checklist: New Expensify 2025-03-18 #58665

Closed

54 tasks

luacmartins assigned daledah Mar 19, 2025

luacmartins mentioned this pull request Mar 19, 2025

[CP Staging] Revert "fix: Tapping an item from recent list directs blank page in mWeb & LHN in Android briefly" #58754

Merged

MarioExpensify mentioned this pull request Mar 19, 2025

[Due for payment 2025-04-14] [Due for payment 2025-03-27] [$250] mWeb - Search - User is navigated to a chat instead of Reports, when triggering a search #58742

Closed

8 tasks

luacmartins mentioned this pull request Mar 19, 2025

[Due for payment 2025-04-14] Search - Unable to perform search via CMD+K #58726

Closed

8 tasks

Conversation

daledah commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 11, 2025

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins Mar 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

daledah Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

luacmartins Mar 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

luacmartins commented Mar 14, 2025

Uh oh!

DylanDylann commented Mar 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

daledah commented Mar 17, 2025

Uh oh!

DylanDylann left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Mar 17, 2025

Uh oh!

github-actions bot commented Mar 18, 2025

Uh oh!

luacmartins commented Mar 19, 2025

Uh oh!

daledah commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

daledah commented Mar 10, 2025 •

edited

Loading

luacmartins Mar 11, 2025 •

edited

Loading

luacmartins Mar 12, 2025 •

edited

Loading

DylanDylann commented Mar 17, 2025 •

edited

Loading

daledah commented Mar 19, 2025 •

edited

Loading