Bump react-native-keyboard-controller to 1.16.7 by QichenZhu · Pull Request #57580 · Expensify/App

QichenZhu · 2025-02-28T03:11:50Z

Explanation of Change

Fixed Issues

$ #56156
PROPOSAL: #56156 (comment)

Tests

This test applies to mobile devices only.

Precondition: Log in to an account with 8 or more expenses. Create some if necessary.

Open the Expensify app or website.
Tap Reports > Filters icon > Expense type.
Select all the types.
Tap Save > Save search.
Tap the Bookmark icon > Three dots icon of the saved search > Rename.
Enter any name.
Tap Save.
Verify there’s no space between the search results and the bottom bar. It’s okay if the space is the gap between two expenses and it moves as you scroll.
Tap Cancel at the top of the screen.
Verify there’s no space between the search results and the bottom bar. It’s okay if the space is the gap between two expenses and it moves as you scroll.

Verify that no errors appear in the JS console

Offline tests

N/A. This test requires an active internet connection.

QA Steps

This test applies to mobile devices only.

Precondition: Log in to an account with 8 or more expenses. Create some if necessary.

Open the Expensify app or website.
Tap Reports > Filters icon > Expense type.
Select all the types.
Tap Save > Save search.
Tap the Bookmark icon > Three dots icon of the saved search > Rename.
Enter any name.
Tap Save.
Verify there’s no space between the search results and the bottom bar. It’s okay if the space is the gap between two expenses and it moves as you scroll.
Tap Cancel at the top of the screen.
Verify there’s no space between the search results and the bottom bar. It’s okay if the space is the gap between two expenses and it moves as you scroll.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-native.mp4

Android: mWeb Chrome

android-web.mp4

iOS: Native

ios-native.mp4

iOS: mWeb Safari

ios-web.mp4

MacOS: Chrome / Safari

mac-web.mov

MacOS: Desktop

mac-desktop.mp4

github-actions · 2025-02-28T03:12:01Z

⚠️ This PR is possibly changing native code, it may cause problems with HybridApp. Please run an AdHoc build to verify that HybridApp will not break. ⚠️

mountiny · 2025-03-05T23:47:16Z

@QichenZhu @kirillzyusko @chrispader this seems to be blocking #57128. What are the next steps here?

@dukenv0307 @roryabraham

chrispader · 2025-03-06T10:37:33Z

this seems to be blocking #57128. What are the next steps here?

@mountiny @QichenZhu no it's not blocking, it was just my mistake bumping the lib in the other PR. We don't need the updated version

mountiny · 2025-03-06T16:59:26Z

Sorry for the confusion @QichenZhu

github-actions · 2025-03-07T23:03:38Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

github-actions · 2025-03-08T09:08:55Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

melvin-bot · 2025-03-08T11:32:02Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2025-03-10T02:51:56Z

...ompleteSuggestions/AutoCompleteSuggestionsPortal/getBottomSuggestionPadding/index.android.ts

@@ -0,0 +1,5 @@
+function getBottomSuggestionPadding(): number {


Can you add the comment why we need this specific logic on android?

How about: "Selection position returned from react-native-keyboard-controller is platform-dependent, so set different paddings for Android and iOS"?

Suggested change

function getBottomSuggestionPadding(): number {

// Selection position returned from react-native-keyboard-controller is platform-dependent, so set different paddings for Android and iOS.

function getBottomSuggestionPadding(): number {

comment seems fine, but do we think this is a 🐛 in react-native-keyboard-controller?

Maybe, for me it also looks suspicious - I'll be glad to look into it, if needed

(though I wouldn't like to block this PR from being merged because it resolves a lot of bugs I believe)

do we think this is a 🐛 in react-native-keyboard-controller?

In my opinion, it’s best not to have it, but it’s fine as long as the difference is predictable or due to the platform’s nature.

I wouldn't like to block this PR from being merged because it resolves a lot of bugs I believe

I agree it isn’t a blocker for this PR.

@kirillzyusko it'd be great if you could investigate this one. I agree that we shouldn't block the PR on it though

dukenv0307 · 2025-03-10T10:52:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-03-10.at.17.38.18.mov

Android: mWeb Chrome

Screen.Recording.2025-03-10.at.17.51.32.mov

iOS: Native

Screen.Recording.2025-03-10.at.16.32.05.mov

iOS: mWeb Safari

Screen.Recording.2025-03-10.at.16.35.48.mov

MacOS: Chrome / Safari

MacOS: Desktop

Screen.Recording.2025-03-10.at.16.40.51.mov

github-actions · 2025-03-10T19:49:49Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

dukenv0307

LGTM

dukenv0307 · 2025-03-13T08:51:23Z

@roryabraham all yours

QichenZhu · 2025-03-14T05:45:50Z

@dukenv0307, Rory is OOO.

luacmartins · 2025-03-14T15:27:58Z

I'll review this since it's blocking another PR

luacmartins · 2025-03-14T15:29:35Z

...ompleteSuggestions/AutoCompleteSuggestionsPortal/getBottomSuggestionPadding/index.android.ts

@@ -0,0 +1,5 @@
+function getBottomSuggestionPadding(): number {


@kirillzyusko it'd be great if you could investigate this one. I agree that we shouldn't block the PR on it though

OSBotify · 2025-03-14T15:41:10Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-17T12:01:25Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.1.14-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-03-18T21:28:29Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.14-5 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

Bump react-native-keyboard-controller to 1.16.6

a63c853

kirillzyusko mentioned this pull request Mar 5, 2025

feat: Add logic for better bottom SafeArea handling + Enable translucent Android NavBar #57128

Merged

50 tasks

This comment was marked as resolved.

Sign in to view

QichenZhu added 3 commits March 8, 2025 11:49

Merge remote-tracking branch 'upstream/main' into fix/56156

c6179a5

Bump react-native-keyboard-controller to 1.16.7

26973fd

Adjust AutoCompleteSuggestions position on Android

034b40e

QichenZhu changed the title ~~Bump react-native-keyboard-controller to 1.16.6~~ Bump react-native-keyboard-controller to 1.16.7 Mar 7, 2025

Merge remote-tracking branch 'upstream/main' into HEAD

21b0fe3

QichenZhu marked this pull request as ready for review March 8, 2025 11:31

QichenZhu requested a review from a team as a code owner March 8, 2025 11:31

melvin-bot bot requested a review from dukenv0307 March 8, 2025 11:32

melvin-bot bot removed the request for review from a team March 8, 2025 11:32

mountiny assigned QichenZhu Mar 8, 2025

dukenv0307 reviewed Mar 10, 2025

View reviewed changes

Add a comment

c4a6cb9

dukenv0307 approved these changes Mar 11, 2025

View reviewed changes

melvin-bot bot requested a review from roryabraham March 11, 2025 02:47

daledah mentioned this pull request Mar 12, 2025

fix: Tapping an item from recent list directs blank page in mWeb & LHN in Android briefly #58083

Merged

50 tasks

DylanDylann mentioned this pull request Mar 14, 2025

[Due for payment 2025-04-14] [$250] Search - Tapping an item from recent list directs blank page in mWeb & LHN in Android briefly #57293

Closed

8 tasks

luacmartins approved these changes Mar 14, 2025

View reviewed changes

luacmartins merged commit a8b8229 into Expensify:main Mar 14, 2025
26 checks passed

NJ-2020 mentioned this pull request Mar 15, 2025

[HOLD for #56156] [$250] Keyboard and composer overlap #56456

Closed

8 tasks

github-actions bot mentioned this pull request Mar 17, 2025

Deploy Checklist: New Expensify 2025-03-17 #58550

Closed

72 tasks

Julesssss mentioned this pull request Mar 17, 2025

Revert "Bump react-native-keyboard-controller to 1.16.7" #58579

Closed

QichenZhu mentioned this pull request Mar 25, 2025

[Hold for payment] [$250] Android - Reports - Bottom part of expenses list is cutted off after renaming a saved search #56156

Closed

8 tasks

		@@ -0,0 +1,5 @@
		function getBottomSuggestionPadding(): number {

	function getBottomSuggestionPadding(): number {
	// Selection position returned from react-native-keyboard-controller is platform-dependent, so set different paddings for Android and iOS.
	function getBottomSuggestionPadding(): number {

Conversation

QichenZhu commented Feb 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Feb 28, 2025

Uh oh!

mountiny commented Mar 5, 2025

Uh oh!

This comment was marked as resolved.

chrispader commented Mar 6, 2025

Uh oh!

mountiny commented Mar 6, 2025

Uh oh!

github-actions bot commented Mar 7, 2025

Uh oh!

github-actions bot commented Mar 8, 2025

Uh oh!

melvin-bot bot commented Mar 8, 2025

Uh oh!

dukenv0307 Mar 10, 2025

Choose a reason for hiding this comment

Uh oh!

QichenZhu Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

QichenZhu Mar 10, 2025

Choose a reason for hiding this comment

Uh oh!

roryabraham Mar 10, 2025

Choose a reason for hiding this comment

Uh oh!

kirillzyusko Mar 10, 2025

Choose a reason for hiding this comment

Uh oh!

QichenZhu Mar 11, 2025

Choose a reason for hiding this comment

Uh oh!

luacmartins Mar 14, 2025

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Mar 10, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Mar 10, 2025

Uh oh!

dukenv0307 left a comment

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Mar 13, 2025

Uh oh!

QichenZhu commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luacmartins commented Mar 14, 2025

Uh oh!

luacmartins Mar 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Mar 14, 2025

Uh oh!

github-actions bot commented Mar 17, 2025

Uh oh!

github-actions bot commented Mar 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

QichenZhu commented Feb 28, 2025 •

edited

Loading

QichenZhu Mar 10, 2025 •

edited

Loading

QichenZhu commented Mar 14, 2025 •

edited

Loading