Stop creating the transaction thread reports optimistically for RequestMoney by VickyStash · Pull Request #58825 · Expensify/App

VickyStash · 2025-03-20T17:39:43Z

Explanation of Change

Stop creating the transaction thread reports optimistically for RequestMoney.

Fixed Issues

$ #58828
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Open a new 1-1 chat.
One transaction thread expense case:
2.1 In the chat tap FAB -> Create expense. Go through the steps and create a manual expense. It will be the first expense in this 1-1 chat.
2.2 Check that the RequestMoney API call didn't create a transaction thread report.
2.3 Tap on the expense -> the transaction thread report should be created and opened.
Create a couple more expenses in the same chat.
Try to open any expense and see that the transaction thread report is created and opened.

Offline tests

Same, as in the Tests section.

QA Steps

Verify that no errors appear in the JS console

Same, as in the Tests section.

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android_web.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios_web.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

…stMoney

…optimistic-transaction-RequestMoney

…optimistic-transaction-RequestMoney # Conflicts: # src/libs/actions/IOU.ts

melvin-bot · 2025-03-26T14:42:39Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193 · 2025-03-26T15:26:13Z

I'll start reviewing in the morning

hungvu193 · 2025-03-27T10:15:50Z

If I create an expense from QAB, It will reset the receiver to the previous receiver right after I choose one.

Screen.Recording.2025-03-27.at.17.10.12.mov

VickyStash · 2025-03-27T11:38:55Z

If I create an expense from QAB, It will reset the receiver to the previous receiver right after I choose one.

@hungvu193 It looks like the expected behavior, that the active workspace is selected as receiver by default when you create the expense from FAB.
The same behavior should exist on staging/prod. Have you checked it?

hungvu193 · 2025-03-27T11:53:46Z

Weird. I checked staging and it didn't reset to previous receiver. Let me check prod

…optimistic-transaction-RequestMoney

VickyStash · 2025-03-27T12:08:17Z

@hungvu193 I've caught it as well! I've merged the main, and it seems to be fixed. Let me know if it fixes it for you as well

hungvu193 · 2025-03-27T16:01:35Z

@hungvu193 I've caught it as well! I've merged the main, and it seems to be fixed. Let me know if it fixes it for you as well

Yep. It's fixed 😄

hungvu193 · 2025-03-27T16:30:03Z

Current changes from main broke the tab UI ,which also prevents me from testing. I'll continue testing tomorrow

hungvu193 · 2025-03-28T07:28:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-03-28.at.14.42.30.mov

Android: mWeb Chrome

Screen.Recording.2025-03-28.at.14.36.44.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2025-03-28.at.14.32.35.mov

MacOS: Chrome / Safari

Screen.Recording.2025-03-28.at.14.31.09.mov

MacOS: Desktop

Screen.Recording.2025-03-28.at.14.29.09.mov

hungvu193

Tests well! Please merge main @VickyStash

…optimistic-transaction-RequestMoney

VickyStash · 2025-03-31T05:53:43Z

@iwiznia kind bumb 🙂

iwiznia · 2025-03-31T21:45:35Z

src/libs/ReportActionsUtils.ts

-    // Ensure we have a childReportID associated with the IOU report action
-    return singleAction?.childReportID;
+    // Since we don't always create transaction thread optimistically, we return CONST.FAKE_REPORT_ID
+    return singleAction?.childReportID ?? CONST.FAKE_REPORT_ID;


Why do we need the constant? Can't we use null or "" or leave undefined which IIRC is what we said when we did not have a string ID?

In this specific case, we need to return a truly value, so null, '', or undefined won't work.

Why does it need to be truthy?

To explain that, let's take a look at a couple of lines above of the getOneTransactionThreadReportID function and what it does.

It filters out iou actions related to the report.

it checkes that we have only one assosiated iou action => which means we have one transaction thread

this singe iou action is put into singleAction const

App/src/libs/ReportActionsUtils.ts

Line 1213 in 8dfbd12

const singleAction = iouRequestActions.at(0);

We won't always have the childReportID inside singleAction now, cause we won't generate the transaction thread report right from the start.
But the app should still act with the report as with the one transaction thread report. Handle the navigation and UI in an appropriate way.
That's why in this case we return truly value.

@iwiznia what do you think?

^^ @iwiznia

src/libs/ReportUtils.ts

src/libs/actions/IOU.ts

OSBotify · 2025-04-09T18:03:03Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-10T01:19:56Z

🚀 Deployed to staging by https://github.com/iwiznia in version: 9.1.26-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

…ckyStash/feature/stop-creating-optimistic-transaction-RequestMoney" This reverts commit 4166ee7, reversing changes made to ae6a182.

…evert-58825 [CP Staging] Revert "Merge pull request #58825"

…evert-58825 [CP Staging] Revert "Merge pull request #58825" (cherry picked from commit d95f4de) (CP triggered by grgia)

github-actions · 2025-04-11T00:04:48Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.26-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

github-actions · 2025-04-11T00:51:43Z

🚀 Deployed to staging by https://github.com/iwiznia in version: 9.1.27-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-16T22:12:05Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.28-15 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

VickyStash added 4 commits March 20, 2025 18:33

Stop creating the transaction thread reports optimistically for Reque…

ecbc646

…stMoney

Fix one-transaction-thread checks

fd89725

Merge branch 'refs/heads/main' into VickyStash/feature/stop-creating-…

7fe128e

…optimistic-transaction-RequestMoney

Fix tests

6ccf441

VickyStash mentioned this pull request Mar 24, 2025

[Due for payment 2025-11-03] [$125] Do not create optimistic transaction thread report on RequestMoney #58828

Closed

VickyStash added 5 commits March 26, 2025 09:45

Merge branch 'refs/heads/main' into VickyStash/feature/stop-creating-…

eb54c2b

…optimistic-transaction-RequestMoney # Conflicts: # src/libs/actions/IOU.ts

Lint fix

b7e27ce

Optimistic transaction thread creation on its open

3d8ce15

Fix transaction thread creation for one transaction thread scenario

e183c36

Minor code improvements

5974efe

VickyStash marked this pull request as ready for review March 26, 2025 14:42

VickyStash requested a review from a team as a code owner March 26, 2025 14:42

melvin-bot bot requested review from hungvu193 and removed request for a team March 26, 2025 14:42

Merge branch 'refs/heads/main' into VickyStash/feature/stop-creating-…

019771b

…optimistic-transaction-RequestMoney

hungvu193 approved these changes Mar 28, 2025

View reviewed changes

melvin-bot bot requested a review from iwiznia March 28, 2025 07:43

Merge branch 'refs/heads/main' into VickyStash/feature/stop-creating-…

7efd7c6

…optimistic-transaction-RequestMoney

iwiznia reviewed Mar 31, 2025

View reviewed changes

Move shouldGenerateOptimisticTransactionThread flag inside params object

d8b9097

VickyStash requested a review from iwiznia April 1, 2025 08:10

iwiznia approved these changes Apr 9, 2025

View reviewed changes

iwiznia merged commit 4166ee7 into Expensify:main Apr 9, 2025
19 checks passed

github-actions bot mentioned this pull request Apr 10, 2025

Deploy Checklist: New Expensify 2025-04-10 #59968

Closed

65 tasks

thelullabyy mentioned this pull request Apr 10, 2025

Review duplicates - Nothing happens after clicking Confirm when second expense is selected #59970

Closed

8 tasks

This was referenced Apr 10, 2025

[$50] Expense - Hold and Delete options are not shown if expense report is not opened first #60000

Closed

[$50] Scan - Not here page opens when opening Amount field after reset and restart app #59989

Closed

VickyStash mentioned this pull request Apr 10, 2025

[CP Staging] Revert "Merge pull request #58825" #60022

Merged

50 tasks

mountiny added a commit that referenced this pull request Apr 10, 2025

Merge pull request #60022 from callstack-internal/VickyStash/revert/r…

d95f4de

…evert-58825 [CP Staging] Revert "Merge pull request #58825"

grgia mentioned this pull request Apr 10, 2025

Chat - 1:1 DM with "Auth OpenReport returned an error" appears after reset and restart app #59998

Closed

8 tasks

OSBotify pushed a commit that referenced this pull request Apr 10, 2025

Merge pull request #60022 from callstack-internal/VickyStash/revert/r…

6774d5f

…evert-58825 [CP Staging] Revert "Merge pull request #58825" (cherry picked from commit d95f4de) (CP triggered by grgia)

This was referenced Apr 10, 2025

Expense - Only amount of remaining expense can be seen on report after deleting another one. #59982

Closed

Report with RBR appears in LHN after changing unreported expense to reported expense & open it #59990

Closed

github-actions bot mentioned this pull request Apr 11, 2025

Deploy Checklist: New Expensify 2025-04-11 #60076

Closed

33 tasks

VickyStash mentioned this pull request Apr 15, 2025

Stop creating the transaction thread reports optimistically for RequestMoney #60292

Merged

50 tasks

Conversation

VickyStash commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 26, 2025

Uh oh!

hungvu193 commented Mar 26, 2025

Uh oh!

hungvu193 commented Mar 27, 2025

Uh oh!

VickyStash commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hungvu193 commented Mar 27, 2025

Uh oh!

VickyStash commented Mar 27, 2025

Uh oh!

hungvu193 commented Mar 27, 2025

Uh oh!

hungvu193 commented Mar 27, 2025

Uh oh!

hungvu193 commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hungvu193 left a comment

Choose a reason for hiding this comment

Uh oh!

VickyStash commented Mar 31, 2025

Uh oh!

iwiznia Mar 31, 2025

Choose a reason for hiding this comment

Uh oh!

VickyStash Apr 1, 2025

Choose a reason for hiding this comment

Uh oh!

iwiznia Apr 1, 2025

Choose a reason for hiding this comment

Uh oh!

VickyStash Apr 1, 2025

Choose a reason for hiding this comment

Uh oh!

VickyStash Apr 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

OSBotify commented Apr 9, 2025

Uh oh!

github-actions bot commented Apr 10, 2025

Uh oh!

github-actions bot commented Apr 11, 2025

Uh oh!

github-actions bot commented Apr 11, 2025

Uh oh!

github-actions bot commented Apr 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

VickyStash commented Mar 20, 2025 •

edited

Loading

VickyStash commented Mar 27, 2025 •

edited

Loading

hungvu193 commented Mar 28, 2025 •

edited

Loading