Stop creating the transaction thread reports optimistically for RequestMoney

[VickyStash]

Explanation of Change

Previous PR was reverted due to regressions: #58825

Fixed Issues

$ #58828
PROPOSAL: N/A

Tests

• Verify that no errors appear in the JS console

1. Open a new 1-1 chat.
2. One transaction thread expense case:
   2.1 In the chat tap FAB -> Create expense. Go through the steps and create a manual expense. It will be the first expense in this 1-1 chat.
   2.2 Check that the RequestMoney API call didn't create a transaction thread report.
   2.3 Tap on the expense -> the transaction thread report should be created and opened.
3. Create a couple more expenses in the same chat.
4. Try to open any expense and see that the transaction thread report is created and opened.
5. Enable tableReportView beta so that canUseTableReportView returns true.
6. Test the steps 1-4 over the updated UI.

Regressions that appeared during previous merge try:

1. Scan - Not here page opens when opening Amount field after reset and restart app

Link

1. Open the workspace expenses chat.
2. Submit a scan expense with an invalid receipt that will fail the scanning.
3. Go to the transaction thread
4. After the scanning fails, go to Settings > Troubleshoot.
5. Click Clear cache and restart.
6. Go back to Inbox.
7. In the receipt expense click Amount field quickly (important).
8. Make sure edit amount page is opened.

2. 1:1 DM with "Auth OpenReport returned an error" appears after reset and restart app

Link

1. Submit an expense to another user with no chat history.
2. Go to transaction thread.
3. Send a message.
4. Go to Settings > Troubleshoot.
5. Click Clear cache and restart.
6. Go back to Inbox. Make sure there are no greyed-out duplicates in the LHN.

3. Report with RBR appears in LHN after changing unreported expense to reported expense & open it

Link

1. Open the app.
2. Open OD app with the same account.
3. Create an unreported expense on OD (Report set to None).
4. Change the unreported expense to reported expense (Report set to New).
5. On New Dot, go to the workspace chat.
6. Click on the expense preview. Make sure no expense duplicates appear.

4. Expense - Only amount of remaining expense can be seen on report after deleting another one

Link

1. Open any workspace/1-1 chat.
2. Submit two expenses.
3. Delete the second expense.
4. Make sure the remaining expense looks as expected.

5. Expense - Hold and Delete options are not shown if expense report is not opened first

Link

1. Open FAB > Create expense > Manual.
2. Submit a manual expense to any user or workspace.
3. On the main chat, right click on the expense preview.
4. Note that Hold and Delete options are displayed in the context menu.
5. Check that both options work as expected.

6. Review duplicates - Nothing happens after clicking Confirm when second expense is selected

Link

1. Go to workspace chat.
2. Submit two expenses with the same amount and merchant.
3. Go to transaction thread of the second expense.
4. Click Review duplicates.
5. Click Keep on this on the second expense in the list (important).
6. Click Confirm -> make sure it works as expected.

Offline tests

Same, as in the Tests section.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

• Verify that no errors appear in the JS console

Same, as in the Tests section.

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android1.mp4

android2.mp4

Android: mWeb Chrome

android_web1.mp4

android_web2.mp4

iOS: Native

ios1.mp4

ios2.mp4

iOS: mWeb Safari

ios_web1.mp4

ios_web2.mp4

MacOS: Chrome / Safari

web.mp4

web_new_ui.mp4

2-web.mp4

3-web.mp4

4-web.mp4

5-web.mp4

MacOS: Desktop

desktop1.mp4

desktop2.mp4

[hungvu193]

I'll take a look today

[hungvu193]

Hey @VickyStash For better context, could you explain the RCA of #59998?

[VickyStash]

Hey @VickyStash For better context, could you explain the RCA of #59998?

I can't reproduce this issue anymore. But back then the reason for it was that that after Clear cache and restart the iou report action wasn't returned by OpenApp command. So the app check if the transaction thread report exists returned false and the app tried to create one more thread report -> which failed cause it already existed.
As a result user saw the optimistically created duplicate of the transaction thread.

[hungvu193]

@VickyStash Both issues are fixed, but when I opened the scan request, I can see the avatar while OpenReport is being called.

Screen.Recording.2025-04-18.at.18.08.23.mov

[VickyStash]

but when I opened the scan request, I can see the avatar while OpenReport is being called.

TY, Fixed!

[VickyStash]

@hungvu193 During the testing, keep in mind that there are two known issues: one, two.

[melvin-bot]

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[hungvu193]

@hungvu193 During the testing, keep in mind that there are two known issues: one, two.

Thanks Vicky. I'll take a look today

[hungvu193]

@VickyStash can you merge main again?

[hungvu193]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-05-09.at.09.02.03.mov

Android: mWeb Chrome

Screen.Recording.2025-05-09.at.09.06.38.mov

iOS: HybridApp

ios.mov

iOS: mWeb Safari

Safari.mov

MacOS: Chrome / Safari

main.-.optimistic.mov

01.-.scan.mov

02.-.1-1.DM.bug.mov

03.-.unreported.mov

04.-.remaining.expense.mov

05.-.Delete.expense.-.hold.-.take2.mov

5.-.hold.delete.expense.mov

06.-.review.dup.mov

MacOS: Desktop

Screen.Recording.2025-05-09.at.08.52.32.mov

[VickyStash]

@hungvu193 Merged the main!

[hungvu193]

Completed the checklsit. Can you merge main again? 😄

[VickyStash]

Completed the checklsit. Can you merge main again? 😄

Done!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚀 Deployed to staging by https://github.com/iwiznia in version: 9.1.45-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

[github-actions]

🚀 Deployed to staging by https://github.com/iwiznia in version: 9.1.45-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[pecanoro]

I think this PR might have caused this regression 🤔 #62012

[iwiznia]

Oh, bummer!

[nlemma]

@VickyStash for step 2.2 in the PR, should we consider the presence of transactionThreadReportID in the RequestMoney API response as a sign that the transaction thread was created at that point?

[VickyStash]

@VickyStash for step 2.2 in the PR, should we consider the presence of transactionThreadReportID in the RequestMoney API response as a sign that the transaction thread was created at that point?

@nlemma Yeah, if we have transactionThreadReportID in the response, the thread was created!

[nlemma]

Thanks for confirming. If that's the case, it seems that step 2.2 is failing, since the RequestMoney response includes a transactionThreadReportID before the expense is tapped/opened.

[github-actions]

🚀 Deployed to production by https://github.com/francoisl in version: 9.1.45-21 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

[VickyStash]

Thanks for confirming. If that's the case, it seems that step 2.2 is failing, since the RequestMoney response includes a transactionThreadReportID before the expense is tapped/opened.

@nlemma This PR was reverted, so it's expected