Stop creating the transaction thread reports optimistically for RequestMoney

[VickyStash]

Explanation of Change

Re-apply changes of reverted PR: #60292 and fixes reported issues:

• [Due for payment 2025-06-12] [Due for payment 2025-05-27] Expense - "Review duplicates" button is unresponsive on expenses report. #61973
• [Due for payment 2025-06-12] [Due for payment 2025-05-27] Expense - Not here page opens after clicking Edit expense from the expense preview #62012
• [Due for payment 2025-06-12] [Due for payment 2025-05-27] Reports - Individual expense row opens expense report instead of transaction thread #62014
• [$250] Expense - Expense report does not show transaction details and it only shows the total #61965

Fixed Issues

$ #58828
PROPOSAL: N/A

Tests

• Verify that no errors appear in the JS console

1. Open a new 1-1 chat.
2. One transaction thread expense case:
   2.1 In the chat tap FAB -> Create expense. Go through the steps and create a manual expense. It will be the first expense in this 1-1 chat.
   2.2 Check that the RequestMoney API call didn't create a transaction thread report.
   2.3 Tap on the expense -> the transaction thread report should be created and opened.
3. Create a couple more expenses in the same chat.
4. Try to open any expense and see that the transaction thread report is created and opened.

1. Expense - "Review duplicates" button is unresponsive on expenses report.

#61973

1. Open any workspace chat.
2. Submit two similar expenses.
3. Open the expenses report.
4. Tap on "Review Duplicates" at the top of the report.
5. Make sure the duplicate review works as expected.

2. Expense - Not here page opens after clicking Edit expense from the expense preview

#62012

1. Go to workspace chat.
2. Submit two expenses.
3. Click on the expense preview in the main workspace chat.
4. Right click on any expense.
5. Click Edit expense.
6. See that transaction thread is opened

3. Reports - Individual expense row opens expense report instead of transaction thread

#62014

1. Go to workspace chat.
2. Submit two expenses to the workspace chat.
3. Go to Reports.
4. Click on any of created expenses.
5. See that the transaction thread is opened

4. Expense - Expense report does not show transaction details and it only shows the total

#61965

Pre-condition: turn on tableReportView beta

1. Go to staging.new.expensify.com
2. Click FAB > Create report
3. Click + > Create expense > Manual
4. Submit a manual expense
5. Make sure you see the transaction details.

Offline tests

Same, as in the Tests section.

QA Steps

• Verify that no errors appear in the JS console

Same, as in the Tests section.

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android_web.mp4

iOS: Native

iOS: mWeb Safari

ios_web.mp4

MacOS: Chrome / Safari

web0.mp4

web1.mp4

web2.mp4

web3.mp4

web4.mp4

MacOS: Desktop

desktop.mp4

[melvin-bot]

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[VickyStash]

@hungvu193 I have some problems running the iOS platform after merging the latest main, could you please check it on your end? 🙏

[hungvu193]

@hungvu193 I have some problems running the iOS platform after merging the latest main, could you please check it on your end? 🙏

I also can't build IOS

[hungvu193]

@VickyStash Can you resolve the conflict in the mean time?

[VickyStash]

@hungvu193 Done!

[hungvu193]

Thanks. I'm on it

[hungvu193]

@VickyStash Is that correct when we don't show the Hold option for unopened expense?

Screen.Recording.2025-05-28.at.13.25.14.mov

[iwiznia]

@hungvu193 I think you are encountering this bug #52401 which is not caused by these changes.

[VickyStash]

I've just tried merging the latest main to resolve conflicts, but it seems that the main has several issues in the expense flow, which can prevent correct testing.
I'll do another try a little bit later!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚀 Deployed to staging by https://github.com/iwiznia in version: 9.1.59-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[github-actions]

🚀 Deployed to production by https://github.com/roryabraham in version: 9.1.59-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

[github-actions]

🚀 Deployed to staging by https://github.com/iwiznia in version: 9.1.60-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[github-actions]

🚀 Deployed to production by https://github.com/roryabraham in version: 9.1.61-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

[github-actions]

🚀 Deployed to staging by https://github.com/iwiznia in version: 9.1.62-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

[github-actions]

🚀 Deployed to production by https://github.com/Julesssss in version: 9.1.62-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅