[HOLD #58828] Create transaction thread for legacy transactions without threads and navigate to them by c3024 · Pull Request #62291 · Expensify/App

c3024 · 2025-05-19T13:59:36Z

Explanation of Change

Add the logic of creating a transaction thread for legacy transactions without threads and navigating to them to ReportListItem.

Fixed Issues

$ #61941
PROPOSAL: #61941 (comment)

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-05-19T13:59:42Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2025-05-19T21:32:14Z

can you please add test steps @c3024 Thanks!

github-actions · 2025-05-20T10:54:23Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

mountiny · 2025-05-20T10:54:05Z

src/components/SelectionList/types.ts

 };

 type ReportListItemProps<TItem extends ListItem> = ListItemProps<TItem> & {
+    queryJSONHash?: number;


mountiny · 2025-05-20T10:54:49Z

src/components/SelectionList/Search/ReportListItem.tsx

                ? transactionItem.transactionThreadReportID
                : transactionItem.reportID;

+        // If we're trying to open a legacy transaction without a transaction thread, let's create the thread and navigate the user


New expenses are created without transaction thread proactively so this is not only legacy transactions

Suggested change

// If we're trying to open a legacy transaction without a transaction thread, let's create the thread and navigate the user

// If we're trying to open a transaction without a transaction thread, let's create the thread and navigate the user

github-actions · 2025-05-20T11:37:18Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/62291-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/62291-hybrid/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/62291/NewExpensify.dmg	https://62291.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

c3024 · 2025-05-20T11:50:31Z

Shall we hold this for #62080?

cc: @luacmartins

mountiny · 2025-05-20T17:33:08Z

hmm yeah that might make sense

luacmartins · 2025-05-20T18:21:13Z

Yea, I think so.

c3024 · 2025-05-29T10:47:57Z

Not overdue. The PR this is held on has not been merged yet.

c3024 · 2025-06-06T06:11:18Z

The referred PR in the title was reverted. Not overdue.

c3024 · 2025-06-16T16:12:56Z

Same as above. The PR for the issue is still under progress.

c3024 · 2025-06-26T14:30:21Z

Still holding for #58828

ishpaul777 · 2025-07-03T20:24:54Z

Still holding for #58828

c3024 · 2025-07-15T11:25:17Z

Still on hold for #58828

c3024 · 2025-08-22T06:55:21Z

On hold!

ishpaul777 · 2025-09-01T21:12:48Z

Still on hold for #58828

mountiny · 2025-09-11T22:16:13Z

@c3024 @ishpaul777 Are we still on hold here/ or will we need this PR or would changes from @VickyStash handle this?

c3024 · 2025-09-15T12:55:25Z

@mountiny

It looks like this PR is not required anymore. The issue that required creating this PR does not happen anymore.

create transaction thread for legacy transactions without threads

6e6aea0

c3024 requested a review from a team as a code owner May 19, 2025 13:59

melvin-bot bot requested review from ishpaul777 and removed request for a team May 19, 2025 13:59

fix types

62c33fc

luacmartins assigned c3024 May 19, 2025

mountiny reviewed May 20, 2025

View reviewed changes

luacmartins changed the title ~~Create transaction thread for legacy transactions without threads and navigate to them~~ [HOLD #62080] Create transaction thread for legacy transactions without threads and navigate to them May 20, 2025

c3024 changed the title ~~[HOLD #62080] Create transaction thread for legacy transactions without threads and navigate to them~~ [HOLD #58828] Create transaction thread for legacy transactions without threads and navigate to them Jun 26, 2025

c3024 closed this Sep 15, 2025

	// If we're trying to open a legacy transaction without a transaction thread, let's create the thread and navigate the user
	// If we're trying to open a transaction without a transaction thread, let's create the thread and navigate the user

Conversation

c3024 commented May 19, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented May 19, 2025

Uh oh!

ishpaul777 commented May 19, 2025

Uh oh!

github-actions bot commented May 20, 2025

Uh oh!

mountiny May 20, 2025

Choose a reason for hiding this comment

Uh oh!

mountiny May 20, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 20, 2025

Uh oh!

c3024 commented May 20, 2025

Uh oh!

mountiny commented May 20, 2025

Uh oh!

luacmartins commented May 20, 2025

Uh oh!

c3024 commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

c3024 commented Jun 6, 2025

Uh oh!

c3024 commented Jun 16, 2025

Uh oh!

c3024 commented Jun 26, 2025

Uh oh!

ishpaul777 commented Jul 3, 2025

Uh oh!

c3024 commented Jul 15, 2025

Uh oh!

c3024 commented Aug 22, 2025

Uh oh!

ishpaul777 commented Sep 1, 2025

Uh oh!

mountiny commented Sep 11, 2025

Uh oh!

c3024 commented Sep 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

c3024 commented May 29, 2025 •

edited

Loading