Fix tooltips disappearing when switching pages by andriivitiv · Pull Request #58965 · Expensify/App

andriivitiv · 2025-03-23T21:33:44Z

Explanation of Change

Fixed Issues

$ #57569
PROPOSAL: #57569 (comment)

Tests

Same as QA Steps

Offline tests

N/A

QA Steps

Log in with a new account.
Complete the onboarding.
Verify that the global create tooltip is displayed.
Navigate to the Settings page.
Navigate to the Inbox page.
Verify that the global create tooltip is still displayed.

PR Author Checklist

Screenshots/Videos

Android: Native

57569.android.native.webm

Android: mWeb Chrome

57569.android.chrome.webm

iOS: Native

57569.ios.native.mp4

iOS: mWeb Safari

57569.ios.safari.mp4

MacOS: Chrome / Safari

57569.macos.chrome.mov

MacOS: Desktop

57569.macos.desktop.mov

melvin-bot · 2025-03-23T21:59:54Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allroundexperts · 2025-03-23T22:34:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-04-03.at.9.54.55.AM.mov

Android: mWeb Chrome

Screen.Recording.2025-04-03.at.9.53.55.AM.mov

iOS: Native

Screen.Recording.2025-04-03.at.9.52.49.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-04-03.at.9.48.04.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-04-03.at.9.43.01.AM.mov

MacOS: Desktop

Screen.Recording.2025-04-03.at.9.45.37.AM.mov

allroundexperts · 2025-04-03T04:50:32Z

@CyberAndrii On mweb, switching to reports tab makes the tooltip disappear.

Screen.Recording.2025-04-03.at.9.49.54.AM.mov

…ps-disappear-when-switching-pages

in narrow layout

andriivitiv · 2025-04-03T18:34:04Z

On mweb, switching to reports tab makes the tooltip disappear.

This was caused by #57607, which replaced SCREENS.SEARCH.ROOT with NAVIGATORS.SEARCH_FULLSCREEN_NAVIGATOR in SCREENS_WITH_BOTTOM_TAB_BAR

App/src/components/Navigation/TopLevelBottomTabBar/SCREENS_WITH_BOTTOM_TAB_BAR.ts

Line 5 in bf3c0b4

    
           const SCREENS_WITH_BOTTOM_TAB_BAR = [...Object.keys(SIDEBAR_TO_SPLIT), NAVIGATORS.SEARCH_FULLSCREEN_NAVIGATOR, SCREENS.SETTINGS.WORKSPACES];

This resulted in isScreenWithBottomTabFocused being set to false here

App/src/components/Navigation/TopLevelBottomTabBar/index.tsx

Lines 36 to 40 in bf3c0b4

    
           const isScreenWithBottomTabFocused = getIsScreenWithBottomTabFocused(state); 
        
           const selectedTab = getSelectedTab(state); 
        
           const shouldDisplayBottomBar = shouldUseNarrowLayout ? isScreenWithBottomTabFocused : isBottomTabVisibleDirectly; 
        
           const isReadyToDisplayBottomBar = isAfterClosingTransition && shouldDisplayBottomBar && !isBlockingViewVisible;

which is used to determine if a tooltip should be displayed

App/src/components/Navigation/TopLevelBottomTabBar/index.tsx

Line 63 in bf3c0b4

isTooltipAllowed={isReadyToDisplayBottomBar}

I added it back because both of them are necessary.

cc @allroundexperts

allroundexperts

Works good!

OSBotify · 2025-04-07T16:42:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-07T23:08:16Z

🚀 Deployed to staging by https://github.com/blimpich in version: 9.1.24-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-09T02:13:32Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

github-actions · 2025-04-09T04:31:53Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

Fix tooltips disappearing when switching pages

511cbfa

andriivitiv force-pushed the 57569-fix-tooltips-disappear-when-switching-pages branch from 5b4f35a to 511cbfa Compare March 23, 2025 21:46

andriivitiv marked this pull request as ready for review March 23, 2025 21:59

andriivitiv requested a review from a team as a code owner March 23, 2025 21:59

melvin-bot bot requested review from allroundexperts and removed request for a team March 23, 2025 21:59

rayane-d mentioned this pull request Mar 24, 2025

Add RBR/GBR chat and Account switcher tooltips #58540

Merged

50 tasks

andriivitiv added 2 commits April 3, 2025 14:30

Merge branch 'main' of github.com:Expensify/App into 57569-fix-toolti…

d4e684a

…ps-disappear-when-switching-pages

Fix educational tooltip is not displayed on search page

b9efccd

in narrow layout

allroundexperts approved these changes Apr 6, 2025

View reviewed changes

melvin-bot bot requested a review from blimpich April 6, 2025 16:38

blimpich assigned andriivitiv Apr 7, 2025

blimpich approved these changes Apr 7, 2025

View reviewed changes

blimpich merged commit 5a0fb9b into Expensify:main Apr 7, 2025
17 checks passed

andriivitiv deleted the 57569-fix-tooltips-disappear-when-switching-pages branch April 7, 2025 17:41

github-actions bot mentioned this pull request Apr 7, 2025

Deploy Checklist: New Expensify 2025-04-07 #59756

Closed

melvin-bot bot mentioned this pull request Apr 9, 2025

[Due for payment 2025-04-16] [$250] The global create tooltip does not display when switching between the Settings page and the Inbox page. #57569

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix tooltips disappearing when switching pages#58965

Fix tooltips disappearing when switching pages#58965
blimpich merged 3 commits intoExpensify:mainfrom
andriivitiv:57569-fix-tooltips-disappear-when-switching-pages

andriivitiv commented Mar 23, 2025 •

edited

Loading

Uh oh!

melvin-bot bot commented Mar 23, 2025

Uh oh!

allroundexperts commented Mar 23, 2025 •

edited

Loading

Uh oh!

allroundexperts commented Apr 3, 2025

Uh oh!

andriivitiv commented Apr 3, 2025

Uh oh!

allroundexperts left a comment

Uh oh!

Uh oh!

OSBotify commented Apr 7, 2025

Uh oh!

github-actions bot commented Apr 7, 2025

Uh oh!

github-actions bot commented Apr 9, 2025

Uh oh!

github-actions bot commented Apr 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

andriivitiv commented Mar 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 23, 2025

Uh oh!

allroundexperts commented Mar 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allroundexperts commented Apr 3, 2025

Uh oh!

andriivitiv commented Apr 3, 2025

Uh oh!

allroundexperts left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Apr 7, 2025

Uh oh!

github-actions bot commented Apr 7, 2025

Uh oh!

github-actions bot commented Apr 9, 2025

Uh oh!

github-actions bot commented Apr 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

andriivitiv commented Mar 23, 2025 •

edited

Loading

allroundexperts commented Mar 23, 2025 •

edited

Loading