perf: improve uploading image from gallery on native device by TMisiukiewicz · Pull Request #59330 · Expensify/App

TMisiukiewicz · 2025-03-31T08:50:41Z

Explanation of Change

Improving the performance of uploading HEIC images on iOS

Fixed Issues

$ #59347
PROPOSAL:

Tests

Test on native iOS only

Open DM
Press + -> Create expense
In "Scan" tab open attachment picker in left bottom corner
Select "Choose from gallery"
select HEIC image from a gallery
Verify you are navigated to the next screen without waiting for a couple of seconds

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Screen.Recording.2025-04-01.at.11.01.36.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

github-actions · 2025-03-31T08:58:33Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

mountiny · 2025-03-31T10:19:21Z

Discussing in slack in here https://expensify.slack.com/archives/C05LX9D6E07/p1743416318756239?thread_ts=1743081276.904899&cid=C05LX9D6E07

github-actions · 2025-03-31T12:39:50Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

github-actions · 2025-03-31T13:20:59Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/59330-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/59330-hybrid/index.html

Desktop 💻	Web 🕸️
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Desktop build failed	The QR code can't be generated, because the Web build failed

👀 View the workflow run that generated this build 👀

github-actions · 2025-04-01T08:58:59Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

github-actions · 2025-04-01T09:45:53Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/59330-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/59330-hybrid/index.html

Desktop 💻	Web 🕸️
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Desktop build failed	The QR code can't be generated, because the Web build failed

👀 View the workflow run that generated this build 👀

…c-images

This reverts commit 3a7096f.

melvin-bot · 2025-04-02T06:33:07Z

@mountiny Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2025-04-02T09:00:17Z

Adding loader to indicate image is being processed

@TMisiukiewicz I don't see a loading indicator while the image is processing

Screen.Recording.2025-04-02.at.15.57.34.mov

TMisiukiewicz · 2025-04-02T09:01:45Z

@DylanDylann ohh I forgot to update the description. We decided it will be handled in a separate PR: #59519

DylanDylann · 2025-04-02T09:04:54Z

@TMisiukiewicz @mountiny I noticed that the delay time has improved. Do we need to have a metric to measure this improvement?

DylanDylann · 2025-04-02T09:23:10Z

src/components/AttachmentPicker/index.native.tsx

+                                                    height: manipResult.height,
+                                                };
+                                                return resolve([convertedAsset]);
+                                            }),


Please ensure free memory in exceptional case

.catch(error => { manipulateContext?.release(); resolve(response.assets || []); // Fallback to original assets if we want });

Or we can do it in the below catch

@TMisiukiewicz What do you think about the above suggestion?

yeah you are right we should release it in catch, good call 👍

DylanDylann · 2025-04-02T09:29:41Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-04-02.at.16.28.32.mov

Android: mWeb Chrome

Screen.Recording.2025-04-02.at.16.28.57.mov

iOS: Native

Screen.Recording.2025-04-02.at.16.26.38.mov

iOS: mWeb Safari

Screen.Recording.2025-04-02.at.16.27.42.mov

MacOS: Chrome / Safari

NA

MacOS: Desktop

NA

mountiny

thanks!

OSBotify · 2025-04-03T17:21:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-07T23:08:55Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.24-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

mvtglobally · 2025-04-08T19:54:52Z

Still facing #47078 on Web, mWeb, Desktop. Is the issue resolved on IOS only?

github-actions · 2025-04-09T02:14:11Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

github-actions · 2025-04-09T04:32:32Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

replace deprecated .manipulateAsync with .manipulate

203b20f

mountiny assigned TMisiukiewicz Mar 31, 2025

This comment has been minimized.

Sign in to view

add loader when picked an image

7bad6a4

mountiny requested a review from DylanDylann March 31, 2025 12:43

add loader when picking an image

3a7096f

TMisiukiewicz changed the title ~~replace deprecated manipulateAsync with manipulate~~ perf: improve uploading image from gallery on native device Apr 1, 2025

fix lint-changed job

921d1f8

TMisiukiewicz added 2 commits April 2, 2025 08:05

Merge remote-tracking branch 'origin/main' into perf/manipulating-hei…

a4a1ca0

…c-images

Revert "add loader when picking an image"

4acd691

This reverts commit 3a7096f.

TMisiukiewicz force-pushed the perf/manipulating-heic-images branch from 36b50d4 to 4acd691 Compare April 2, 2025 06:21

TMisiukiewicz marked this pull request as ready for review April 2, 2025 06:33

TMisiukiewicz requested a review from a team as a code owner April 2, 2025 06:33

melvin-bot bot requested review from mountiny and removed request for a team April 2, 2025 06:33

DylanDylann reviewed Apr 2, 2025

View reviewed changes

release manipulate context when error

215a62f

DylanDylann approved these changes Apr 3, 2025

View reviewed changes

mountiny approved these changes Apr 3, 2025

View reviewed changes

mountiny merged commit 806643d into Expensify:main Apr 3, 2025
17 checks passed

github-actions bot mentioned this pull request Apr 7, 2025

Deploy Checklist: New Expensify 2025-04-07 #59756

Closed

melvin-bot bot mentioned this pull request Apr 9, 2025

[$250] Improve the performance of uploading image from gallery on native device with clear feedback to the user #59347

Closed

mountiny mentioned this pull request Apr 14, 2025

[CP Staging] Revert "perf: improve uploading image from gallery on native device" #60203

Merged

war-in mentioned this pull request Apr 15, 2025

[Pre RN 0.79] Migrate documents picker #59363

Merged

48 tasks

Conversation

TMisiukiewicz commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Mar 31, 2025

Uh oh!

This comment has been minimized.

mountiny commented Mar 31, 2025

Uh oh!

github-actions bot commented Mar 31, 2025

Uh oh!

github-actions bot commented Mar 31, 2025

Uh oh!

github-actions bot commented Apr 1, 2025

Uh oh!

github-actions bot commented Apr 1, 2025

Uh oh!

melvin-bot bot commented Apr 2, 2025

Uh oh!

DylanDylann commented Apr 2, 2025

Uh oh!

TMisiukiewicz commented Apr 2, 2025

Uh oh!

DylanDylann commented Apr 2, 2025

Uh oh!

DylanDylann Apr 2, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann Apr 2, 2025

Choose a reason for hiding this comment

Uh oh!

TMisiukiewicz Apr 2, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Apr 3, 2025

Uh oh!

github-actions bot commented Apr 7, 2025

Uh oh!

mvtglobally commented Apr 8, 2025

Uh oh!

github-actions bot commented Apr 9, 2025

Uh oh!

github-actions bot commented Apr 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

TMisiukiewicz commented Mar 31, 2025 •

edited

Loading

DylanDylann commented Apr 2, 2025 •

edited

Loading