add full screen loading indicator context by TMisiukiewicz · Pull Request #59519 · Expensify/App

TMisiukiewicz · 2025-04-02T07:51:23Z

Explanation of Change

In some cases we need to cover entire screen with loader + overlay, but it's difficult due to being dependent on a state that is somewhere deep in the component tree.

Fixed Issues

$ #59347
PROPOSAL:

Tests

Test only on iOS and Android

Open DM
Press + -> Create expense
In "Scan" tab open attachment picker in left bottom corner
Select "Choose from gallery"
Verify the full screen loader is displayed when opening the image picker
Pick a picture
Verify the full screen loader disappears once the image picker is closed

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

iOS: Native

ios.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…ontext

melvin-bot · 2025-04-04T07:42:55Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny

Looks good kicking off a build

mountiny · 2025-04-04T08:31:45Z

src/components/FullScreenLoaderContext.tsx

+    isLoaderVisible: boolean;
+    setIsLoaderVisible: React.Dispatch<React.SetStateAction<boolean>>;


can you give these docs too please

mountiny · 2025-04-04T08:31:50Z

src/components/FullScreenLoaderContext.tsx

+});
+
+type FullScreenLoaderContextProviderProps = {
+    children: ReactNode;


github-actions · 2025-04-04T08:32:34Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

TMisiukiewicz · 2025-04-04T08:40:08Z

@mountiny done

DylanDylann · 2025-04-04T08:46:54Z

@mountiny The code looks fine to me. But I want to confirm again about the expectation:

We will display the loading indicator right after clicking on the Gallery selection or we only display the loading indicator after selecting the image

DylanDylann · 2025-04-04T08:47:58Z

Currently, we display the loading indicator right after clicking on the Gallery selection

Screen.Recording.2025-04-04.at.15.47.06.mov

…ontext

mountiny · 2025-04-04T08:51:46Z

Currently, we display the loading indicator right after clicking on the Gallery selection

Yeah I think that is ok given it might be tricky or hacky to show it only once the modal covers it. I think we can see how its going to feel in the App.

@Expensify/design for input too please

github-actions · 2025-04-04T08:52:47Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

github-actions · 2025-04-04T09:34:16Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/59519-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/59519-hybrid/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/59519/NewExpensify.dmg	https://59519.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

shawnborton · 2025-04-04T11:37:43Z

Currently, we display the loading indicator right after clicking on the Gallery selection

Personally I don't mind how this feels, it seems okay to me. Let's see what the other designers think though too.

dannymcclain · 2025-04-04T12:57:24Z

Yeah it doesn't feel bad to me either. And it's a huge improvement over the previous experience.

dubielzyk-expensify · 2025-04-07T04:46:12Z

I'm with Shawn and Danny. Far better and more obvious what's going on.

mountiny · 2025-04-07T18:05:13Z

Lets go then! thanks for the input!

@DylanDylann could you please complete the review and testing?

DylanDylann · 2025-04-07T18:49:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-04-08.at.01.48.56.mov

Android: mWeb Chrome

NA

iOS: Native

Screen.Recording.2025-04-08.at.01.44.50.mov

iOS: mWeb Safari

NA

MacOS: Chrome / Safari

NA

MacOS: Desktop

NA

mountiny

Thanks

OSBotify · 2025-04-07T19:07:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-07T23:09:22Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.24-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-09T02:14:38Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

github-actions · 2025-04-09T04:32:59Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

rlinoz · 2025-04-17T14:08:17Z

src/pages/iou/request/step/IOURequestStepScan/index.native.tsx

                                onPress={() => {
                                    openPicker({
                                        onPicked: (data) => setReceiptAndNavigate(data.at(0) ?? {}),
+                                        onCanceled: () => setIsLoaderVisible(false),


onCanceled is not called when things go wrong, which caused #59903

TMisiukiewicz added 2 commits April 2, 2025 09:18

create context that holds the full screen loader

6feb771

use fullscreen context in IOURequestStepScan

16ff62a

mountiny assigned TMisiukiewicz Apr 2, 2025

TMisiukiewicz mentioned this pull request Apr 2, 2025

perf: improve uploading image from gallery on native device #59330

Merged

51 tasks

Merge remote-tracking branch 'upstream/main' into fullscreen-loader-c…

e031310

…ontext

TMisiukiewicz marked this pull request as ready for review April 4, 2025 07:42

TMisiukiewicz requested a review from a team as a code owner April 4, 2025 07:42

melvin-bot bot requested a review from DylanDylann April 4, 2025 07:42

melvin-bot bot removed the request for review from a team April 4, 2025 07:42

mountiny previously approved these changes Apr 4, 2025

View reviewed changes

add docs to types

25181b5

TMisiukiewicz dismissed mountiny’s stale review via 25181b5 April 4, 2025 08:39

Merge remote-tracking branch 'upstream/main' into fullscreen-loader-c…

1e3b950

…ontext

mountiny requested a review from a team April 4, 2025 08:51

This comment has been minimized.

Sign in to view

DylanDylann approved these changes Apr 7, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny April 7, 2025 18:50

mountiny approved these changes Apr 7, 2025

View reviewed changes

mountiny merged commit cc31ac0 into Expensify:main Apr 7, 2025
17 checks passed

github-actions bot mentioned this pull request Apr 7, 2025

Deploy Checklist: New Expensify 2025-04-07 #59756

Closed

melvin-bot bot mentioned this pull request Apr 9, 2025

[$250] Improve the performance of uploading image from gallery on native device with clear feedback to the user #59347

Closed

thelullabyy mentioned this pull request Apr 9, 2025

[Due for payment 2025-04-23] Hybrid-Scan- circle loading infinitely after close the alert modal of scanning corrupted file #59903

Closed

8 tasks

rlinoz reviewed Apr 17, 2025

View reviewed changes

koko57 mentioned this pull request Jul 8, 2025

Multi files attachments carousel #65316

Merged

50 tasks

		isLoaderVisible: boolean;
		setIsLoaderVisible: React.Dispatch<React.SetStateAction<boolean>>;

Conversation

TMisiukiewicz commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 4, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny Apr 4, 2025

Choose a reason for hiding this comment

Uh oh!

mountiny Apr 4, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 4, 2025

Uh oh!

TMisiukiewicz commented Apr 4, 2025

Uh oh!

DylanDylann commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DylanDylann commented Apr 4, 2025

Uh oh!

mountiny commented Apr 4, 2025

Uh oh!

github-actions bot commented Apr 4, 2025

Uh oh!

This comment has been minimized.

github-actions bot commented Apr 4, 2025

Uh oh!

shawnborton commented Apr 4, 2025

Uh oh!

dannymcclain commented Apr 4, 2025

Uh oh!

dubielzyk-expensify commented Apr 7, 2025

Uh oh!

mountiny commented Apr 7, 2025

Uh oh!

DylanDylann commented Apr 7, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Apr 7, 2025

Uh oh!

github-actions bot commented Apr 7, 2025

Uh oh!

github-actions bot commented Apr 9, 2025

Uh oh!

github-actions bot commented Apr 9, 2025

Uh oh!

rlinoz Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

TMisiukiewicz commented Apr 2, 2025 •

edited

Loading

DylanDylann commented Apr 4, 2025 •

edited

Loading