Skip to content

[CP Staging] Revert "feat: update optimistic data after the API response"#59423

Merged
MariaHCD merged 1 commit intoExpensify:mainfrom
nkdengineer:revert-58972-fix/53265
Apr 1, 2025
Merged

[CP Staging] Revert "feat: update optimistic data after the API response"#59423
MariaHCD merged 1 commit intoExpensify:mainfrom
nkdengineer:revert-58972-fix/53265

Conversation

@nkdengineer
Copy link
Copy Markdown
Contributor

@nkdengineer nkdengineer commented Apr 1, 2025 •
edited
Loading

Reverts #58972

#59417
#59393

@nkdengineer nkdengineer marked this pull request as ready for review April 1, 2025 08:38
@nkdengineer nkdengineer requested a review from a team as a code owner April 1, 2025 08:38
@melvin-bot melvin-bot bot requested review from tylerkaraszewski and removed request for a team April 1, 2025 08:38
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Apr 1, 2025

@tylerkaraszewski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@MariaHCD MariaHCD merged commit aa20cf9 into Expensify:main Apr 1, 2025
14 of 17 checks passed
@melvin-bot melvin-bot bot added the Emergency label Apr 1, 2025
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Apr 1, 2025

@MariaHCD looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@MariaHCD MariaHCD removed the Emergency label Apr 1, 2025
@MariaHCD
Copy link
Copy Markdown
Contributor

MariaHCD commented Apr 1, 2025

Straight revert - not an emergency

OSBotify pushed a commit that referenced this pull request Apr 1, 2025
@MariaHCD @OSBotify
Merge pull request #59423 from nkdengineer/revert-58972-fix/53265
0d24270 
Revert "feat: update optimistic data after the API response"

(cherry picked from commit aa20cf9)

(CP triggered by mountiny)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Apr 1, 2025
@mountiny mountiny changed the title Revert "feat: update optimistic data after the API response" [CP Staging] Revert "feat: update optimistic data after the API response" Apr 1, 2025
@github-actions github-actions bot mentioned this pull request Apr 1, 2025
Closed
62 tasks
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Apr 1, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@MariaHCD MariaHCD mentioned this pull request Apr 1, 2025
Closed
8 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2025

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.21-2 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2025

🚀 Deployed to production by https://github.com/grgia in version: 9.1.21-3 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MariaHCD MariaHCD MariaHCD approved these changes

@tylerkaraszewski tylerkaraszewski Awaiting requested review from tylerkaraszewski

Assignees

@nkdengineer nkdengineer

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nkdengineer @MariaHCD @OSBotify