[NoQA] Follow-Up: Also print E2E performance pipeline results from split files to console

[chrispader]

@mountiny

Explanation of Change

In #58740 we added support for splitting up the output markdown into multiple split files, but we didn't print those to the console in the pipeline workflow. This PR adds the logs to the console.

Fixed Issues

$ #59002
PROPOSAL:

Tests

• Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[melvin-bot]

@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[mountiny]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[mountiny]

In the case below when it fails, would it post the results into multiple comments? Should we try to concentrate it a bit more?

[chrispader]

This will just always log the results to the console. This is the same as before, but now that we potentially have multiple split files, we need to print those as well.

The GH comments are only created if the there is some significant performance regression (🔴) in the results

[mountiny]

Thanks!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

Performance Comparison Report 📊⚠️ Some tests did not pass successfully, so some results are omitted from final report: Linking

Significant Changes To Duration

Name	Duration
App start time contentAppeared_To_screenTTI	1013.008 ms → 1171.185 ms (+158.176 ms, +15.6%) 🔴

Show details

Name

Duration

App start time contentAppeared_To_screenTTI

Baseline Mean: 1013.008 ms Stdev: 253.785 ms (25.1%) Runs: 559.071213000454 587.8879319997504 589.3395060002804 594.4995900001377 614.7793260002509 619.6172080002725 630.4173560002819 634.8329020002857 644.950969000347 670.9438129998744 673.3224179996178 676.5132419997826 676.9272710001096 680.1580699998885 701.91387499962 719.652060999535 741.0104280002415 750.815047999844 765.3056849995628 770.5193649996072 1030.5516619998962 1072.4276029998437 1107.328727999702 1107.6215399997309 1123.6295670000836 1125.9506550002843 1126.9519520001486 1131.9778709998354 1133.7920359997079 1134.3472579997033 1140.9846059996635 1141.0011529996991 1142.1140949996188 1149.4678589999676 1150.9460399998352 1163.242699000053 1167.5038930000737 1172.0769440000877 1172.6241640001535 1181.9300889996812 1191.553125999868 1195.140904000029 1197.5655530001968 1200.1747540002689 1207.2561170002446 1207.568797999993 1216.1770630003884 1221.8919230001047 1232.5211699996144 1238.8900020001456 1244.3020869996399 1246.6929710004479 1253.067463000305 1261.7154769999906 1268.1668840004131 1273.368878999725 1273.7201420003548 1281.1196450004354 1287.187655000016 1303.468012000434 Current Mean: 1171.185 ms Stdev: 72.211 ms (6.2%) Runs: 1043.768756000325 1044.058141999878 1044.8843499999493 1045.9541490003467 1055.9349790001288 1075.8847920000553 1080.1490669995546 1098.233733999543 1103.8479819996282 1112.4227419998497 1113.4282269999385 1113.9999959999695 1115.6143559999764 1123.1567679997534 1147.1327719995752 1151.0948379999027 1156.159071000293 1158.0125259999186 1158.8850440001115 1160.3347969995812 1162.7741400003433 1163.1090780002996 1168.2124220002443 1171.8994190003723 1173.319174000062 1174.0584960002452 1185.4784490000457 1192.1397829996422 1198.149175000377 1204.195387000218 1207.9628309998661 1226.3786359997466 1235.7253419999033 1236.633740999736 1236.6403879998252 1244.3528859997168 1247.184750000015 1250.3915969999507 1257.8588030003011 1262.8964320002124 1264.2770619997755 1272.5037219999358 1285.4449969995767 1289.3336979998276 1289.4371149996296

Meaningless Changes To Duration

Show entries

Name	Duration
App start time nativeLaunch	28.117 ms → 28.017 ms (-0.100 ms, ±0.0%)
App start time nativeLaunchEnd_To_appCreationStart	87.186 ms → 87.017 ms (-0.169 ms, ±0.0%)
App start time runJsBundle	329.317 ms → 323.833 ms (-5.483 ms, -1.7%)
App start time appCreation	74.583 ms → 74.052 ms (-0.532 ms, -0.7%)
App start time appCreationEnd_To_contentAppeared	537.300 ms → 535.900 ms (-1.400 ms, ±0.0%)
App start time TTI	1740.808 ms → 1786.606 ms (+45.798 ms, +2.6%)
App start time regularAppStart	0.020 ms → 0.021 ms (+0.001 ms, +5.1%)
App start time (CPU)	149.424 % → 151.621 % (+2.197 %, +1.5%)
App start time (FPS)	60.000 FPS → 60.000 FPS
App start time (RAM)	376.012 MB → 381.755 MB (+5.743 MB, +1.5%)
App start time (CPU/JS)	0.000 % → 0.000 %
App start time (CPU/UI)	25.174 % → 26.427 % (+1.253 %, +5.0%)
Open search router TTI Load Search Options	171.238 ms → 170.487 ms (-0.751 ms, ±0.0%)
Open search router TTI Open Search Router TTI	1350.187 ms → 1320.877 ms (-29.310 ms, -2.2%)
Open search router TTI (CPU)	144.449 % → 144.499 % (+0.050 %, ±0.0%)
Open search router TTI (FPS)	60.000 FPS → 60.000 FPS
Open search router TTI (RAM)	407.530 MB → 406.329 MB (-1.201 MB, ±0.0%)
Open search router TTI (CPU/JS)	0.000 % → 0.000 %
Open search router TTI (CPU/UI)	24.265 % → 24.382 % (+0.117 %, ±0.0%)
Report typing Composer typing rerender count	1.000 renders → 1.000 renders
Report typing Message sent	522.912 ms → 520.908 ms (-2.005 ms, ±0.0%)
Report typing (CPU)	101.738 % → 101.157 % (-0.581 %, -0.6%)
Report typing (FPS)	60.000 FPS → 60.000 FPS
Report typing (RAM)	479.826 MB → 478.020 MB (-1.806 MB, ±0.0%)
Report typing (CPU/JS)	0.000 % → 0.000 %
Report typing (CPU/UI)	21.838 % → 21.700 % (-0.138 %, -0.6%)
Chat opening Chat TTI	1010.654 ms → 998.697 ms (-11.958 ms, -1.2%)
Chat opening (CPU)	155.246 % → 154.455 % (-0.791 %, -0.5%)
Chat opening (FPS)	60.000 FPS → 60.000 FPS
Chat opening (RAM)	408.698 MB → 407.675 MB (-1.023 MB, ±0.0%)
Chat opening (CPU/JS)	0.000 % → 0.000 %
Chat opening (CPU/UI)	30.824 % → 30.103 % (-0.721 %, -2.3%)

undefined

[github-actions]

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

[github-actions]

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.22-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[github-actions]

🚀 Deployed to production by https://github.com/grgia in version: 9.1.22-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅