[CP Staging] fix: correct review translation text#59482
Merged
mountiny merged 2 commits intoExpensify:mainfrom Apr 2, 2025
Merged
[CP Staging] fix: correct review translation text#59482mountiny merged 2 commits intoExpensify:mainfrom
mountiny merged 2 commits intoExpensify:mainfrom
Conversation
8 tasks
Contributor
|
🚧 @grgia has triggered a test app build. You can view the workflow run here. |
mountiny
requested changes
Apr 1, 2025
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
mountiny
approved these changes
Apr 1, 2025
Contributor
mountiny
left a comment
There was a problem hiding this comment.
Great, thanks! @DylanDylann can you please complete the checklist?
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb Safari |
DylanDylann
approved these changes
Apr 2, 2025
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
OSBotify
pushed a commit
that referenced
this pull request
Apr 2, 2025
[CP Staging] fix: correct review translation text (cherry picked from commit dd9cfdc) (CP triggered by grgia)
60 tasks
Contributor
|
🚀 Cherry-picked to staging by https://github.com/grgia in version: 9.1.22-3 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Contributor
|
🚀 Deployed to production by https://github.com/grgia in version: 9.1.22-10 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Explanation of Change
Fixed Issues
$ #59474
$ #59456
PROPOSAL: #59474 (comment)
Tests
Precondition: Have an expense with violations. Not on small screen.
Offline tests
QA Steps
Precondition: Have an expense with violations. Not on small screen.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2025-04-02.at.02.17.05.mov
MacOS: Desktop
Screen.Recording.2025-04-02.at.02.23.07.mov