Skip to content

Fixing displaying the hold and unhold option in expense report#60436

Merged
marcaaron merged 16 commits intoExpensify:mainfrom
Tony-MK:fix/60111
May 1, 2025
Merged

Fixing displaying the hold and unhold option in expense report#60436
marcaaron merged 16 commits intoExpensify:mainfrom
Tony-MK:fix/60111

Conversation

@Tony-MK
Copy link
Contributor

@Tony-MK Tony-MK commented Apr 17, 2025

Explanation of Change

Fixed Issues

$ #60111
PROPOSAL: #60111 (comment)

Tests

  1. Go to workspace chat
  2. Submit two or more expenses to the workspace chat.
  3. Go to Reports.
  4. Go to Expense Reports.
  5. Click on the expense reports created in step 2.
  6. Bulk select all the expenses.
  7. Click on the dropdown menu.
  8. Note that the hold option is present, then click it.
  9. Click on the dropdown menu again.
  10. Note that the unhold option is present, then click it.
  11. Click on the dropdown menu again.
  12. Note that the hold option is present.
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  1. Go to workspace chat
  2. Submit two or more expenses to the workspace chat.
  3. Go to Reports.
  4. Go to Expense Reports.
  5. Click on the expense reports created in step 2.
  6. From the bottom of the expense report page, click on the + button.
  7. Submit a scanned expense.
  8. Bulk select all the expenses.
  9. Click on the dropdown menu.
  10. Note that the hold option is not present while the last expense is scanning.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • [] I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
macOS.-.Chrome.mov
MacOS: Desktop
macOS.-.Desktop.mov

@Tony-MK Tony-MK marked this pull request as ready for review April 17, 2025 15:34
@Tony-MK Tony-MK requested a review from a team as a code owner April 17, 2025 15:34
@melvin-bot melvin-bot bot requested review from allroundexperts and removed request for a team April 17, 2025 15:34
@melvin-bot
Copy link

melvin-bot bot commented Apr 17, 2025

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@Tony-MK
Copy link
Contributor Author

Tony-MK commented Apr 17, 2025

@allroundexperts, I could not test it on mobile because it does not allow me to select multiple transactions.

WDYT?

@allroundexperts
Copy link
Contributor

@Tony-MK Can you please fix the lint issues first?

@Tony-MK
Copy link
Contributor Author

Tony-MK commented Apr 22, 2025

@allroundexperts, I fixed the lint.

You can review it now.

@allroundexperts
Copy link
Contributor

Conflicts again 😢

@Tony-MK
Copy link
Contributor Author

Tony-MK commented Apr 24, 2025

Sorry about @allroundexperts.

It is ready.

@allroundexperts
Copy link
Contributor

allroundexperts commented Apr 27, 2025

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
Screen.Recording.2025-05-01.at.1.51.24.AM.mov
Android: mWeb Chrome
Screen.Recording.2025-05-01.at.1.50.13.AM.mov
iOS: Native
Screen.Recording.2025-05-01.at.1.47.09.AM.mov
iOS: mWeb Safari
Screen.Recording.2025-05-01.at.1.45.26.AM.mov
MacOS: Chrome / Safari
Screen.Recording.2025-04-28.at.1.49.39.AM.mov
MacOS: Desktop
Screen.Recording.2025-04-28.at.1.54.44.AM.mov

@allroundexperts
Copy link
Contributor

BUG

Hold option is initially absent from a scanned receipt expense, but after you visit the expense, and go back to the reports page, the option gets visible.

Screen.Recording.2025-04-28.at.1.58.26.AM.mov

@Tony-MK Tony-MK changed the title Fix/60111 Fixing displaying the hold and unhold option in expense report. Apr 28, 2025
@Tony-MK Tony-MK changed the title Fixing displaying the hold and unhold option in expense report. Fixing displaying the hold and unhold option in expense report Apr 28, 2025
@Tony-MK
Copy link
Contributor Author

Tony-MK commented Apr 28, 2025

@allroundexperts,

I wanted to mention this bug, but thought it was out of scope because based on the video of the OP shows, we are supposed to be fixing displaying the hold/unhold option inside the expense report.

OP Video

1.mp4

Nonetheless, this is a BE bug because the hold/unhold option can't be displayed if the user isOffline and the value of canHold and canUnhold is determined by the BE.

const shouldShowHoldOption = !isOffline && selectedTransactionsKeys.every((id) => selectedTransactions[id].canHold);

const shouldShowUnholdOption = !isOffline && selectedTransactionsKeys.every((id) => selectedTransactions[id].canUnhold);

Furthermore, I was trying to reproduce the issue on the latest main, but I got different results from expected.

First Result

When adding a new scan expense, the merchant text reads scanning.. even if the scan is complete and the hold option is not present.

Skip to 0:56 as I was waiting for the scanning.. to clear, but I realized it was finished when I open the report

1st.mov

Second Result

Right after, I added another scan expense to the previous report, the hold option shows and scanning.. is cleared, even if thought report was not opened.

2nd.mov

@allroundexperts
Copy link
Contributor

@Tony-MK Do you know why the following is not working? (It's not working on staging as well)

Screen.Recording.2025-05-01.at.2.00.57.AM.mov

@Tony-MK
Copy link
Contributor Author

Tony-MK commented Apr 30, 2025

Yeah, I noticed it.

It's expected.

Copy link
Contributor

@allroundexperts allroundexperts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's fix #60436 (comment) as follow up. @marcaaron let us know if you agree.

@melvin-bot melvin-bot bot requested a review from marcaaron May 1, 2025 00:58
@marcaaron marcaaron merged commit d196f8e into Expensify:main May 1, 2025
19 of 20 checks passed
@OSBotify
Copy link
Contributor

OSBotify commented May 1, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@dangrous
Copy link
Contributor

dangrous commented May 1, 2025

Hi! Coming here from a backend server error which looks like it's getting hit when you tested this on mobile - the timing and email address for one attempt line up perfectly with this video. If it helps, the error is that HoldMoneyRequestOnSearch is being called with an empty transactionIDList, it looks like the search context might be getting wiped when the new RHP is opened (in the vid it flashes to 0 selected). When you've got a PR up to fix that, would love to follow along!

@marcaaron the error is this one - https://github.com/Expensify/Expensify/issues/495613

@marcaaron
Copy link
Contributor

@dangrous We will see if this becomes a ND deploy blocker from QA soon, but sounds like it should be. Thoughts @Tony-MK ?

@allroundexperts, I could not test it on mobile because it does not allow me to select multiple transactions.

What does it mean exactly? I'm guessing that whatever you are experienced there is what triggered the BE error. Seems like it also happens on production or staging server, but what about production App?

@marcaaron
Copy link
Contributor

Also, I think if you have ENVIRONMENT=development in the .env these errors are not produced in the future. Though, I see that QA also produced it on staging in this case.

@allroundexperts
Copy link
Contributor

allroundexperts commented May 1, 2025

@dangrous @marcaaron As mentioned here, this is an error happening on main as well. Should we fix it as a follow up?

#60436 (comment)

@marcaaron
Copy link
Contributor

I think I'd be more concerned about the production and staging behaviors than what is happening on main.

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2025

🚀 Deployed to staging by https://github.com/marcaaron in version: 9.1.39-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@dangrous
Copy link
Contributor

dangrous commented May 2, 2025

I think I'd be more concerned about the production and staging behaviors than what is happening on main.

Based on the logs it seems like it's happening in staging too? At least I'm getting the same errors from applause testers.

canHoldTransactions = canHoldTransactions && canHoldRequest;
canUnholdTransactions = canUnholdTransactions && canUnholdRequest;

return !(canHoldTransactions || canUnholdTransactions);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tony-MK What is this return value supposed to do? This callback is used in a forEach so the return is ignored... is this logic correct? Maybe what you wanted was to use some?

Copy link
Contributor Author

@Tony-MK Tony-MK May 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be correct because the return value is only used to stop iterating forEach when canHoldTransactions || canUnholdTransactions is false, meaning we can not hold or unhold all selected transactions.

So, forEach can stop early instead of iterating over all transactions twice, like when using some.

If there is a problem with this method, we can revert to using some.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that is how forEach works. forEach ignores the value returned by the callback:

There is no way to stop or break a forEach() loop other than by throwing an exception. If you need such behavior, the forEach() method is the wrong tool.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/forEach

Copy link
Contributor Author

@Tony-MK Tony-MK May 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your correct. So, sorry about that.

Should I open a PR to revert forEach to some?

Copy link
Contributor

@aldo-expensify aldo-expensify May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem!

I'm not so sure really, using some just because it will stop when you return true from the callback and ignoring the return of selectedTransactions.some(...) doesn't sound so clean to me either. Maybe you should just keep the forEach but drop the returned values so the code doesn't look weird.

        selectedTransactions.forEach((selectedTransaction) => {
            if (!canHoldTransactions && !canHoldTransactions) {
                return;
            }
            if (!selectedTransaction?.transactionID) {
                canHoldTransactions = false;
                canUnholdTransactions = false;
                return;
            }
            const iouReportAction = getIOUActionForTransactionID(reportActions, selectedTransaction.transactionID);
            const {canHoldRequest, canUnholdRequest} = canHoldUnholdReportAction(iouReportAction);

            canHoldTransactions = canHoldTransactions && canHoldRequest;
            canUnholdTransactions = canUnholdTransactions && canUnholdRequest;
        });

I wouldn't care much for iterating the rest of the elements.. you can add something like

            if (!canHoldTransactions && !canHoldTransactions) {
                return;
            }

to make it fast, and it is also already inside a useMemo so this shouldn't happen all the time.

@Tony-MK
Copy link
Contributor Author

Tony-MK commented May 4, 2025

Hi! Coming here from a backend server error which looks like it's getting hit when you tested this on mobile - the timing and email address for one attempt line up perfectly with #60436 (comment). If it helps, the error is that HoldMoneyRequestOnSearch is being called with an empty transactionIDList, it looks like the search context might be getting wiped when the new RHP is opened (in the vid it flashes to 0 selected)

Hey @dangrous and @marcaaron, I did some digging to answer your questions.

It is not related to this PR but this PR because it introduced clearSelectedTransactions in handleOnModalHide without a condition to return early.

Then, this CP Stag PR introduced shouldPreserveSelectionAfterHideModal.

Except for the delete option, shouldPreserveSelectionAfterHideModal was left out for some of the headerButtonsOptions in SearchPage

if (shouldShowHoldOption) {
options.push({
icon: Expensicons.Stopwatch,
text: translate('search.bulkActions.hold'),
value: CONST.SEARCH.BULK_ACTION_TYPES.HOLD,
shouldCloseModalOnSelect: true,
onSelected: () => {

if (shouldShowDeleteOption) {
options.push({
icon: Expensicons.Trashcan,
text: translate('search.bulkActions.delete'),
value: CONST.SEARCH.BULK_ACTION_TYPES.DELETE,
shouldCloseModalOnSelect: true,
shouldPreserveSelectionAfterHideModal: true,
onSelected: () => {

Therefore, in SearchSelectedNarrow, when the hold or unhold option is clicked, clearSelectedTransactions is called, clearing the selectedTransactions.

options[selectedOptionIndexRef.current]?.onSelected?.();
if (options[selectedOptionIndexRef.current]?.shouldPreserveSelectionAfterHideModal) {
return;
}
clearSelectedTransactions();

Thus, sending an empty list for transactionIDList in HoldMoneyRequestOnSearch's payload

Screenshot 2025-05-04 at 16 06 22

When you've got a PR up to fix that, would love to follow along

Since it's also happening on staging and production, should I raise a PR?

However, I'm unsure due to this comment.

@dangrous
Copy link
Contributor

dangrous commented May 5, 2025

It looks like they've got a PR up that will fix that behavior, I'll ping there and make sure they test against this flow.

Thank you for the investigation! Nice work, I think you're off the hook :)

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2025

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.1.39-8 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

@luacmartins
Copy link
Contributor

luacmartins commented May 15, 2025

BTW we were working on a BulkHoldRequest API and that's why we had this limitation in place, to avoid doing N API requests when holding multiple transactions like we did in this PR

@Tony-MK
Copy link
Contributor Author

Tony-MK commented May 15, 2025

BTW we were working on a #59683 and that's why we had this limitation in place, to avoid doing N API requests when holding multiple transactions like we did in this PR

Sorry, I wasn't aware of that at first. I attempted to revert my mistake here.

selectedTransactionsID.forEach((transactionID) => putOnHold(transactionID, values.comment, reportID));

Should I revert the line? But it seems better to use the new API.

Thoughts?

@luacmartins
Copy link
Contributor

@Tony-MK yea, let's just use the new API. We don't have a PR up for that yet

@Tony-MK
Copy link
Contributor Author

Tony-MK commented May 15, 2025

You mentioned here that the new API is in place.

Can I raise a PR for the fix?

@luacmartins
Copy link
Contributor

Yes, please

@Tony-MK
Copy link
Contributor Author

Tony-MK commented May 18, 2025

@luacmartins

Great. I started working on the PR, but could you give me some details about the BulkHoldRequest, such as the endpoint and parameters required?

Thanks

@luacmartins
Copy link
Contributor

luacmartins commented May 19, 2025

@Tony-MK sure:

API endpoint: BulkHoldRequest
BulkHoldRequestParams: {
    holdData: string; // This is a json object with shape Record<string, HoldDataEntry>;
    comment: string;
}

type HoldDataEntry = {
  transactionThreadReportID?: string;
  transactionThreadCreatedReportActionID?: string;
  holdReportActionID: string;
  commentReportActionID: string;
};

The key for holdData is the transactionID and transactionThreadReportID and transactionThreadCreatedReportActionID are only passed as params if they were optimistically created as part of the hold

@Tony-MK Tony-MK mentioned this pull request May 19, 2025
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants