Fix sign out button, by passing reference when removing event #613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think Marc already fixed this in #609 so I'm going to close this. |
Contributor
Author
Ah thanks. I couldn't find a reference to this issue (maybe should have searched more thoroughly), I know it was a small thing, but an issue might have prevented this dupe. |
Julesssss
deleted the
jules-fix-logout-with-listener-removal-reference
branch
50 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @marcaaron
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/143067
Fixes issue where sign out button threw error and did not return user to login page.
Tests (Desktop and web)
Screenshots
N/A