Skip to content

Fix sign out button, by passing reference when removing event #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Julesssss wants to merge 2 commits into from
Closed

Fix sign out button, by passing reference when removing event #613

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa4fa79
fix logout, by passing reference when removing event
Julesssss Oct 7, 2020
cea01bf
add JSDoc for param
Julesssss Oct 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 22 additions & 16 deletions src/lib/NetworkConnection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,26 @@ const triggerReconnectionCallbacks = _.throttle(() => {
_.each(reconnectionCallbacks, callback => callback());
}, 5000, {trailing: false});

/**
* When the app is in the background Pusher can still receive realtime updates
* for a few minutes, but eventually disconnects causing a delay when the app
* returns from the background. So, if we are returning from the background
* and we are online we should trigger our reconnection callbacks.
*
* @param {AppState} state
*/
const reconnectListener = (state) => {
console.debug('[AppState] state changed:', state);
const nextStateIsActive = state === 'active';

// We are moving from not active to active and we are online so fire callbacks
if (!isOffline && nextStateIsActive && !isActive) {
triggerReconnectionCallbacks();
}

isActive = nextStateIsActive;
};

/**
* Called when the offline status of the app changes and if the network is "reconnecting" (going from offline to online)
* then all of the reconnection callbacks are triggered
Expand Down Expand Up @@ -53,21 +73,7 @@ function listenForReconnect() {
setOfflineStatus(!state.isConnected);
});

// When the app is in the background Pusher can still receive realtime updates
// for a few minutes, but eventually disconnects causing a delay when the app
// returns from the background. So, if we are returning from the background
// and we are online we should trigger our reconnection callbacks.
AppState.addEventListener('change', (state) => {
console.debug('[AppState] state changed:', state);
const nextStateIsActive = state === 'active';

// We are moving from not active to active and we are online so fire callbacks
if (!isOffline && nextStateIsActive && !isActive) {
triggerReconnectionCallbacks();
}

isActive = nextStateIsActive;
});
AppState.addEventListener('change', reconnectListener);

// When a device is put to sleep, NetInfo is not always able to detect
// when connectivity has been lost. As a failsafe we will capture the time
Expand All @@ -91,7 +97,7 @@ function stopListeningForReconnect() {
if (unsubscribeFromNetInfo) {
unsubscribeFromNetInfo();
}
AppState.removeEventListener('change', () => {});
AppState.removeEventListener('change', reconnectListener);
}

/**
Expand Down