Split - Missing split preview when expense is split in room

[thelullabyy]

Explanation of Change

Fixed Issues

$#62235
PROPOSAL:#62235 (comment)

Tests

Precondition:

• Log in with Expensifail account.

1. Open the app
2. Go to a room.
3. Add a member via room header > Members.
4. Click + > Split expense > Manual.
5. Split a manual expense
6. Verify split preview is displayed

• Verify that no errors appear in the JS console

Offline tests

QA Steps

Precondition:

• Log in with Expensifail account.

1. Open the app
2. Go to a room.
3. Add a member via room header > Members.
4. Click + > Split expense > Manual.
5. Split a manual expense
6. Verify split preview is displayed

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

amweb.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios_web.mov

MacOS: Chrome / Safari

chorme.mp4

MacOS: Desktop

desktop.mov

[melvin-bot]

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[c3024]

@thelullabyy

I am seeing a loading indicator with IOU report containing all undefined values when I split a bill in a room. Did you face this?

Screen.Recording.2025-05-23.at.5.04.21.PM.mov

[c3024]

That seems to be a regression on main.

[c3024]

@thelullabyy

Could you merge main here? The PR causing this was reverted.

[c3024]

@thelullabyy

Please check this.

[thelullabyy]

@c3024 I've just merged from main and it works properly.

Screen.Recording.2025-05-27.at.16.11.24.mov

[c3024]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

splitAndroid.mov

Android: mWeb Chrome

splitAndroidmWeb.mov

iOS: HybridApp

splitiOS.mov

iOS: mWeb Safari

splitiOSmWeb.mov

MacOS: Chrome / Safari

splitChrome.mov

MacOS: Desktop

splitDesktop.mov

[c3024]

LGTM!

[c3024]

@thelullabyy

There is a problem with the performance test workflow. Please merge main again so that the check triggers again and succeeds.

[grgia]

@thelullabyy lgtm, please merge main 🙏

[thelullabyy]

@grgia Completed

[trjExpensify]

@grgia hang fire on merging this for a second, please. CC: @mountiny

addressed

[mountiny]

Looks better to me but @c3024 can you please retest split in:

• workspace chat
• DM
• Group chat
• Room
• Split and them move the expense from the split to selfDM (unreport) (should not be visible in the selfDM)

[trjExpensify]

Okay great, that's the correct order. 👍 Danny, Shawn is this the right single expense preview then?

[dannymcclain]

Danny, Shawn is this the right single expense preview then?

Yes except we need to remove that little border going along the outside.

Though since that's not really part of this issue, I suppose we could do that as a follow up?

[shawnborton]

I suppose we could do that as a follow up?

Or roll it into this issue since it seems like a small change :)

[trjExpensify]

Cool yeah, if it's matching what's in the selfDM for unreported expenses already as you show here, then let's follow suit.

[c3024]

Here is what they look like now.

Room

Group chat

splitGroupChat.mov

DM

Only Teachers unite workspace has the split expense option in the workspace chat now. It has been removed from other workspaces.

https://github.com/Expensify/App/blame/89d03e5215f62fccd2de7249514a1e5b70c02854/src/libs/ReportUtils.ts#L8410

@mountiny

• Split and them move the expense from the split to selfDM (unreport) (should not be visible in the selfDM)

This case is possible only for the split expense created in workspace chat, right? With the option of split expense removed from all workspaces except teachers unite, I think, this case does not exist anymore.

[mountiny]

This case is possible only for the split expense created in workspace chat, right? With the option of split expense removed from all workspaces except teachers unite, I think, this case does not exist anymore.

I think this might be possible in DM as well, no?

[trjExpensify]

Split and them move the expense from the split to selfDM (unreport) (should not be visible in the selfDM)

I don't understand this sentence really. Can someone perhaps list it out in a series of numbered steps?

[mountiny]

Bump @c3024 @thelullabyy

Can someone perhaps list it out in a series of numbered steps?

[c3024]

@mountiny

This is from your comment here.

Split and them move the expense from the split to selfDM (unreport) (should not be visible in the selfDM)

I don't understand it either. I don't see any unreport option anywhere. I don't see it on the report header for workspace chats too even if I remove the isTeachersUniteReport check. Where is that option?

[thelullabyy]

@c3024 What is the problem at your last comment here

[c3024]

@mountiny asked here to check how split works for these flows, so I posted the screenshots/videos for others to review.

[mountiny]

Ok I think that for now the tested cases are looking good so maybe no reason to hold this for longer. @grgia would you like to do a final review?

[grgia]

🚀

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚀 Deployed to staging by https://github.com/grgia in version: 9.1.70-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[chiragsalian]

Sorry @thelullabyy, this PR created a blocker,

• Split - Navigation arrows appear on split confirm page, which opens another confirm page

I'll have to revert this PR and CP it. When you get a chance please test the same steps in the blocker issue and ensure it does not reoccur. thank you.

[github-actions]

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

[github-actions]

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

[github-actions]

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

[github-actions]

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

[github-actions]

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅