Fix - Manage my team expenses - The user is redirected to Concierge chat instead of #admins#62671
Closed
FitseTLT wants to merge 2 commits intoExpensify:mainfrom
Closed
Conversation
|
@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
|
@FitseTLT Could you resolve conflict? |
Contributor
Author
|
@hungvu193 Looks like some other change on test drive has fixed the original bug. It is not reproducible on main. 2025-05-27.01-19-10.mp4 |
Contributor
|
Yeah, it was fixed on main. Let's close this PR @FitseTLT Screen.Recording.2025-05-28.at.10.05.59.mov |
Contributor
Author
|
NO more needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #62319
PROPOSAL: #62319 (comment)
Tests
Precondition:
The test applies only for wide screen Web/Desktop
Offline tests
Same as above
QA Steps
Same as above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
2025-05-23.22-09-18.mp4
Android: mWeb Chrome
2025-05-23.22-07-34.mp4
iOS: Native
2025-05-23.21-16-20.mp4
iOS: mWeb Safari
2025-05-23.21-18-02.mp4
MacOS: Chrome / Safari
2025-05-23.21-13-36.mp4
MacOS: Desktop
2025-05-23.21-15-09.mp4