Split expense flow v2 Phase1 by ZhenjaHorbach · Pull Request #63092 · Expensify/App

ZhenjaHorbach · 2025-05-29T19:36:01Z

Explanation of Change

Implement Split expense flow (Phase 1)

Fixed Issues

$ #61027
PROPOSAL:

Tests

Navigate to an eligible expense in your reports or expenses list
Open the more menu
Click the “Split” button
Verify that the split UI appears
Click add split button
Verify that a new split added with 0 amount
Try to change amount in a split item
Verify that value has changed
Try to save value with greater or lesser amount than default or with a split item with 0 amount
Verify that the error has appeared (we can save a lesser total amount than the original amount and don't show the error if it is not isPerDiem or isCard)
Try to press a split item
Verify that the editing screen is open and you can change the split item data
Try to save with correct amount
Verify that the split transactions have been created and the original transaction has disappeared

Verify that no errors appear in the JS console

Offline tests

Navigate to an eligible expense in your reports or expenses list
Open the more menu
Click the “Split” button
Verify that the split UI appears
Click add split button
Verify that a new split added with 0 amount
Try to change amount in a split item
Verify that value has changed
Try to save value with greater or lesser amount than default or with a split item with 0 amount
Verify that the error has appeared (we can save a lesser total amount than the original amount and don't show the error if it is not isPerDiem or isCard)
Try to press a split item
Verify that the editing screen is open and you can change the split item data
Try to save with correct amount
Verify that the split transactions have been created and the original transaction has disappeared

QA Steps

Navigate to an eligible expense in your reports or expenses list
Open the more menu
Click the “Split” button
Verify that the split UI appears
Click add split button
Verify that a new split added with 0 amount
Try to change amount in a split item
Verify that value has changed
Try to save value with greater or lesser amount than default or with a split item with 0 amount
Verify that the error has appeared (we can save a lesser total amount than the original amount and don't show the error if it is not isPerDiem or isCard)
Try to press a split item
Verify that the editing screen is open and you can change the split item data
Try to save with correct amount
Verify that the split transactions have been created and the original transaction has disappeared

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-05-29T19:36:05Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2025-05-29T20:10:53Z

@rojiphil Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

lakchote · 2025-05-29T20:20:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

OSBotify · 2025-05-29T20:30:45Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-05-30T06:15:13Z

🚧 @lakchote has triggered a test app build. You can view the workflow run here.

github-actions · 2025-05-30T06:51:38Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/63092-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/63092-hybrid/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/63092/NewExpensify.dmg	https://63092.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

github-actions · 2025-06-02T19:58:01Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.1.55-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-06-03T12:52:52Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.1.56-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

github-actions · 2025-06-03T20:05:17Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.1.58-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-06-04T16:21:31Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.1.58-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

dukenv0307 · 2025-06-30T03:58:51Z

src/libs/actions/IOU.ts

+        };
+
+        const {report, participantParams, policyParams, transactionParams} = requestMoneyInformation;
+        const parsedComment = getParsedComment(transactionParams.comment ?? '');


Coming from: #64061, we also need to use htmlToMarkdown here

cc @ZhenjaHorbach

eh2077 · 2025-07-06T07:55:11Z

src/libs/actions/IOU.ts

+
+    const firstIOU = iouActions.at(0);
+    if (firstIOU) {
+        const {updatedReportAction, iouReport} = prepareToCleanUpMoneyRequest(originalTransactionID, firstIOU, Permissions.canUseTableReportView(betas));


This caused

[Due for payment 2025-07-04] [$250] LHN - Report preview is displayed as "Deleted Expense" after splitting a held expense. #64147

We should delete the original transaction thread

cc @ZhenjaHorbach

allroundexperts · 2025-07-09T18:23:38Z

src/libs/actions/IOU.ts

+                    description: transactionDetails?.comment,
+                    category: transactionDetails?.category,
+                    tags: transaction?.tag ? [transaction?.tag] : [],
+                    created: transactionDetails?.created ?? DateUtils.getDBTime(),


We should have formatted this. Not doing so caused #63712

cc @ZhenjaHorbach

rushatgabhane · 2025-08-19T02:58:40Z

Coming from #65324

If split isn't available, we should show Not found

src/libs/ReportSecondaryActionUtils.ts

hoangzinh · 2025-11-06T10:53:52Z

src/libs/actions/IOU.ts

+
+        const existingTransactionID = splitExpense.transactionID;
+
+        const {transactionThreadReportID, createdReportActionIDForThread, onyxData, iouAction} = getMoneyRequestInformation({


Coming from #72395, we need to handle split card expenses offline as well. Details here: #72395 (comment)

cc @ZhenjaHorbach

situchan · 2025-12-01T03:38:39Z

src/libs/actions/IOU.ts

+
+    const firstIOU = iouActions.at(0);
+    if (firstIOU) {
+        const {updatedReportAction, iouReport} = prepareToCleanUpMoneyRequest(originalTransactionID, firstIOU, Permissions.canUseTableReportView(betas));


This caused #73386 as prepareToCleanUpMoneyRequest deletes all the IOU report actions if we are deleting the last expense inside the report.

More details: #73386 (comment)

parasharrajat · 2026-02-13T18:17:53Z

src/libs/ReportSecondaryActionUtils.ts

+    const {amount} = getTransactionDetails(reportTransaction) ?? {};
+    if (!amount) {
+        return false;
+    }
+
+    const {isExpenseSplit, isBillSplit} = getOriginalTransactionWithSplitInfo(reportTransaction);
+    if (isExpenseSplit || isBillSplit) {
+        return false;
+    }
+
+    if (!isExpenseReportUtils(report)) {
+        return false;
+    }
+
+    if (report.stateNum && report.stateNum >= CONST.REPORT.STATE_NUM.APPROVED) {


There is an bug here which prevents showing this split action for scanned expenses when user edits the amount manually. #80516

hungvu193 · 2026-03-10T02:56:48Z

src/libs/ReportSecondaryActionUtils.ts

    return canAddTransaction(report);
 }

+function isSplitAction(report: Report, reportTransactions: Transaction[], policy?: Policy): boolean {


We missed a case when the user submits an expense, then changes the submission frequency to Instant.

More details in:
#77663 (comment)

Revert "Revert "Split expense flow""

f09bb6d

ZhenjaHorbach added 2 commits May 29, 2025 21:49

Add newDotSplits beta label

3a5ff7a

Fix tests

729e205

ZhenjaHorbach marked this pull request as ready for review May 29, 2025 20:10

ZhenjaHorbach requested review from a team as code owners May 29, 2025 20:10

melvin-bot bot requested review from rojiphil and removed request for a team May 29, 2025 20:10

lakchote approved these changes May 29, 2025

View reviewed changes

lakchote merged commit 404f940 into Expensify:main May 29, 2025
17 of 18 checks passed

lakchote removed the request for review from rojiphil May 30, 2025 06:14

github-actions bot mentioned this pull request Jun 2, 2025

Deploy Checklist: New Expensify 2025-06-02 #63263

Closed

nlemma mentioned this pull request Jun 3, 2025

[Retest] Expense - Expense cannot be split when report is undo closed #63339

Closed

8 tasks

This was referenced Jun 3, 2025

Split - Tags field appears in split edit page when workspace does not have any tag #63364

Closed

Split - "Tax rate was modified" shows up on the expense row after splitting expense with tax #63367

Closed

nlemma mentioned this pull request Jun 3, 2025

Split - No option to select each tag on split edit page when workspace has multi tags #63376

Closed

8 tasks

melvin-bot bot mentioned this pull request Jun 4, 2025

[Splits in NewDot] (Phase 1) Create the SplitExpensePage and add the Splits action #61027

Closed

dmkt9 mentioned this pull request Jun 13, 2025

[Hold for #64121] Reports - App crashes when returning to reports after deleting splits and creating new ones. #64123

Closed

8 tasks

Kicu mentioned this pull request Jun 24, 2025

Fix computing receiver and payer for IOU transaction preview #64228

Merged

49 tasks

dukenv0307 reviewed Jun 30, 2025

View reviewed changes

eh2077 reviewed Jul 6, 2025

View reviewed changes

allroundexperts reviewed Jul 9, 2025

View reviewed changes

marcaaron mentioned this pull request Aug 12, 2025

[$250] Expense - "Tax no longer valid" shows up briefly on the expense row after splitting expense #68214

Closed

8 tasks

rushatgabhane mentioned this pull request Aug 19, 2025

[Due for payment 2025-08-11] [$50] Expense - Splits show error after non-admin approver splits the expense #65324

Closed

8 tasks

parasharrajat reviewed Oct 13, 2025

View reviewed changes

src/libs/ReportSecondaryActionUtils.ts Show resolved Hide resolved

hoangzinh reviewed Nov 6, 2025

View reviewed changes

situchan reviewed Dec 1, 2025

View reviewed changes

parasharrajat reviewed Feb 13, 2026

View reviewed changes

hungvu193 reviewed Mar 10, 2026

View reviewed changes


		const existingTransactionID = splitExpense.transactionID;

		const {transactionThreadReportID, createdReportActionIDForThread, onyxData, iouAction} = getMoneyRequestInformation({

Conversation

ZhenjaHorbach commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented May 29, 2025

Uh oh!

melvin-bot bot commented May 29, 2025

Uh oh!

lakchote commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented May 29, 2025

Uh oh!

github-actions bot commented May 30, 2025

Uh oh!

github-actions bot commented May 30, 2025

Uh oh!

github-actions bot commented Jun 2, 2025

Uh oh!

github-actions bot commented Jun 3, 2025

Uh oh!

github-actions bot commented Jun 3, 2025

Uh oh!

github-actions bot commented Jun 4, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rushatgabhane commented Aug 19, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parasharrajat Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

ZhenjaHorbach commented May 29, 2025 •

edited

Loading

lakchote commented May 29, 2025 •

edited

Loading

parasharrajat Feb 13, 2026 •

edited

Loading