Fix material top tabs glitch by adamgrzybowski · Pull Request #63570 · Expensify/App

adamgrzybowski · 2025-06-05T15:12:48Z

Explanation of Change

It turned out that the react-native-tab-view causes the bug

It happens on refresh or initial load of the page, when any tab except the first one is selected.

The root cause is:

layout.width determines if we should use a layout that uses the position and translateX animated values.
Both position and translateX are derived from panX
There is a brief moment where layout.width is known, so we use position and translateX, but the panX isn't set yet and is still 0.

I changed the code to make sure that switching to the layout that uses position and translateX is after the panX value is updated

The upstream fix is here: react-navigation/react-navigation#12627

Warning

There is a patch. Make sure to reinstal the node_modules

Fixed Issues

$ #62346
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

Precondition: User has no workspace

refresh

Open the app on the web
Press FAB and select start chat
Select the room tab
Refresh the page
Verify that there is no glitching

go back

Open the app on the web
Press FAB and select start chat
Select the room tab
Press learn more
Press back
Verify that there is no glitching

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

fix.glitch.mov

MacOS: Desktop

github-actions · 2025-06-05T15:13:02Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

melvin-bot · 2025-06-05T15:56:26Z

@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dominictb · 2025-06-09T18:57:46Z

Whoops this is a tough one 😰. I'll need some more testing & research and will provide update in 2-3 days.

adamgrzybowski · 2025-06-13T10:51:56Z

@dominictb, how's it going? Feel free to ask questions about these changes if something isn't clear 😄 Figuring it out wasn't obvious for me

adamgrzybowski · 2025-06-17T10:35:44Z

@dominictb bump once again

dominictb · 2025-06-17T10:37:30Z

I'll come back to this today. Been busy with some urgent project tickets.

dominictb

Minor typos.

dominictb · 2025-06-17T20:03:22Z

...es/react-native-tab-view/react-native-tab-view+4.1.0+002+fix-glitching-on-initial-load.patch

+     panX.setValue(offset);
+-  }, [layout.width, panX]);
+
+    // If the layout.width is 0 it means we still waiting for calculating it.


Suggested change

+ // If the layout.width is 0 it means we still waiting for calculating it.

+ // layout.width is 0 means we still waiting to calculate it

dominictb · 2025-06-17T20:04:14Z

...es/react-native-tab-view/react-native-tab-view+4.1.0+002+fix-glitching-on-initial-load.patch

+
+    // If the layout.width is 0 it means we still waiting for calculating it.
+    if (!layout.width) {
+      // Non null values of these states indicates that we have a proper layout.width


Suggested change

+ // Non null values of these states indicates that we have a proper layout.width

+ // Non-null values of these states indicate that we have a proper layout.width

dominictb · 2025-06-17T20:46:13Z

May I ask why you have two duplicated setPosition here and here?

adamgrzybowski · 2025-06-18T09:16:23Z

May I ask why you have two duplicated setPosition here and here?

This is a good question and the answer is "there is no reason" 😄 I will remove one. Thanks for catching it!

adamgrzybowski · 2025-06-18T10:29:39Z

@dominictb fixed 🫡

dominictb · 2025-06-18T18:07:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-06-19.at.01.44.40.mov

Android: mWeb Chrome

Screen.Recording.2025-06-19.at.01.40.21.mov

iOS: HybridApp

Screen.Recording.2025-06-19.at.01.32.54.mov

iOS: mWeb Safari

Screen.Recording.2025-06-19.at.01.34.16-compressed.mov

MacOS: Chrome / Safari

Screen.Recording.2025-06-19.at.01.25.17.mov

Screen.Recording.2025-06-19.at.01.23.24.mov

MacOS: Desktop

Screen.Recording.2025-06-19.at.01.29.04-compressed.mov

dominictb

dominictb · 2025-06-18T18:46:46Z

@adamgrzybowski Can you update the "go back" test in PR description to include this?

Precondition: User has no workspace

grgia

Thank you for this

OSBotify · 2025-06-19T14:17:25Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

dominictb · 2025-06-19T19:50:57Z

Note

Note for QA: #63570 (comment)

github-actions · 2025-06-20T13:15:33Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.1.70-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-06-24T18:49:39Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

github-actions · 2025-06-24T19:01:20Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

github-actions · 2025-06-24T19:22:21Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

github-actions · 2025-06-24T20:37:42Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

github-actions · 2025-06-24T21:17:57Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

ikevin127 · 2025-09-04T22:51:57Z

...es/react-native-tab-view/react-native-tab-view+4.1.0+002+fix-glitching-on-initial-load.patch

+           style: layout.width ? {
+             width: layout.width
+           } : focused ? StyleSheet.absoluteFill : null,
+-          children: focused || layout.width ? child : null
+          children: focused || translateX ? child : null


Using layout.width here led to this issue:

[Due for payment 2025-09-09] [$125] Room - Create room page blinks when refresh or navigate back to page #64648

and was addressed with translateX instead, running this PRs tests to confirm both fixes are working.

fix material top tabs glitch

90317eb

add PR link in details

dacbdbb

adamgrzybowski marked this pull request as ready for review June 5, 2025 15:56

adamgrzybowski requested a review from a team as a code owner June 5, 2025 15:56

melvin-bot bot requested review from dominictb and removed request for a team June 5, 2025 15:56

add upstream PR link in the details and fix typo

455bb92

dominictb suggested changes Jun 17, 2025

View reviewed changes

fix comments

193de82

dominictb approved these changes Jun 18, 2025

View reviewed changes

melvin-bot bot requested a review from grgia June 18, 2025 18:45

grgia approved these changes Jun 19, 2025

View reviewed changes

grgia merged commit 8c3e013 into Expensify:main Jun 19, 2025
17 checks passed

github-actions bot mentioned this pull request Jun 20, 2025

Deploy Checklist: New Expensify 2025-06-20 #64643

Closed

53 tasks

mitarachim mentioned this pull request Jun 20, 2025

[Due for payment 2025-09-09] [$125] Room - Create room page blinks when refresh or navigate back to page #64648

Closed

8 tasks

melvin-bot bot mentioned this pull request Jun 24, 2025

[Due for payment 2025-07-01] [$250] mWeb - Room - Tapping device back button from workspaces page, chat tab briefly selected. #62346

Closed

8 tasks

ikevin127 reviewed Sep 4, 2025

View reviewed changes

	+ // If the layout.width is 0 it means we still waiting for calculating it.
	+ // layout.width is 0 means we still waiting to calculate it

	+ // Non null values of these states indicates that we have a proper layout.width
	+ // Non-null values of these states indicate that we have a proper layout.width

Conversation

adamgrzybowski commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Jun 5, 2025

Uh oh!

melvin-bot bot commented Jun 5, 2025

Uh oh!

dominictb commented Jun 9, 2025

Uh oh!

adamgrzybowski commented Jun 13, 2025

Uh oh!

adamgrzybowski commented Jun 17, 2025

Uh oh!

dominictb commented Jun 17, 2025

Uh oh!

dominictb left a comment

Choose a reason for hiding this comment

Uh oh!

dominictb Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

dominictb Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

dominictb commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adamgrzybowski commented Jun 18, 2025

Uh oh!

adamgrzybowski commented Jun 18, 2025

Uh oh!

dominictb commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

dominictb left a comment

Choose a reason for hiding this comment

Uh oh!

dominictb commented Jun 18, 2025

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jun 19, 2025

Uh oh!

dominictb commented Jun 19, 2025

Uh oh!

github-actions bot commented Jun 20, 2025

Uh oh!

github-actions bot commented Jun 24, 2025

Uh oh!

github-actions bot commented Jun 24, 2025

Uh oh!

github-actions bot commented Jun 24, 2025

Uh oh!

github-actions bot commented Jun 24, 2025

Uh oh!

github-actions bot commented Jun 24, 2025

Uh oh!

ikevin127 Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

adamgrzybowski commented Jun 5, 2025 •

edited

Loading

dominictb commented Jun 17, 2025 •

edited

Loading

dominictb commented Jun 18, 2025 •

edited

Loading