Improve task and trip related list components performance by hoangzinh · Pull Request #63686 · Expensify/App

hoangzinh · 2025-06-06T17:18:28Z

Explanation of Change

Improve ReportActionsList performance by moving useOnyx connections from task and trip components up to the list level:

TaskAction.tsx => Do nothing
TaskPreview.tsx => lift up taskReport
TaskView.tsx => lift up parentReport
TripDetailsView.tsx => Do nothing
TripRoomPreview.tsx => lift up chatReport

Fixed Issues

$ #63636
PROPOSAL:

Tests

Same as QA

Verify that no errors appear in the JS console

Offline tests

Same as QA

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Test 1: Tasks

Sign in to account A on main testing device
Sign in to account B on 2nd testing device
[Account B] assign a task for account A
[Account A] Verify the task is displayed as normal
[Account B] Change the task name
[Account A] Verify the task name is updated in chat report
[Account A] Click on checkbox to complete the task
[Account A] Verify the task is marked as completed
[Account A] Tap on the task to go to task view page
[Account A] Verify it displays task as normal

Test 2: Trip
Precondition:

Sign in an account has to Travel
FAB -> Book travel
Book any hotel/flight on Spotnana

Steps

Sign in to the account above
Go to Expense Workspace chat
Verify App displays your bookings above as normal

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-06-10.at.09.07.01.android.mov

Android: mWeb Chrome

Screen.Recording.2025-06-10.at.09.11.55.android.chrome.mov

iOS: Native

Screen.Recording.2025-06-10.at.09.20.57.mov

iOS: mWeb Safari

Screen.Recording.2025-06-10.at.09.13.49.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2025-06-09.at.05.40.32.web.mov

MacOS: Desktop

Screen.Recording.2025-06-09.at.05.45.13.desktop.mov

hoangzinh · 2025-06-08T00:19:05Z

Chat report has TaskPreview

=== 📁 Trace File Analysis ===

📄 File: profiling-data.06-08-2025.00-27-21.json
  • Commit count: 33
  • Total render duration: 732.000 ms
  • p50 / p95 / p99 (ms):
    • p50: 2.400 ms
    • p95: 123.500 ms
    • p99: 296.400 ms

📄 File: profiling-data.06-08-2025.07-17-05.json
  • Commit count: 32
  • Total render duration: 660.700 ms
  • p50 / p95 / p99 (ms):
    • p50: 1.300 ms
    • p95: 120.400 ms
    • p99: 297.200 ms

=== 📊 Trace Comparison ===

🔁 Comparing Baseline ↔️ profiling-data.06-08-2025.07-17-05.json
  🟢 Duration Diff: -71.300 ms
  🟢 Commit Count Diff: -1

hoangzinh · 2025-06-08T06:51:26Z

Chat report has TaskView

=== 📁 Trace File Analysis ===

📄 File: profiling-data.06-08-2025.13-48-48.json
  • Commit count: 34
  • Total render duration: 668.400 ms
  • p50 / p95 / p99 (ms):
    • p50: 2.200 ms
    • p95: 178.200 ms
    • p99: 219.000 ms

📄 File: profiling-data.06-08-2025.13-50-53.json
  • Commit count: 32
  • Total render duration: 666.400 ms
  • p50 / p95 / p99 (ms):
    • p50: 3.100 ms
    • p95: 170.500 ms
    • p99: 219.700 ms

=== 📊 Trace Comparison ===

🔁 Comparing Baseline ↔️ profiling-data.06-08-2025.13-50-53.json
  🟢 Duration Diff: -2.000 ms
  🟢 Commit Count Diff: -2

hoangzinh · 2025-06-08T22:24:10Z

Chat report has TripRoomReview


=== 📁 Trace File Analysis ===

📄 File: profiling-data.06-09-2025.05-23-14.json
  • Commit count: 32
  • Total render duration: 728.500 ms
  • p50 / p95 / p99 (ms):
    • p50: 2.300 ms
    • p95: 189.400 ms
    • p99: 245.500 ms

📄 File: profiling-data.06-09-2025.05-19-48.json
  • Commit count: 30
  • Total render duration: 542.200 ms
  • p50 / p95 / p99 (ms):
    • p50: 2.900 ms
    • p95: 107.400 ms
    • p99: 242.500 ms

=== 📊 Trace Comparison ===

🔁 Comparing Baseline ↔️ profiling-data.06-09-2025.05-19-48.json
  🟢 Duration Diff: -186.300 ms
  🟢 Commit Count Diff: -2

melvin-bot · 2025-06-08T22:50:08Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hoangzinh · 2025-06-08T22:51:14Z

Hey @Pujan92, @adhorodyski and @TMisiukiewicz

I still need to complete recordings as part of PR checklist. But this PR is ready for initial reviews

src/components/Search/SearchList.tsx

src/pages/TransactionDuplicate/DuplicateTransactionItem.tsx

hoangzinh · 2025-06-09T10:23:30Z

The eslint failed due to CONST.BETAS.TABLE_REPORT_VIEW will be fixed here #63533. We can ignore those type errors in this PR.

src/pages/TransactionDuplicate/DuplicateTransactionItem.tsx

hoangzinh · 2025-06-10T02:23:44Z

@Pujan92 @adhorodyski @TMisiukiewicz this PR is ready for next review round

src/components/ReportActionItem/TripRoomPreview.tsx

src/pages/home/report/ReportActionItem.tsx

src/pages/Debug/ReportAction/DebugReportActionPreview.tsx

TMisiukiewicz · 2025-06-10T06:30:07Z

@hoangzinh left a couple of more comments, I think these are the last ones 🥇

Pujan92 · 2025-06-10T11:13:55Z

src/pages/home/report/ReportActionsList.tsx

        ({item: reportAction, index}: ListRenderItemInfo<OnyxTypes.ReportAction>) => {
            return (
                <ReportActionsListItemRenderer
+                    allReports={allReports}


@adhorodyski @TMisiukiewicz Isn't passing allReports to all report action children will increase the memory usage?

I think it won't. Because it's gonna pass a reference variable (point to a same memory allocated)

hoangzinh · 2025-06-11T22:26:36Z

cc @Pujan92 for review

Pujan92 · 2025-06-12T10:33:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-06-12.at.17.59.17.mov

Screen.Recording.2025-06-12.at.18.03.52.mov

Screen.Recording.2025-06-12.at.18.05.04.mov

MacOS: Desktop

Pujan92

Codewise looks good, I am yet to add recordings due to failure in builds.

Pujan92 · 2025-06-12T19:02:12Z

@hoangzinh we need to resolve conflicts

hoangzinh · 2025-06-12T22:39:23Z

I resolved the conflict @Pujan92

OSBotify · 2025-06-13T08:10:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-06-16T11:10:28Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.1.67-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

github-actions · 2025-06-17T17:16:49Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.1.67-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

ishpaul777 · 2025-07-09T20:48:16Z

src/components/ReportActionItem/TaskPreview.tsx

    const {translate} = useLocalize();
    const theme = useTheme();
-    const [taskReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${taskReportID}`, {canBeMissing: true});
+    const taskReportID = taskReport?.reportID;


there was a regression #64292, if taskReport is undefined user will be redirected to no found page

hoangzinh added 8 commits June 7, 2025 00:17

Moving useOnyx connections from TaskView

2b5a582

Moving useOnyx connections from TaskPreview

5777a63

Moving useOnyx connections from TripRoomPreview

c013bb9

Run prettier

96f76cb

Refactor passing allReports to ReportActionItem

b94ed31

Fix type error due to missing allReports

1efcfea

Change use custom hook in Search list

23a3137

Fix linter

cb79398

hoangzinh marked this pull request as ready for review June 8, 2025 22:50

hoangzinh requested a review from a team as a code owner June 8, 2025 22:50

melvin-bot bot requested a review from Pujan92 June 8, 2025 22:50

melvin-bot bot removed the request for review from a team June 8, 2025 22:50

TMisiukiewicz reviewed Jun 9, 2025

View reviewed changes

src/components/Search/SearchList.tsx Show resolved Hide resolved

src/pages/TransactionDuplicate/DuplicateTransactionItem.tsx Outdated Show resolved Hide resolved

hoangzinh added 2 commits June 9, 2025 17:05

Lift up get all reports to the list component

3c261ec

Merge branch 'main' into fix/63636-Improve-task-and-trip-performance

8a1bb73

adhorodyski reviewed Jun 9, 2025

View reviewed changes

src/pages/TransactionDuplicate/DuplicateTransactionItem.tsx Show resolved Hide resolved

TMisiukiewicz reviewed Jun 10, 2025

View reviewed changes

src/components/ReportActionItem/TripRoomPreview.tsx Outdated Show resolved Hide resolved

src/pages/home/report/ReportActionItem.tsx Outdated Show resolved Hide resolved

src/pages/Debug/ReportAction/DebugReportActionPreview.tsx Outdated Show resolved Hide resolved

hoangzinh added 3 commits June 10, 2025 17:47

Get report from allReports

45cb399

Get iouReportOfLinkedReport from allReports

fcd3edb

Get report from allReports in ReportActionItem

5969811

Pujan92 reviewed Jun 10, 2025

View reviewed changes

Fix type error

c8f3a77

TMisiukiewicz approved these changes Jun 12, 2025

View reviewed changes

adhorodyski approved these changes Jun 12, 2025

View reviewed changes

hoangzinh mentioned this pull request Jun 12, 2025

[$1,000] Improve lists performance by not calling useOnyx in list items #63439

Closed

Pujan92 approved these changes Jun 12, 2025

View reviewed changes

melvin-bot bot requested a review from mjasikowski June 12, 2025 17:12

Merge branch 'main' into fix/63636-Improve-task-and-trip-performance

8a83f83

mjasikowski approved these changes Jun 13, 2025

View reviewed changes

mjasikowski merged commit cfa3ffc into Expensify:main Jun 13, 2025
17 checks passed

github-actions bot mentioned this pull request Jun 16, 2025

Deploy Checklist: New Expensify 2025-06-16 #64227

Closed

48 tasks

BlameGPT mentioned this pull request Jun 17, 2025

[$250] OD transition - App is unresponsive after closing "At the speed of chat" and reopening the app #64298

Closed

8 tasks

melvin-bot bot mentioned this pull request Jun 17, 2025

[Due for payment 2025-06-24] Improve task and trip related list components performance #63636

Closed

trjExpensify mentioned this pull request Jun 25, 2025

Onboarding tasks open to NotFoundPage for SMB > 11-50 sign-up #64925

Closed

16 tasks

ishpaul777 reviewed Jul 9, 2025

View reviewed changes

Conversation

hoangzinh commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

hoangzinh commented Jun 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hoangzinh commented Jun 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hoangzinh commented Jun 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot bot commented Jun 8, 2025

Uh oh!

hoangzinh commented Jun 8, 2025

Uh oh!

Uh oh!

Uh oh!

hoangzinh commented Jun 9, 2025

Uh oh!

Uh oh!

hoangzinh commented Jun 10, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TMisiukiewicz commented Jun 10, 2025

Uh oh!

Pujan92 Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

hoangzinh Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

Pujan92 Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

hoangzinh commented Jun 11, 2025

Uh oh!

Pujan92 commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Pujan92 left a comment

Choose a reason for hiding this comment

Uh oh!

Pujan92 commented Jun 12, 2025

Uh oh!

hoangzinh commented Jun 12, 2025

Uh oh!

Uh oh!

OSBotify commented Jun 13, 2025

Uh oh!

github-actions bot commented Jun 16, 2025

Uh oh!

github-actions bot commented Jun 17, 2025

Uh oh!

ishpaul777 Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

hoangzinh commented Jun 6, 2025 •

edited

Loading

hoangzinh commented Jun 8, 2025 •

edited

Loading

hoangzinh commented Jun 8, 2025 •

edited

Loading

hoangzinh commented Jun 8, 2025 •

edited

Loading

Pujan92 commented Jun 12, 2025 •

edited

Loading