Completely remove TABLE_REPORT_VIEW beta flag and related components by Kicu · Pull Request #63533 · Expensify/App

Kicu · 2025-06-05T08:29:11Z

This is Part 2 of: #63421

This RP completely removes TABLE_REPORT_VIEW flag and any leftovers and old components related to it.

Explanation of Change

removed the flag and any usages
removed old "preview" components that were used in the past when flag was false, this includes ReportPreview and MoneyRequestPreview
this PR should not change any actual behaviour, as all the things that got removed were already not used in the App

Fixed Issues

$ #63254
PROPOSAL:

Tests

Note: this PR technically only removes code that was already unused, so its not easy to write specific test steps, I'm only describing some general parts of app that are connected

to any chat Report that contains expenses
scroll through it and verify that transaction and report previews are correctly displayed
try deleting an expense and verify it behaves correctly

Offline tests

QA Steps

Read Tests.

PR Author Checklist

Screenshots/Videos

Android: Native

remove-flag-android.mp4

Android: mWeb Chrome

iOS: Native

remove-flag-ios.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

remove-flag-web.mp4

MacOS: Desktop

…RT_VIEW flag

melvin-bot · 2025-06-09T12:17:03Z

@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Kicu · 2025-06-09T12:17:23Z

~~mountiny I think we're missing a C+ here, can you take a look and assign someone?~~
irrelevant

mountiny · 2025-06-09T18:43:03Z

@dominictb can you please review thoroughly

mountiny · 2025-06-10T21:26:09Z

@Kicu There is probably a conflict due to the comment

@dominictb what is your eta for the review?

github-actions · 2025-06-10T21:26:57Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-06-10T22:03:38Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #63533.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/63533/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/63533/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/63533/NewExpensify.dmg	https://63533.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

dominictb · 2025-06-10T23:24:47Z

what is your eta for the review

I'll finish in several hours.

Kicu · 2025-06-11T06:21:27Z

@dominictb conflict solved, merged newest main

dominictb · 2025-06-11T10:42:47Z

src/libs/actions/IOU.ts

-    isSingleTransactionView = false,
-    shouldRemoveIOUTransactionID = !Permissions.isBetaEnabled(CONST.BETAS.TABLE_REPORT_VIEW, betas),
-) {
+function deleteMoneyRequest(transactionID: string | undefined, reportAction: OnyxTypes.ReportAction, isSingleTransactionView = false, shouldRemoveIOUTransactionID = false) {


Suggested change

function deleteMoneyRequest(transactionID: string | undefined, reportAction: OnyxTypes.ReportAction, isSingleTransactionView = false, shouldRemoveIOUTransactionID = false) {

function deleteMoneyRequest(transactionID: string | undefined, reportAction: OnyxTypes.ReportAction, isSingleTransactionView = false) {

I think we can safely remove shouldRemoveIOUTransactionID.

yes! that was my plan but I seem to have forgotten to actualy remove it 👍

dominictb · 2025-06-11T10:45:52Z

src/libs/actions/IOU.ts

    const firstIOU = iouActions.at(0);
    if (firstIOU) {
-        const {updatedReportAction, iouReport} = prepareToCleanUpMoneyRequest(originalTransactionID, firstIOU, Permissions.isBetaEnabled(CONST.BETAS.TABLE_REPORT_VIEW, betas));
+        const {updatedReportAction, iouReport} = prepareToCleanUpMoneyRequest(originalTransactionID, firstIOU, true);


Suggested change

const {updatedReportAction, iouReport} = prepareToCleanUpMoneyRequest(originalTransactionID, firstIOU, true);

const {updatedReportAction, iouReport} = prepareToCleanUpMoneyRequest(originalTransactionID, firstIOU);

dominictb · 2025-06-11T11:04:51Z

src/pages/home/report/PureReportActionItem.tsx

@@ -840,7 +839,7 @@ function PureReportActionItem({
            );

            // Table Report View does not display these components as separate messages, except for self-DM


Suggested change

// Table Report View does not display these components as separate messages, except for self-DM

tests/actions/IOUTest.ts

dominictb

I found some other places where tableReportView is mentioned. Wonder if we could clean up/rename them?

App/src/libs/ReportActionsUtils.ts

Line 1124 in acd5ab8

    
           function useNewTableReportViewActionRenderConditionals({childMoneyRequestCount, childVisibleActionCount, pendingAction, actionName}: ReportAction) {

App/src/libs/actions/Report.ts

Line 968 in 482c959

    
            * @param temporaryShouldUseTableReportView For now MoneyRequestReportView is only supported on Search pages. Once the view is handled on ReportScreens as well we will remove this flag

App/src/libs/API/parameters/OpenReportParams.ts

Line 23 in 7083c03

useTableReportView?: boolean;

dominictb · 2025-06-11T11:24:26Z

@Kicu Can you fix the spelling errors too?

dominictb · 2025-06-11T11:25:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-06-13.at.00.29.13-compressed.mov

Android: mWeb Chrome

Screen.Recording.2025-06-13.at.00.33.11.mov

iOS: HybridApp

Screen.Recording.2025-06-12.at.23.55.46-compressed.mov

iOS: mWeb Safari

Screen.Recording.2025-06-12.at.23.59.57-compressed.mov

MacOS: Chrome / Safari

Screen.Recording.2025-06-12.at.23.46.11-compressed.mov

MacOS: Desktop

Screen.Recording.2025-06-12.at.23.58.31-compressed.mov

Kicu · 2025-06-11T15:08:29Z

I will come back to this tomorrow and fix all comments

Kicu · 2025-06-12T07:56:23Z

@dominictb changes implemented, had to merge newest main because there were conflicts.

About this comment: #63533 (review)

In general we tend to use the phrase table report view as the name for money request report, which is displayed with a table of transactions. So I think we will not completely get rid of tableReportView from the code - that is ok.
I went over the usages in the code and decided that most make sense, with the exception of this:

App/src/libs/actions/Report.ts

Lines 1096 to 1098 in 26ae296

    
           if (temporaryShouldUseTableReportView) { 
        
               parameters.useTableReportView = true; 
        
           }

which I went ahead and asked @mountiny for opinion - perhaps we can remove this.

Kicu · 2025-06-12T08:03:13Z

TS is failing, because there is a TS error on main - it does not come from my PR so I'm leaving it be.

Once we approve this PR I can sync with freshest main.

dominictb · 2025-06-12T08:11:12Z

Sounds good!

Kicu · 2025-06-12T08:55:31Z

@dominictb Vit told me that for now parameters.useTableReportView = true has to stay, because backend still uses it. So first it will have to be removed from BE.

So I think you can verify that I fixed everything else and continue 🙏

dominictb

Tests well

mountiny · 2025-06-12T22:49:37Z

Sorry there are conflicts now, can you please resolve?

Kicu · 2025-06-13T05:47:45Z

Sure, please let's merge it because the conflicts are in a file that I'm removing - because we no longer render it (it's the old preview that is not shown without flag) :|

It's the second time some edited the file that is going away. This project is a bit chaotic for such refactors 🙈

mountiny

Thanks!

OSBotify · 2025-06-13T15:18:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-06-16T11:10:16Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.67-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

github-actions · 2025-06-17T17:16:37Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.1.67-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Kicu force-pushed the kicu/63254-remove-beta-flag branch 2 times, most recently from 870888a to bb8da07 Compare June 9, 2025 09:14

Remove TABLE_REPORT_VIEW beta flag and everything connected

bb286aa

Kicu force-pushed the kicu/63254-remove-beta-flag branch 2 times, most recently from 2d7d466 to 987a498 Compare June 9, 2025 09:22

Fully remove components related to old report previews and TABLE_REPO…

5b7f575

…RT_VIEW flag

Kicu force-pushed the kicu/63254-remove-beta-flag branch from 987a498 to 5b7f575 Compare June 9, 2025 09:37

hoangzinh mentioned this pull request Jun 9, 2025

Improve task and trip related list components performance #63686

Merged

51 tasks

Kicu marked this pull request as ready for review June 9, 2025 12:16

Kicu requested a review from a team as a code owner June 9, 2025 12:16

melvin-bot bot requested a review from dominictb June 9, 2025 12:17

melvin-bot bot removed the request for review from a team June 9, 2025 12:17

JakubKorytko mentioned this pull request Jun 9, 2025

Adjust #63648 PR code to new pure Onyx functions rule #63731

Merged

48 tasks

Merge branch 'main' into kicu/63254-remove-beta-flag

2a4ee77

dominictb suggested changes Jun 11, 2025

View reviewed changes

dominictb reviewed Jun 11, 2025

View reviewed changes

mountiny assigned Kicu Jun 11, 2025

Kicu added 2 commits June 12, 2025 09:47

Add review fixes after TABLE_REPORT_VIEW flag removal

705aa2d

Merge branch 'main' into kicu/63254-remove-beta-flag

b792108

Merge branch 'main' into kicu/63254-remove-beta-flag

229ea6b

Kicu mentioned this pull request Jun 12, 2025

[Due for payment 2025-06-24] [$250] [Better Expense Report View] Deprecate tableReportView beta and old preview components #63254

Closed

dominictb approved these changes Jun 12, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny June 12, 2025 17:34

Merge branch 'main' into kicu/63254-remove-beta-flag

586a61c

mountiny approved these changes Jun 13, 2025

View reviewed changes

mountiny merged commit aa2f819 into Expensify:main Jun 13, 2025
17 checks passed

github-actions bot mentioned this pull request Jun 16, 2025

Deploy Checklist: New Expensify 2025-06-16 #64227

Closed

48 tasks

	function deleteMoneyRequest(transactionID: string \| undefined, reportAction: OnyxTypes.ReportAction, isSingleTransactionView = false, shouldRemoveIOUTransactionID = false) {
	function deleteMoneyRequest(transactionID: string \| undefined, reportAction: OnyxTypes.ReportAction, isSingleTransactionView = false) {

	const {updatedReportAction, iouReport} = prepareToCleanUpMoneyRequest(originalTransactionID, firstIOU, true);
	const {updatedReportAction, iouReport} = prepareToCleanUpMoneyRequest(originalTransactionID, firstIOU);

		@@ -840,7 +839,7 @@ function PureReportActionItem({
		);

		// Table Report View does not display these components as separate messages, except for self-DM

Conversation

Kicu commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jun 9, 2025

Uh oh!

Kicu commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mountiny commented Jun 9, 2025

Uh oh!

mountiny commented Jun 10, 2025

Uh oh!

github-actions bot commented Jun 10, 2025

Uh oh!

github-actions bot commented Jun 10, 2025

Uh oh!

dominictb commented Jun 10, 2025

Uh oh!

Kicu commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dominictb Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

Kicu Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

dominictb Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

dominictb Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dominictb left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dominictb commented Jun 11, 2025

Uh oh!

dominictb commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Kicu commented Jun 11, 2025

Uh oh!

Kicu commented Jun 12, 2025

Uh oh!

Kicu commented Jun 12, 2025

Uh oh!

dominictb commented Jun 12, 2025

Uh oh!

Kicu commented Jun 12, 2025

Uh oh!

dominictb left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny commented Jun 12, 2025

Uh oh!

Kicu commented Jun 13, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jun 13, 2025

Uh oh!

github-actions bot commented Jun 16, 2025

Uh oh!

github-actions bot commented Jun 17, 2025

Kicu commented Jun 5, 2025 •

edited

Loading

Kicu commented Jun 9, 2025 •

edited

Loading

Kicu commented Jun 11, 2025 •

edited

Loading

dominictb left a comment •

edited

Loading

dominictb commented Jun 11, 2025 •

edited

Loading