Fix useTransactionViolations returning stale violations data by mollfpr · Pull Request #63722 · Expensify/App

mollfpr · 2025-06-07T12:24:09Z

Explanation of Change

We are using useOnyx with the transactionID key to get the violations data. Apparently, this won't guarantee the return of the latest data. So instead of using a key to get Onyx data, we use the collection to get the violations. We have a similar approach on the other components, such as MoneyReportHeader or LHNOptionsList.

Fixed Issues

$ #62541
PROPOSAL:

Tests

Same as the QA steps.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Prerequisites:

On Web/Desktop, zoom in to activate the narrow layout

Go to any 1:1 chat
Submit two expenses to the user
Go to Reports/Search page
Go to the Reports tab
Select all the submitted expenses
Click on the dropdown button
Click Hold
Enter the reason and save it
Verify the RBR hold expense message is shown
Select all the submitted expenses again
Click on the dropdown button
Click Remove Hold
Verify the RBR hold expense message has disappeared

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.Jun.9.2025.mp4

MacOS: Desktop

melvin-bot · 2025-06-09T12:01:08Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shubham1206agra · 2025-06-10T01:43:52Z

@mollfpr I asked for help here since this solution looks like a workaround.

shubham1206agra · 2025-06-10T01:44:45Z

We have a similar approach on the other components, such as MoneyReportHeader or LHNOptionsList

@mollfpr Can you link these examples here?

…e-transaction-violations

mollfpr · 2025-06-18T04:22:57Z

@shubham1206agra I have reverted the first changes and only change to use custom useOnyx. Could you review it? Thank you!

shubham1206agra · 2025-06-19T12:41:31Z

Screen.Recording.2025-06-19.at.6.08.21.PM.mov

@mollfpr The holding and unholding of expenses seems to be super slow for some reason. It is making 2 Search request here.

shubham1206agra · 2025-06-19T14:51:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
xIf a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-06-19.at.8.11.03.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-06-19.at.6.46.24.PM.mov

iOS: HybridApp

Screen.Recording.2025-06-19.at.7.36.10.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-06-19.at.6.42.34.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-06-19.at.6.08.21.PM.mov

MacOS: Desktop

Screen.Recording.2025-06-19.at.6.54.23.PM.mov

melvin-bot · 2025-06-19T14:52:01Z

@rlinoz Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rlinoz · 2025-06-19T16:22:18Z

src/hooks/useTransactionViolations.ts

-    const [transaction] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`);
-    const [transactionViolations = []] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionID}`);
+    const [transaction] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, {
+        canBeMissing: true,
+    });
+    const [transactionViolations = []] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionID}`, {
+        canBeMissing: true,
+    });


Im a little confused, it looks like the PR description doesn't seem to line up with the changes? It looks like we are just adding the canBeMissing but why?

@rlinoz It was not updated, but the actual update is https://expensify.slack.com/archives/C05LX9D6E07/p1749519744150989. TLDR - We are now using a custom useOnyx hook to resolve this issue.

aaah we changed the import and are using a different useOnyx, got it. Thanks!

rlinoz · 2025-06-19T16:36:52Z

src/hooks/useTransactionViolations.ts

-    const [transaction] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`);
-    const [transactionViolations = []] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionID}`);
+    const [transaction] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, {
+        canBeMissing: true,
+    });
+    const [transactionViolations = []] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionID}`, {
+        canBeMissing: true,
+    });


aaah we changed the import and are using a different useOnyx, got it. Thanks!

OSBotify · 2025-06-19T16:59:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-06-20T13:15:39Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.1.70-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-06-24T18:49:45Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

github-actions · 2025-06-24T19:01:26Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

github-actions · 2025-06-24T19:22:27Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

github-actions · 2025-06-24T20:37:48Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

github-actions · 2025-06-24T21:18:03Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

using get collection data instead of key preventing stale data

548356a

mollfpr self-assigned this Jun 7, 2025

fix eslint

7010d78

mollfpr marked this pull request as ready for review June 9, 2025 12:01

mollfpr requested a review from a team as a code owner June 9, 2025 12:01

melvin-bot bot requested review from shubham1206agra and removed request for a team June 9, 2025 12:01

mollfpr added 4 commits June 11, 2025 22:57

revert changes

e321238

use custom wrapper for useOnyx

82be18a

Merge branch 'main' of github.com:Expensify/App into mollfpr-fix-stal…

ea4eb8d

…e-transaction-violations

fix check failure

bd18c08

shubham1206agra approved these changes Jun 19, 2025

View reviewed changes

melvin-bot bot requested a review from rlinoz June 19, 2025 14:52

rlinoz reviewed Jun 19, 2025

View reviewed changes

rlinoz approved these changes Jun 19, 2025

View reviewed changes

rlinoz merged commit cb68c85 into main Jun 19, 2025
24 checks passed

rlinoz deleted the mollfpr-fix-stale-transaction-violations branch June 19, 2025 16:50

github-actions bot mentioned this pull request Jun 20, 2025

Deploy Checklist: New Expensify 2025-06-20 #64643

Closed

53 tasks

melvin-bot bot mentioned this pull request Jun 24, 2025

[Due for payment 2025-07-01] Reports - After unholding all the expenses, "Hold" label still remains on one of the expenses #62541

Closed

8 tasks

Conversation

mollfpr commented Jun 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jun 9, 2025

Uh oh!

shubham1206agra commented Jun 10, 2025

Uh oh!

shubham1206agra commented Jun 10, 2025

Uh oh!

mollfpr commented Jun 18, 2025

Uh oh!

shubham1206agra commented Jun 19, 2025

Uh oh!

shubham1206agra commented Jun 19, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jun 19, 2025

Uh oh!

rlinoz Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

shubham1206agra Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

rlinoz Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

rlinoz Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jun 19, 2025

Uh oh!

github-actions bot commented Jun 20, 2025

Uh oh!

github-actions bot commented Jun 24, 2025

Uh oh!

github-actions bot commented Jun 24, 2025

Uh oh!

github-actions bot commented Jun 24, 2025

Uh oh!

github-actions bot commented Jun 24, 2025

Uh oh!

github-actions bot commented Jun 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mollfpr commented Jun 7, 2025 •

edited

Loading